This seems to be a typo, I think the original variable name was mean to be isedge or is_edge. Perhaps this check would be simpler to understand and would not create local variable if it were like this?
if (*end == *start) return S_FALSE;
Regards, Indrek
On Wed, Sep 17, 2014 at 11:35:50AM +0300, Indrek Altpere wrote:
This seems to be a typo, I think the original variable name was mean to be isedge or is_edge.
No, I fairly sure it's short for degenerate - that term is used in the docs.
Perhaps this check would be simpler to understand and would not create local variable if it were like this?
if (*end == *start) return S_FALSE;
Yup, just suggested that too (I need more coffee!).
Thanks, Huw.
Thank you! A newer version was sent.
2014-09-17 16:39 GMT+08:00 Huw Davies huw@codeweavers.com:
On Wed, Sep 17, 2014 at 11:35:50AM +0300, Indrek Altpere wrote:
This seems to be a typo, I think the original variable name was mean to
be
isedge or is_edge.
No, I fairly sure it's short for degenerate - that term is used in the docs.
Perhaps this check would be simpler to understand and would not create
local
variable if it were like this?
if (*end == *start) return S_FALSE;
Yup, just suggested that too (I need more coffee!).
Thanks, Huw.
-
Huw Davies -
Indrek Altpere -
Jactry Zeng