Re: [PATCH] vbscript: Fixed CBool(try 3)

[Piotr Caban]

On 05/02/14 06:22, Shuai Meng wrote:
> testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731
>
> Changelog:
>    added more tests on object;
>    changed the implemention of some tests that caused "Err.number = 0"
>    rearranged the order of tests
>
> dlls/vbscript/global.c      | 41 ++++++++++-------------------------
>   dlls/vbscript/tests/api.vbs | 53
> +++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 65 insertions(+), 29 deletions(-)

The tests are failing on wine on polish locale:

LC_ALL=pl_PL make test
../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p 
vbscript_test.exe.so run && touch run.ok
fixme:thread:GetThreadUILanguage : stub, returning default language.
run.c:2102: Tests skipped: Skipping some tests in non-English locale
fixme:vbscript:parse_script parser failed around L"<!--"
fixme:vbscript:do_icall L"y" not found
fixme:vbscript:DispatchEx_InvokeEx no letter/setter
run.c:1917: Test failed: expected global_success_d
run.c:1918: Test failed: expected global_success_i
run.c:1920: Test failed: parse_script failed: 800a000d
fixme:vbscript:ClassFactory_QueryInterface 
(0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0)
fixme:vbscript:RegExp2_QueryInterface 
(0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c)
fixme:vbscript:interp_enumnext uninitialized
fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY}
fixme:vbscript:interp_enumnext uninitialized
fixme:vbscript:show_msgbox failed: 80004005
fixme:vbscript:show_msgbox blocked
make: *** [run.ok] B³±d 3

[PATCH] vbscript: Fixed CBool(try 3)

[Piotr Caban]

On 05/02/14 14:10, Piotr Caban wrote:
> On 05/02/14 06:22, Shuai Meng wrote:
> > testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731
> >
> > Changelog:
> >    added more tests on object;
> >    changed the implemention of some tests that caused "Err.number = 0"
> >    rearranged the order of tests
> >
> > dlls/vbscript/global.c      | 41 ++++++++++-------------------------
> >   dlls/vbscript/tests/api.vbs | 53
> > +++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 65 insertions(+), 29 deletions(-)
>
> The tests are failing on wine on polish locale:
>
> LC_ALL=pl_PL make test
> ../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p
> vbscript_test.exe.so run && touch run.ok
> fixme:thread:GetThreadUILanguage : stub, returning default language.
> run.c:2102: Tests skipped: Skipping some tests in non-English locale
> fixme:vbscript:parse_script parser failed around L"<!--"
> fixme:vbscript:do_icall L"y" not found
> fixme:vbscript:DispatchEx_InvokeEx no letter/setter
> run.c:1917: Test failed: expected global_success_d
> run.c:1918: Test failed: expected global_success_i
> run.c:1920: Test failed: parse_script failed: 800a000d
> fixme:vbscript:ClassFactory_QueryInterface
> (0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0)
> fixme:vbscript:RegExp2_QueryInterface
> (0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c)
> fixme:vbscript:interp_enumnext uninitialized
> fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY}
> fixme:vbscript:interp_enumnext uninitialized
> fixme:vbscript:show_msgbox failed: 80004005
> fixme:vbscript:show_msgbox blocked
> make: *** [run.ok] B³±d 3

The tests are also failing on windows with polish locale. It's caused by 
different decimal separator. Please disable this tests on non-english 
locale:
Call ok(CBool("0.1") = True, "CBool(""0.1"") = " & CBool("0.1"))
Call ok(getVT(CBool("0.1")) = "VT_BOOL", "getVT(CBool(""0.1"")) = " & 
getVT(CBool("0.1")))

Also it turns out that "Prawda" string (True translated to polish) is 
working on windows with polish locale. This means that you were right 
using VARIANT_LOCALBOOL flag in VariantChangeType. Sorry for that.

Thanks,
Piotr

[PATCH] vbscript: Fixed CBool(try 3)

[Shuai Meng]

2014-05-02 21:10 GMT+08:00 Piotr Caban :
> On 05/02/14 14:10, Piotr Caban wrote:
> > On 05/02/14 06:22, Shuai Meng wrote:
> > > testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731
> > >
> > > Changelog:
> > >    added more tests on object;
> > >    changed the implemention of some tests that caused "Err.number = 0"
> > >    rearranged the order of tests
> > >
> > > dlls/vbscript/global.c      | 41 ++++++++++-------------------------
> > >   dlls/vbscript/tests/api.vbs | 53
> > > +++++++++++++++++++++++++++++++++++++++++++++
> > >   2 files changed, 65 insertions(+), 29 deletions(-)
> > >
> > > The tests are failing on wine on polish locale:
> >
> > LC_ALL=pl_PL make test
> > ../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p
> > vbscript_test.exe.so run && touch run.ok
> > fixme:thread:GetThreadUILanguage : stub, returning default language.
> > run.c:2102: Tests skipped: Skipping some tests in non-English locale
> > fixme:vbscript:parse_script parser failed around L"<!--"
> > fixme:vbscript:do_icall L"y" not found
> > fixme:vbscript:DispatchEx_InvokeEx no letter/setter
> > run.c:1917: Test failed: expected global_success_d
> > run.c:1918: Test failed: expected global_success_i
> > run.c:1920: Test failed: parse_script failed: 800a000d
> > fixme:vbscript:ClassFactory_QueryInterface
> > (0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0)
> > fixme:vbscript:RegExp2_QueryInterface
> > (0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c)
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY}
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:show_msgbox failed: 80004005
> > fixme:vbscript:show_msgbox blocked
> > make: *** [run.ok] Błąd 3
>
> The tests are also failing on windows with polish locale. It's caused by
> different decimal separator. Please disable this tests on non-english
> locale:
> Call ok(CBool("0.1") = True, "CBool(""0.1"") = " & CBool("0.1"))
> Call ok(getVT(CBool("0.1")) = "VT_BOOL", "getVT(CBool(""0.1"")) = " &
> getVT(CBool("0.1")))
>
> ok.
> Also it turns out that "Prawda" string (True translated to polish) is
> working on windows with polish locale. This means that you were right using
> VARIANT_LOCALBOOL flag in VariantChangeType. Sorry for that.
>
> That's all right. So need I test the patch in other locales such as French

or German on both wine and windows?
> Thanks,
> Piotr

[PATCH] vbscript: Fixed CBool(try 3)

[Piotr Caban]

On 05/02/14 16:03, Shuai Meng wrote:
> That's all right. So need I test the patch in other locales such as
> French or German on both wine and windows?

The idea is that the tests should pass on every windows and wine no 
matter what locale is set.

I think that you don't have to do it yourself. Hopefully in most cases 
testbot will catch the problems (it has some non-english test machines).

[PATCH] vbscript: Fixed CBool(try 3)

[Shuai Meng]

2014-05-02 21:10 GMT+08:00 Piotr Caban :
> On 05/02/14 14:10, Piotr Caban wrote:
> > On 05/02/14 06:22, Shuai Meng wrote:
> > > testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731
> > >
> > > Changelog:
> > >    added more tests on object;
> > >    changed the implemention of some tests that caused "Err.number = 0"
> > >    rearranged the order of tests
> > >
> > > dlls/vbscript/global.c      | 41 ++++++++++-------------------------
> > >   dlls/vbscript/tests/api.vbs | 53
> > > +++++++++++++++++++++++++++++++++++++++++++++
> > >   2 files changed, 65 insertions(+), 29 deletions(-)
> > >
> > > The tests are failing on wine on polish locale:
> >
> > LC_ALL=pl_PL make test
> > ../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p
> > vbscript_test.exe.so run && touch run.ok
> > fixme:thread:GetThreadUILanguage : stub, returning default language.
> > run.c:2102: Tests skipped: Skipping some tests in non-English locale
> > fixme:vbscript:parse_script parser failed around L"<!--"
> > fixme:vbscript:do_icall L"y" not found
> > fixme:vbscript:DispatchEx_InvokeEx no letter/setter
> > run.c:1917: Test failed: expected global_success_d
> > run.c:1918: Test failed: expected global_success_i
> > run.c:1920: Test failed: parse_script failed: 800a000d
> > fixme:vbscript:ClassFactory_QueryInterface
> > (0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0)
> > fixme:vbscript:RegExp2_QueryInterface
> > (0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c)
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY}
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:show_msgbox failed: 80004005
> > fixme:vbscript:show_msgbox blocked
> > make: *** [run.ok] Błąd 3
>
> The tests are also failing on windows with polish locale. It's caused by
> different decimal separator. Please disable this tests on non-english
> locale:
> Call ok(CBool("0.1") = True, "CBool(""0.1"") = " & CBool("0.1"))
> Call ok(getVT(CBool("0.1")) = "VT_BOOL", "getVT(CBool(""0.1"")) = " &
> getVT(CBool("0.1")))
>
> Also it turns out that "Prawda" string (True translated to polish) is
> working on windows with polish locale. This means that you were right using
> VARIANT_LOCALBOOL flag in VariantChangeType. Sorry for that.
>
> Thanks,
> Piotr

I have done  the things above, anythings else to be noticed?  If not, I
will resend this patch after testing it.

[PATCH] vbscript: Fixed CBool(try 3)

[Piotr Caban]

On 05/02/14 17:08, Shuai Meng wrote:
> I have done  the things above, anythings else to be noticed?  If not, I
> will resend this patch after testing it.

I don't see other problems related to that patch.

Thanks,
Piotr

[PATCH] vbscript: Fixed CBool(try 3)

[Shuai Meng]

2014-05-02 21:10 GMT+08:00 Piotr Caban :
> On 05/02/14 14:10, Piotr Caban wrote:
> > On 05/02/14 06:22, Shuai Meng wrote:
> > > testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731
> > >
> > > Changelog:
> > >    added more tests on object;
> > >    changed the implemention of some tests that caused "Err.number = 0"
> > >    rearranged the order of tests
> > >
> > > dlls/vbscript/global.c      | 41 ++++++++++-------------------------
> > >   dlls/vbscript/tests/api.vbs | 53
> > > +++++++++++++++++++++++++++++++++++++++++++++
> > >   2 files changed, 65 insertions(+), 29 deletions(-)
> > >
> > > The tests are failing on wine on polish locale:
> >
> > LC_ALL=pl_PL make test
> > ../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p
> > vbscript_test.exe.so run && touch run.ok
> > fixme:thread:GetThreadUILanguage : stub, returning default language.
> > run.c:2102: Tests skipped: Skipping some tests in non-English locale
> > fixme:vbscript:parse_script parser failed around L"<!--"
> > fixme:vbscript:do_icall L"y" not found
> > fixme:vbscript:DispatchEx_InvokeEx no letter/setter
> > run.c:1917: Test failed: expected global_success_d
> > run.c:1918: Test failed: expected global_success_i
> > run.c:1920: Test failed: parse_script failed: 800a000d
> > fixme:vbscript:ClassFactory_QueryInterface
> > (0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0)
> > fixme:vbscript:RegExp2_QueryInterface
> > (0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c)
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY}
> > fixme:vbscript:interp_enumnext uninitialized
> > fixme:vbscript:show_msgbox failed: 80004005
> > fixme:vbscript:show_msgbox blocked
> > make: *** [run.ok] Błąd 3
>
> The tests are also failing on windows with polish locale. It's caused by
> different decimal separator. Please disable this tests on non-english
> locale:
> Call ok(CBool("0.1") = True, "CBool(""0.1"") = " & CBool("0.1"))
> Call ok(getVT(CBool("0.1")) = "VT_BOOL", "getVT(CBool(""0.1"")) = " &
> getVT(CBool("0.1")))
>
> Also it turns out that "Prawda" string (True translated to polish) is
> working on windows with polish locale. This means that you were right using
> VARIANT_LOCALBOOL flag in VariantChangeType. Sorry for that.
>
> Thanks,
> Piotr

Well, about two weeks ago I tested CStr(True) = "True" on windows with
different locales, and I'd like to share the results. Maybe they can help
in the future.

When locale is zh_CN, ko_KR, ja_JP : CStr(True) = "True" and CStr(False) =
"False" can pass directly while others caused an error.
de_DE：CStr(True) = "Wahr"; CStr(False) = "Falsch"
ru_RU:  CStr(True) = "\0418\0441\0442\38\043d\0430"; CStr(False) =
 "\041b\043e\0436\044c"
pl_PL: CStr(True) = "Prawda"; CStr(False) = "Fa\0142sz"
fr_FR : CStr(True) = "Vrai"; CStr(False) = "Faux"

Thanks.