Re: [Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

Looks like someone else is having this problem.  I've
tried looking at listview.c and the treeview
equivalent as well, but I can't made heads or tails of
it.  I have no experience with C.

Anybody on this list make any changes to listview or
treeview in the last few months?

Hiji
> ------- Additional Comments From
> [e-mail]  2005-04-08 23:58 -------
> About the same problem with AceFTP
>
> Free download for trial

http://software.visicommedia.com/en/products/aceftpfreeware/
> wine-20050524-1fc1winehq
>
> Problem starts before I do the FTP thing.
> When I drag a file within the local pane(a
> listview),
> a copy of that file is immediately created. But
> things
> don't stop there. The moment I move the mouse a bit,
> AceFTP asks me with a popup menu if want to:
>   Move to current location
>   Copy to current location or
>   Create a short
> If I choose to copy, ANOTHER copy of the file is
> created.
> After that, every time I move the mouse,
> AceFTP asks me again, thus an infinite loop
> and infinite number of copies of the same file.
>
> BTW. I have to use native shell related dlls for
> AceFTP to
> display the local pane. So I suspect the problem is
> with
> the interaction between native and builtin code.
>
> I hope my English is good enough for me to make some
> sense...
>
> -- 
> Configure bugmail:
> http://bugs.winehq.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Andreas Mohr]

Hi,

On Thu, Aug 04, 2005 at 10:23:23PM -0700, Hiji wrote:
> Looks like someone else is having this problem.  I've
> tried looking at listview.c and the treeview
> equivalent as well, but I can't made heads or tails of
> it.  I have no experience with C.
>
> Anybody on this list make any changes to listview or
> treeview in the last few months?

I wouldn't even find it hard to believe that they already forgot about it...

If you want hard, definitive data, then I I cannot find any reason why you
wouldn't want to look at ChangeLog...

Andreas Mohr

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

> > Anybody on this list make any changes to listview
>
> or
> > treeview in the last few months?
>
> I wouldn't even find it hard to believe that they
> already forgot about it...
>
> If you want hard, definitive data, then I I cannot
> find any reason why you
> wouldn't want to look at ChangeLog...

How about this: I didn't know about ChangeLog!  LOL! 
I'm looking through it now... ;)

Thanks!
Hiji

____________________________________________________
Start your day with Yahoo! - make it your home page 
http://www.yahoo.com/r/hs

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

--- Vitaly Lipatov  wrote:
> Hi, Can you pay attention to this patch? It really

fixes
> the problem but not 
> discussed in the list and not applied:

http://www.winehq.com/hypermail/wine-patches/2005/08/0018.html

WOOHOO!  This fixes "half" the problem with Bug3148. 
Once I applied the patch, I no longer had the problem
with the effect of the mouse button being continously
pressed once I clicked on something.

However, one problem still remains.  If I select 3
items (shift + click from start item to finish item),
and I click with the left-mouse, my selection is lost
as now only 1 item is selected (the one I clicked on).
 However, if I right-click, my selection isn't lost.

It seems what *should* happen is the following:
1. you make your selection in a listview (2+ items) by
using the shiftkey + left-mouse button
2. let go of shiftkey and items are still selected
3. click on one of the highlighted items
4. selection remains intact
5. drag-drop as you wish

However, things seem to go amiss at step 3.  I can
somewhat retain the selection if I keep the shift-key
pressed throughout the process -- which is not the
norm as I should let go at step 2..

So, can someone listen (pay attention) to Vitaly and
apply the patch so at least this bug can get half-way
fixed???

Thanks!
Hiji

--- Hiji  wrote:
> > > Anybody on this list make any changes to
>
> listview
> > or
> > > treeview in the last few months?
> >
> > I wouldn't even find it hard to believe that they
> > already forgot about it...
> >
> > If you want hard, definitive data, then I I cannot
> > find any reason why you
> > wouldn't want to look at ChangeLog...
>
> How about this: I didn't know about ChangeLog!  LOL!
>
> I'm looking through it now... ;)
>
> Thanks!
> Hiji
>
> ____________________________________________________
> Start your day with Yahoo! - make it your home page 
> http://www.yahoo.com/r/hs

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Saulius Krasuckas]

* On Tue, 23 Aug 2005, Hiji wrote:
> --- Vitaly Lipatov  wrote:
> > Hi, Can you pay attention to this patch? It really fixes the problem 
> > but not discussed in the list and not applied:
>
> http://www.winehq.com/hypermail/wine-patches/2005/08/0018.html
>
> WOOHOO!  This fixes "half" the problem with Bug3148. 
> Once I applied the patch, I no longer had the problem
> with the effect of the mouse button being continously
> pressed once I clicked on something.

...
> So, can someone listen (pay attention) to Vitaly and
> apply the patch so at least this bug can get half-way
> fixed???

The patch has 2 points to change (I am afraid):

a, header of its first section refers to "sysparams.c" and 
   "dlls/user/sysparams.c", which makes patcher to not find needed file
   (dlls/user/tests/sysparams.c).
   Command "cvs diff -pu dlls/user/" would do the job. :-P

b, first hunk of the second section (dlls/user/sysparams.c) is already 
   in the tree, so it fails too.

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

--- Saulius Krasuckas  wrote:
> - On Tue, 23 Aug 2005, Hiji wrote:
> > --- Vitaly Lipatov  wrote:
> > > Hi, Can you pay attention to this patch? It
>
> really fixes the problem
> > > but not discussed in the list and not applied:

http://www.winehq.com/hypermail/wine-patches/2005/08/0018.html
> > WOOHOO!  This fixes "half" the problem with
>
> Bug3148.
> > Once I applied the patch, I no longer had the
>
> problem
> > with the effect of the mouse button being
>
> continously
> > pressed once I clicked on something.
>
> ...
> > So, can someone listen (pay attention) to Vitaly
>
> and
> > apply the patch so at least this bug can get
>
> half-way
> > fixed???
>
> The patch has 2 points to change (I am afraid):
>
> a, header of its first section refers to
> "sysparams.c" and 
>    "dlls/user/sysparams.c", which makes patcher to
> not find needed file
>    (dlls/user/tests/sysparams.c).
>    Command "cvs diff -pu dlls/user/" would do the
> job. :-P
>
> b, first hunk of the second section
> (dlls/user/sysparams.c) is already 
>    in the tree, so it fails too.

Ok, I had applied it to the July release, but if some
changes are already in the tree, then that's good
news.  Vitaly, any thoughts on this?

Hiji

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Saulius Krasuckas]

* On Wed, 24 Aug 2005, Hiji wrote:
> --- Saulius Krasuckas  wrote:
> > a, header of its first section refers to
> >    "sysparams.c" and "dlls/user/sysparams.c", 
> >    which makes patcher to not find needed file
> >    (dlls/user/tests/sysparams.c).
> >
> > b, first hunk of the second section
> >    (dlls/user/sysparams.c) is already in the 
> >    tree, so it fails too.
>
> Ok, I had applied it to the July release, but if some
> changes are already in the tree, then that's good
> news.

Not very good, as the mentioned change is only cosmetic.
> Vitaly, any thoughts on this?

If Vitaly is busy and won't object, I can resync his changes to the 
current CVS and send a patch from his name.

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Vitaly Lipatov]

В сообщении от 24 Август 2005 22:14 Вы написали:
> If Vitaly is busy and won't object, I can resync his changes to the
> current CVS and send a patch from his name.

Well, I resent my patch again to wine-devel...

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

--- Vitaly Lipatov  wrote:
> ÷ ÓÏÏÂÝÅÎÉÉ ÏÔ 24 á×ÇÕÓÔ 2005 22:14 ÷Ù ÎÁÐÉÓÁÌÉ:
> > If Vitaly is busy and won't object, I can resync
>
> his changes to the
> > current CVS and send a patch from his name.
>
> Well, I resent my patch again to wine-devel...

And the bug lives on in wine-20050830.  Is this
something I should not hope on ever getting fixed or
having the patch merged into the tree?

I think this is a REALLY serious bug.  What good is
Wine if mouse behavior is broken? :(

Hiji

____________________________________________________
Start your day with Yahoo! - make it your home page 
http://www.yahoo.com/r/hs

[Bug 3148] Mouse: multi-file "selection" & drag behavior broken

[Hiji]

What do I do?  I'm still seeing the same mouse
misbehaviors in wine-20050930 as I have been seeing
for the last few months.

Vitaly, any idea whats going on?

I'd be willing to email the app to anyone who is can
help fix this.  That way, you can compare this UI
regression against that of wine-20041212.  (It has a
30 day trial; so, there's no illegal stuff going on
here.)

Hiji

__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com