[PATCH 1/2] user32/combo: Add more tests for listbox size

[Fabian Maurer]

Signed-off-by: Fabian Maurer 
---
 dlls/user32/tests/combo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/user32/tests/combo.c b/dlls/user32/tests/combo.c
index 0d3b1b170f..b3f8486cd3 100644
--- a/dlls/user32/tests/combo.c
+++ b/dlls/user32/tests/combo.c
@@ -689,6 +689,8 @@ static void test_listbox_size(DWORD style)
         BOOL todo;
     } info_height[] = {
         {2, 24, FALSE},
+        {2, 30, TRUE},
+        {2, 40, TRUE},
         {2, 41, TRUE},
         {2, 42, FALSE},
         {2, 50, FALSE},
--
2.21.0

[PATCH 2/2] user32/combo: Fix listbox size when combobox is very small

[Fabian Maurer]

Signed-off-by: Fabian Maurer 
---
 dlls/user32/combo.c       | 6 ++++++
 dlls/user32/tests/combo.c | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c
index 59c2e6484c..678dd16b6b 100644
--- a/dlls/user32/combo.c
+++ b/dlls/user32/combo.c
@@ -396,6 +396,7 @@ static void CBCalcPlacement(
   }
   else
   {
+    int item_height;
     /*
      * Make sure the dropped width is as large as the combobox itself.
      */
@@ -413,6 +414,10 @@ static void CBCalcPlacement(
     }
     else
        lprLB->right = lprLB->left + lphc->droppedWidth;
+
+    item_height = (int)SendMessageW(lphc->hWndLBox, LB_GETITEMHEIGHT, 0, 0);
+    if (lprLB->bottom - lprLB->top < item_height + COMBO_YBORDERSIZE())
+      lprLB->bottom = lprLB->top + COMBO_YBORDERSIZE();
   }

/* don't allow negative window width */
@@ -1521,6 +1526,7 @@ static void COMBO_Size( LPHEADCOMBO lphc )
             curComboHeight, newComboHeight, lphc->droppedRect.bottom,
             lphc->droppedRect.top);
       lphc->droppedRect.bottom = lphc->droppedRect.top + curComboHeight - newComboHeight;
+
     }
     /*
      * Restore original height
diff --git a/dlls/user32/tests/combo.c b/dlls/user32/tests/combo.c
index b3f8486cd3..510be670e8 100644
--- a/dlls/user32/tests/combo.c
+++ b/dlls/user32/tests/combo.c
@@ -689,8 +689,8 @@ static void test_listbox_size(DWORD style)
         BOOL todo;
     } info_height[] = {
         {2, 24, FALSE},
-        {2, 30, TRUE},
-        {2, 40, TRUE},
+        {2, 30, FALSE},
+        {2, 40, FALSE},
         {2, 41, TRUE},
         {2, 42, FALSE},
         {2, 50, FALSE},
--
2.21.0

[PATCH 2/2] user32/combo: Fix listbox size when combobox is very small

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=48543

Your paranoid android.

=== debian9 (32 bit Japanese:Japan report) ===

user32:
combo.c:767: Test succeeded inside todo block: Test 3, expected list height to be 0, got 0
combo.c:767: Test succeeded inside todo block: Test 12, expected list height to be 0, got 0
combo.c:767: Test succeeded inside todo block: Test 17, expected list height to be 54, got 54

=== debian9 (32 bit Chinese:China report) ===

user32:
msg.c:14491: Test failed: bad time b5e4e9f

[PATCH 2/2] user32/combo: Fix listbox size when combobox is very small

[Fabian Maurer]

Those issues are most likely the off-by-one error I'm currently working on,
but they already exist and those failures are not relevant to this patch. I hope to fix them
with the next patchset after this one.

Regards,
Fabian Maurer
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=48543
>
> Your paranoid android.
>
> === debian9 (32 bit Japanese:Japan report) ===
>
> user32:
> combo.c:767: Test succeeded inside todo block: Test 3, expected list height
> to be 0, got 0 combo.c:767: Test succeeded inside todo block: Test 12,
> expected list height to be 0, got 0 combo.c:767: Test succeeded inside todo
> block: Test 17, expected list height to be 54, got 54
>
> === debian9 (32 bit Chinese:China report) ===
>
> user32:
> msg.c:14491: Test failed: bad time b5e4e9f

[PATCH 2/2] user32/combo: Fix listbox size when combobox is very small

[Fabian Maurer]

Hello wine-devel,

still unsure if the patches are fine like this or if I should add some
workaround to make the tests work until I can fix them with the
next patches for this series. Feedback?

Regards,
Fabian Maurer

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=48542

Your paranoid android.

=== debian9 (32 bit Japanese:Japan report) ===

user32:
combo.c:767: Test failed: Test 4, expected list height to be 0, got 15
combo.c:767: Test failed: Test 13, expected list height to be 0, got 15
combo.c:767: Test succeeded inside todo block: Test 17, expected list height to be 54, got 54