August 2022 - wine-gitlab

Re: [PATCH v2 0/1] MR727: evr/filter: Implement pin's connect/disconnect.
by Nikolay Sivov (＠nsivov) 31 Aug '22

31 Aug '22

On Tue Aug 30 17:26:10 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 8/30/22 06:24, Nikolay Sivov wrote: > > +static HRESULT evr_connect(struct strmbase_renderer *iface, const > AM_MEDIA_TYPE *mt) > > +{ > > + struct evr *filter = impl_from_strmbase_renderer(iface); > > + IMFMediaType *media_type; > > + HRESULT hr; > > + > > + if (SUCCEEDED(hr = evr_test_input_type(filter, mt, &media_type))) > It's perhaps worth noting that strmbase IPin::ReceiveConnection() [which > calls this function] already calls query_accept(). Granted, > evr_test_input_type() is also doing some other initialization, but > arguably it could be named more appropriately in that case. > ``` Yes, I'll have to review this again. One thing is that query_accept() currently does init-test-release, and does not check if we are already initialized, e.g. in connect(). I'll have to try to see how it works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/727#note_7283

1 0

[PATCH v4 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- v4: tests: Make sure only one thread prints traces at a time. https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 1

[PATCH v2 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- v2: tests: Make sure only one thread prints traces at a time. https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 1

[PATCH 0/4] MR733: Assorted spelling fixes.
by Francois Gouget (＠fgouget) 30 Aug '22

30 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/733

5 7

[PATCH 0/1] MR723: winepulse.drv: Check state after connect
by Alistair Leslie-Hughes (＠alesliehughes) 30 Aug '22

30 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/723

4 5

Re: [PATCH v2 0/4] MR733: Assorted spelling fixes. - approved
by Alexandre Julliard (＠julliard) 30 Aug '22

30 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/733

1 0

Re: [PATCH v2 0/6] MR685: wmvcore/tests: Add tests for output settings, pts ordering and threading support. - approved
by Alexandre Julliard (＠julliard) 30 Aug '22

30 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/685

1 0

Re: [PATCH v2 0/2] MR732: d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - approved
by Alexandre Julliard (＠julliard) 30 Aug '22

30 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/732

1 0

Re: [PATCH v2 0/1] MR727: evr/filter: Implement pin's connect/disconnect. - approved
by Alexandre Julliard (＠julliard) 30 Aug '22

30 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/727

1 0

Re: [PATCH v6 0/6] MR720: winemac: Allow enumeration of non-primary display modes. - approved
by Alexandre Julliard (＠julliard) 30 Aug '22

30 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/720

1 0

2025

2024

2023

2022

wine-gitlab August 2022