On Tue Aug 30 13:26:41 2022 +0000, Matteo Bruni wrote:
> I wonder if this should happen for all the mip level 0 elements of an
> array / cube texture (i.e. condition should just be !j instead).
We're creating the img_info structure only once (in D3DX10GetImageInfoFromMemory call) so there's no need to do it multiple times. Probably it should be moved outside of the loop to make it easier to read.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/641#note_7229
In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS.
--
v4: winemac.drv: Support enumerating non-primary adapters display modes.
winemac.drv: Support getting non-primary adapter current display mode.
winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx.
winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration.
winemac.drv: Invalidate mode cache when enum flags changes.
winemac.drv: Rename display modes cache variables.
https://gitlab.winehq.org/wine/wine/-/merge_requests/720
Fixes a bug that occurs when:
- `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 1
- `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 2
- `CoUninitialize()` is called on thread 1.
- `CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);` is called on thread 1.
After this, when attempting to marshal an interface on thread 2, when `ipid_to_ifstub` is called, `apartment_findfromtid()` will find thread 1's STA and not the MTA.
--
v2: combase: Omit thread ID from the stub manager ipid for MTA objects.
https://gitlab.winehq.org/wine/wine/-/merge_requests/705
--
v4: mf: Actually implement SESSION_CMD_END internal command.
mf: Use session_submit_command to put SESSION_CMD_END ahead of the queue.
mf: Keep pending session command out of the queued commands list.
mf: Use a dedicated session callback interface for sample requests.
https://gitlab.winehq.org/wine/wine/-/merge_requests/607
In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS.
--
v3: winemac.drv: Support enumerating non-primary adapters display modes.
winemac.drv: Support getting non-primary adapter current display mode.
winemac.drv: Invalidate mode cache when enum flags changes.
winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration.
winemac.drv: Rename display modes cache variables.
https://gitlab.winehq.org/wine/wine/-/merge_requests/720
The previous version of the code incorrectly assumed that the lpszClass
member of CREATESTRUCT passed with WM_CREATE would point to the same
memory used for the CreateWindowEx class name parameter, and used a
pointer comparison to check for class name equality.
As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8
"win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the
CREATESTRUCT lpszClass member started pointing to different memory,
breaking the current implementation of MCIWND_Create().
This commit fixes the problem by performing a proper, case-insensitive
string comparison to determine class name equality.
Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578
--
v2: msvfw32: Use string comparison to determine class name equality.
https://gitlab.winehq.org/wine/wine/-/merge_requests/726