August 2022 - wine-gitlab

[PATCH 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) 30 Aug '22

30 Aug '22

The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWndCreate(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/726

2 1

[PATCH v11 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 30 Aug '22

30 Aug '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v11: comdlg32: Add missing controls to the common item dialog, only affecting the implementation comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4

Re: [PATCH v8 0/9] MR6: Avoid performance degradation due to vDSO unmapping (BZ#52313)
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 30 Aug '22

30 Aug '22

Any update on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6#note_7189

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 30 Aug '22

30 Aug '22

On Mon Aug 29 20:13:37 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 8/29/22 09:39, Nikolay Sivov wrote: > > @@ -296,6 +299,15 @@ static void test_interfaces(void) > > check_interface(filter, &IID_IReferenceClock, FALSE); > > check_interface(filter, &IID_IVideoWindow, FALSE); > > > > + /* The scope of IMediaEventSink */ > > + hr = IBaseFilter_QueryInterface(filter, &IID_IMediaEventSink, > (void **)&unk); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter2); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + ok(filter == filter2, "Unexpected pointer.\n"); > > + IBaseFilter_Release(filter2); > > + IUnknown_Release(unk); > > + > > ref = IBaseFilter_Release(filter); > > ok(!ref, "Got unexpected refcount %ld.\n", ref); > > } > Somewhat out of curiosity, why this test? > ``` It's done differently in mf/evr.c where this interface is not exposed, except during InitServices(). The test was to show that it's done in a usual way in this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725#note_7188

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept(). - approved
by Alexandre Julliard (＠julliard) 29 Aug '22

29 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725

1 0

Re: [PATCH v7 0/5] MR708: windows.media.speech: Fix test breakage and misc changes. - approved
by Alexandre Julliard (＠julliard) 29 Aug '22

29 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/708

1 0

[PATCH v2 0/4] MR710: Fixes for volume size information retrieval
by jhol (＠jhol) 29 Aug '22

29 Aug '22

-- v2: mountmgr.sys: Implemented FileFsSizeInformation and FileFsFullSizeInformation volume queries ntdll: Implemented NtQueryVolumeInformationFile FileFsFullSizeInformation kernel32/tests: Added tests for GetDiskFreeSpaceA/W with volume GUID paths kernel32/tests: GetDiskFreeSpaceA/W test targetted at a real drive https://gitlab.winehq.org/wine/wine/-/merge_requests/710

3 6

[PATCH v2 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 29 Aug '22

29 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: evr/filter: Implement media type testing for QueryAccept(). evr/filter: Add IMFTopologyServiceLookup stub. evr/filter: Add IMediaEventSink stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/725

4 5

[PATCH v3 0/7] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) 29 Aug '22

29 Aug '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v3: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Add DeviceWatcher class. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Add IDeviceInformationStatics2 interface. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 17

[PATCH 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 29 Aug '22

29 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725

3 5

2025

2024

2023

2022

wine-gitlab August 2022