January 2023 - wine-gitlab

[PATCH 0/5] MR2038: server: Track cursor handle and window changes.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

The idea here is to track the cursor changes on the server side, ultimately [1] using a private message to notify user drivers of changes to apply, instead of tracking the changes in user drivers with throttle mechanisms. This would greatly simplify winex11 mouse message handling as we would not need to try syncing the window cursor on every mouse move, and ultimately it would also make it possible to have a single thread listening to input in the background. Currently the input thread needs to own the windows that are under the cursor to be able to set it. Having a single input thread (per-process at least, but ideally and ultimately per-prefix), will solve several issues with input not being received when the foreground thread isn't actively checking their message, as well as issues with DInput incorrectly checking window messages when it should not. [1] See https://gitlab.winehq.org/rbernon/wine/-/merge_requests/8/commits -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2038

3 9

[PATCH 0/1] MR1240: gitlab: Run related tests on every commit.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This restores the feature we had with the testbot running related on intermediate commits, though it only does it on Linux and it would be nice to have it on Windows too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1240

2 2

[PATCH 0/5] MR2062: winex11: Expose supported and configured keyboard layout in winecfg.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This adds a new Input tab to winecfg, moving the mouse grab settings there. Then this makes winex11 keyboard layout detection configurable as well, allowing the user to override the keyboard layout detection if for some reason it was incorrect. This isn't solving anything yet, but I then intend to make keyboard scancode detection configurable as well, and optional. As I described in https://www.winehq.org/pipermail/wine-devel/2020-October/175641.html, I believe that X11 keyboard keycode to scancode mapping is most of the time a fixed mapping, except in some rare cases. Trying to detect it from the keyboard layout will never work reliably, especially nowadays where keyboard layouts are completely made up from Linux IME (for instance a GNOME language settings with up to four keyboard layouts translates to a single Xkb mapping using groups for each layout). The X11 keycode are remapped only in some more rarely used implementations, such as XVNC and we should try to detect it only in such cases. Many Windows applications are depending on accurate scancodes, and making the mapping detection optional (and disabled by default) will solve all the issues we have in the most common case (https://bugs.winehq.org/show_bug.cgi?id=30984, https://bugs.winehq.org/show_bug.cgi?id=45605). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2062

2 7

[PATCH v2 0/1] MR2067: wine32u: fix off-by-one bugs in MsgWaitForMultipleObjectsEx drivers
by Ivan Chikish (＠nekotekina) 23 Feb '23

23 Feb '23

When count = 0, returned value may become -1 which seems wrong in the case of successful process_events() call. Also MSDN suggests that `count` may be a valid return value in this case. When -1 is returned, it may cause SetLastError to -1 as well which is not a valid error code AFAIK. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 -- v2: wine32u: move count fixup out of MsgWaitForMultipleObjectsEx drivers https://gitlab.winehq.org/wine/wine/-/merge_requests/2067

4 5

[PATCH v4 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 23 Feb '23

23 Feb '23

-- v4: wined3d: Disable 64-bit integer support. wined3d: Require shader cull distance support to create a feature level 10.0 device. wined3d: Require shader clip distance support to create a feature level 10.0 device. wined3d: Require gather offset support to create a feature level 11.0 device. wined3d: Require fragment shader image stores and atomics to create a feature level 11.0 device. https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

3 6

[PATCH v8 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 22 Feb '23

22 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v8: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 13

[PATCH 0/1] MR533: xactengine3_7/tests: Test wave bank pointer also when creating one.
by Giovanni Mascellani (＠giomasce) 20 Feb '23

20 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/533

3 3

[PATCH v10 0/1] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Feb '23

11 Feb '23

a hotfix for the recent release of Persona 5 Royal. -- v10: kernel32: Implement various transacted file APIs https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

4 3

[PATCH 0/1] MR997: win32u: fix Arabic-English mix texts missed chars
by Mosaab Alzoubi (＠moceap) 11 Feb '23

11 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/997

4 5

[PATCH 0/1] MR1974: rpcrt4/tests: Remove a failing test.
by Huw Davies (＠huw) 08 Feb '23

08 Feb '23

A follow-up to !1807. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1974

4 3

2025

2024

2023

2022

wine-gitlab January 2023