October 2023 - wine-gitlab

[PATCH 0/1] MR1185: Update .metrics-dashboard.yml, Dockerfile
by waynus (＠waynus) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1185

3 2

[PATCH 0/1] MR3928: msxml3: Add GB2312 support for builtin character converter.
by Jactry Zeng (＠jactry) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3928

5 6

[PATCH v4 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 06 Dec '23

06 Dec '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- v4: vbscript: Coerce to VT_BOOL when evaluating jump conditions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

2 3

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) 04 Dec '23

04 Dec '23

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH v3 0/3] MR1152: ntdll: Fixes for Overwatch 2.
by Torge Matthies (＠tmatthies) 01 Dec '23

01 Dec '23

Overwatch 2 doesn't like the win32u `-syscall` conversion that happened a while back, because it hooks KiUserCallbackDispatcher. This MR fixes it up to match what Overwatch 2 expects. -- v3: ntdll: Pass KiUserCallbackDispatcher parameters on stack. ntdll: Add 5-byte nop to start of KiUserCallbackDispatcher. ntdll: Align stack pointer when calling KiUserCallbackDispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1152

4 8

[PATCH v27 0/3] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 30 Nov '23

30 Nov '23

This comes from behavioral study of Windows, which doesn't seem to check if the lock is actually exclusively held, and just simply decrement the value stored in the lock. This fixes a dead lock which prevents WeCom from starting up. -- v27: ntdll: allow SRWLOCKs to be quickly re-acquired ntdll: An implementation of SRWLOCK that closer matches Windows'. https://gitlab.winehq.org/wine/wine/-/merge_requests/3504

4 12

[PATCH 0/1] MR3295: ntdll: Handle calling convention mismatch.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

That's obviously kinda hacky. Alternatively, we could have a proper wrapper for the entry point. Didn't consider the i386 case as the thread entry point never returns. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55014 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3295

4 5

[PATCH v12 0/10] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 24 Nov '23

24 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v12: scrrun: Return path not found error if no folders were moved in MoveFolder(). scrrun: return path not found error if source ends with path separator in MoveFolder(). scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder(). scrrun: Check for non-existant source in MoveFolder(). scrrun: Test MoveFolder with already existing destination. scrrun: Check for null and empty arguments in MoveFolder. scrrun: Implement MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 14

[PATCH 0/1] MR4035: use bison -d for both header and c files
by Marcus Meissner (＠msmeissn) 24 Nov '23

24 Nov '23

Otherwise the first rule wins and bison / bison -d output differs and causes reproducibility issues as during parallel either .h or .c rule could be called first. Reported-By: Bernhard Wiedemann <bwiedemann(a)suse.de> Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4035

3 3

[PATCH 0/4] MR4051: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4051

2 5

2025

2024

2023

2022

wine-gitlab October 2023