October 2023 - wine-gitlab

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) 04 Dec '23

04 Dec '23

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH v3 0/3] MR1152: ntdll: Fixes for Overwatch 2.
by Torge Matthies (＠tmatthies) 01 Dec '23

01 Dec '23

Overwatch 2 doesn't like the win32u `-syscall` conversion that happened a while back, because it hooks KiUserCallbackDispatcher. This MR fixes it up to match what Overwatch 2 expects. -- v3: ntdll: Pass KiUserCallbackDispatcher parameters on stack. ntdll: Add 5-byte nop to start of KiUserCallbackDispatcher. ntdll: Align stack pointer when calling KiUserCallbackDispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1152

4 8

[PATCH v27 0/3] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 30 Nov '23

30 Nov '23

This comes from behavioral study of Windows, which doesn't seem to check if the lock is actually exclusively held, and just simply decrement the value stored in the lock. This fixes a dead lock which prevents WeCom from starting up. -- v27: ntdll: allow SRWLOCKs to be quickly re-acquired ntdll: An implementation of SRWLOCK that closer matches Windows'. https://gitlab.winehq.org/wine/wine/-/merge_requests/3504

4 12

[PATCH 0/1] MR3295: ntdll: Handle calling convention mismatch.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

That's obviously kinda hacky. Alternatively, we could have a proper wrapper for the entry point. Didn't consider the i386 case as the thread entry point never returns. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55014 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3295

4 5

[PATCH v12 0/10] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 24 Nov '23

24 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v12: scrrun: Return path not found error if no folders were moved in MoveFolder(). scrrun: return path not found error if source ends with path separator in MoveFolder(). scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder(). scrrun: Check for non-existant source in MoveFolder(). scrrun: Test MoveFolder with already existing destination. scrrun: Check for null and empty arguments in MoveFolder. scrrun: Implement MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 14

[PATCH 0/1] MR4035: use bison -d for both header and c files
by Marcus Meissner (＠msmeissn) 24 Nov '23

24 Nov '23

Otherwise the first rule wins and bison / bison -d output differs and causes reproducibility issues as during parallel either .h or .c rule could be called first. Reported-By: Bernhard Wiedemann <bwiedemann(a)suse.de> Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4035

3 3

[PATCH 0/4] MR4051: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4051

2 5

[PATCH 0/1] MR4030: configure: Use -mpreferred-stack-boundary=2 on i386.
by Zebediah Figura (＠zfigura) 17 Nov '23

17 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4030

5 13

[PATCH v3 0/1] MR4096: winepulse.drv: Change device description.
by Paul Gofman (＠gofman) 16 Nov '23

16 Nov '23

Fixes a hang when joining a multiplayer game in Burnout Paradise Remastered. The game expects to find a space in the device name and spins forever trying if it can't. -- v3: winepulse.drv: Change device description. https://gitlab.winehq.org/wine/wine/-/merge_requests/4096

4 4

[PATCH v3 0/4] MR418: tests/shader-runner: finer control over model ranges and [shader] directive execution for backends, part 1.
by Francisco Casas (＠fcasas) 14 Nov '23

14 Nov '23

First part of a series that allows the shader-runner to test SM1 compilation on [shader] directives even if a backend to run these tests is not available and prepare they way for SM1-only tests. Specifically: - Compile [shader] directives separately from backend execution (on part 1). - Allow specifying more detailed shader ranges for todo(), fail() and notimpl() qualifiers (on part 2). - Always test shader compilation with SM1 profiles (on part 2). The `minimum_shader_model` and `maximum_shader_model` parameters for run_shader_tests() are interpreted in the following way: > Ask the pertaining backend to run the shader_test file so that each test is executed with the lowest profile it can support within the range of shader models specified, if any. This allows us to control how many shader models we want to test for each backend, e.g.: ``` run_shader_tests(..., SHADER_MODEL_2_0, SHADER_MODEL_3_0) run_shader_tests(..., SHADER_MODEL_4_0, SHADER_MODEL_5_1) run_shader_tests(..., SHADER_MODEL_6_0, SHADER_MODEL_6_0) ``` versus ``` for (i = SHADER_MODEL_2_0, i <= SHADER_MODEL_6_0, ++i) run_shader_tests(..., i, i); ``` Also, to allow to compile [shader] directives, which are not backend-specific, separately from the [test] directives, which are, the run_shader_tests() function is modified to skip backend specific directives if the shader_runner_ops is NULL. Following patches are on my [master6i](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6i) branch. -- v3: tests/shader-runner: Compile [shader] directives separately from backend execution. tests/shader-runner: Execute runner for many shader model ranges if it supports it. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/418

6 16

2025

2024

2023

2022

wine-gitlab October 2023