October 2023 - wine-gitlab

[PATCH v3 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) 06 Nov '23

06 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v3: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

3 5

[PATCH 0/2] MR4066: win32u: Skip windows that are not activated even once in activate_other_window().
by Zhiyi Zhang (＠zhiyi) 06 Nov '23

06 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4066

3 4

[PATCH v3 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.
by Nikolay Sivov (＠nsivov) 03 Nov '23

03 Nov '23

This change only implements case-sensitivity of technique keywords and related checks when corresponding profile is used. My immediate plan is to add some synthetic type for technique variables, for example as {object, void}, then add named techniques as variables. This is useful because these names are participating in global scope, and should not collide with normal variables. After that "pass_list" will be split, at least in two variants because of how much d3d9 syntax differs. Some trivial changes will be need later to have some top level fx compilation helper that considers only fx objects and calls ps/vs/gs compiler to create inner shader blobs on same original source. -- v3: vkd3d-shader/hlsl: Improve handling of "technique" tokens. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/111

4 9

[PATCH 0/1] MR4187: mfmediaengine: Be a bit more conservative with locks in engine Shutdown.
by Yuxuan Shui (＠yshui) 03 Nov '23

03 Nov '23

During engine shutdown we acquire engine lock first, then locks of its constituents (e.g. sample grabbers); whereas normally the order is the other way around (e.g. timer callback -> acquire sample grabber lock -> OnProcessSample callback -> engine lock). This is deadlock prone. With this commit, engine lock is released before we shutdown the inner media session. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4187

3 15

[PATCH v2 0/2] MR4082: gdiplus: Implement font linking in GdipDrawString.
by Santino Mazza (＠tati1454) 03 Nov '23

03 Nov '23

-- v2: gdiplus: Implement font linking in GdipDrawString. gdiplus: Initialize COM for gdiplus. https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

5 14

[PATCH 0/1] MR4060: winegstreamer: Remove redundant null check before wcsdup in object_context_create.
by Alex Henrie (＠alexhenrie) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4060

5 6

[PATCH 0/1] MR4164: qcap: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4164

3 2

[PATCH 0/1] MR4122: quartz: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) 02 Nov '23

02 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4122

4 4

[PATCH 0/1] MR433: vkd3d-shader/dxil: Always apply the signature element start column to used_mask.
by Conor McCarthy (＠cmccarthy) 02 Nov '23

02 Nov '23

The used_mask value loaded from an additional tag/value pair is relative to the start column. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/433

4 5

[PATCH v3 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 02 Nov '23

02 Nov '23

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v3: vkd3d-shader/hlsl: Implement atan2. vkd3d-shader/hlsl: Implement atan. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

5 13

2025

2024

2023

2022

wine-gitlab October 2023