October 2023 - wine-gitlab

[PATCH v2 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) 31 Oct '23

31 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v2: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

2 2

[PATCH 0/1] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) 31 Oct '23

31 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

2 1

[PATCH v2 0/9] MR432: ir: Validate TEMP registers.
by Giovanni Mascellani (＠giomasce) 30 Oct '23

30 Oct '23

-- v2: vkd3d-shader/ir: Validate the index of a TEMP register. vkd3d-shader/ir: Validate the DCL_TEMPS instruction. vkd3d-shader/ir: Validate unused indices in a register. vkd3d-shader/ir: Validate the register index count. vkd3d-shader/ir: Validate the register dimension. vkd3d-shader/ir: Validate the register data type. vkd3d-shader/ir: Validate the register precision. vkd3d-shader/dxil: Use vsir_register_init() to initialize registers. vkd3d-shader: Deduplicate profile version comparison functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/432

3 10

[PATCH v3 0/4] MR423: vkd3d: Fix the macOS build.
by Giovanni Mascellani (＠giomasce) 30 Oct '23

30 Oct '23

A few recent changes broke the macOS build. Unfortunately nobody noticed, because the macOS CI job always fails. :-( However, we can still fix that. I'm not sure that the last commit is the best approach, would like to have comments from Henri. -- v3: ci: Make the MoltenVK logging less verbose. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/423

3 5

[PATCH 0/2] MR421: spirv: Remove some code no longer used after I/O normalization.
by Zebediah Figura (＠zfigura) 30 Oct '23

30 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/421

3 3

Re: [PATCH v2 0/1] MR4226: advapi32/tests: Fix a typo (Coverity). - approved
by Alexandre Julliard (＠julliard) 30 Oct '23

30 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4226

1 0

Re: [PATCH v2 0/1] MR4205: user32/tests: Improve timer measurement method. - approved
by Alexandre Julliard (＠julliard) 30 Oct '23

30 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4205

1 0

Re: [PATCH v5 0/4] MR4200: uiautomationcore: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 30 Oct '23

30 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4200

1 0

Re: [PATCH v2 0/1] MR4225: include: Correct ID3D10EffectPool interface uuid. - approved
by Alexandre Julliard (＠julliard) 30 Oct '23

30 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4225

1 0

Re: [PATCH v2 0/1] MR4161: localspl: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 30 Oct '23

30 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4161

1 0

2025

2024

2023

2022

wine-gitlab October 2023