October 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > { > const struct smbios_header *hdr; > - const struct smbios_baseboard *baseboard; > UINT offset; > > - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL; > + if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL; > > - baseboard = (const struct smbios_baseboard *)hdr; > - offset = (const char *)baseboard - buf + baseboard->hdr.length; > - return get_smbios_string( id, buf, offset, len ); > + if (field_offset + sizeof(BYTE) > hdr->length) return NULL; > + > + offset = (const char *)hdr - buf + hdr->length; > + return get_smbios_string_internal( ((const BYTE*)hdr)[field_offset], buf, offset, len ); > } Please add a space before the asterisk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48965

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > return hdr; > } > > -static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buflen ) > +static WCHAR *get_smbios_string_internal( BYTE id, const char *buf, UINT offset, UINT buflen ) > { get_smbios_string_by_id() is a better name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48964

1 0

[PATCH 0/1] MR4112: mf/tests: Increase buffer to prevent stack corruption
by Fabian Maurer (＠DarkShadow44) 17 Oct '23

17 Oct '23

init_dmo_media_type_video uses head + extra bytes memory, and with MEDIASUBTYPE_RGB8 the extra bytes are already 1024. This leads to stack corruption. Note that not all of those are strictly necessary to prevent a crash, but I think it's safer in case it becomes relevant in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4112

4 6

[PATCH v3 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.
by Mohamad Al-Jaf (＠maljaf) 17 Oct '23

17 Oct '23

Called by Roon. -- v3: windows.media.mediacontrol: Return success in ISystemMediaTransportControlsDisplayUpdater::Update(). windows.media.mediacontrol: Implement IMusicDisplayProperties2::get/put_AlbumTitle(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties2::get/put_AlbumTitle() tests. windows.media.mediacontrol: Add IMusicDisplayProperties2 stub interface. include: Add IMusicDisplayProperties2 interface definition. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Artist(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Artist() tests. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Title(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Title() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get_MusicProperties(). include: Add IMusicDisplayProperties interface definition. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get/put_Type(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsDisplayUpdater::get/put_Type() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControls::get_DisplayUpdater(). This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4046

2 2

Re: [PATCH v5 0/8] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

On Tue Oct 17 05:34:53 2023 +0000, Nikolay Sivov wrote: > We have a number of debugstr_an(..., 4) used for the same purpose in > different modules. It will give different output if replaced with fourcc > helper, because of isprint(), but still might be worth considering. Thanks for pointing that out. I've started to send merge requests to clean those up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994#note_48952

1 0

[PATCH 0/1] MR4121: iccvid: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4121

2 1

[PATCH 0/2] MR4115: loader: Translate wine.desktop to Catalan.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4115

2 2

[PATCH 0/2] MR4114: loader: Associate Wine with batch files.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

It is really nice to be able to double-click batch files and have them run in an interactive console window, just like on Windows. If this patch doesn't work for you, you may need a newer version of the shared-mime-info package. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4114

2 2

[PATCH v2 0/4] MR4113: ntdll: Use .seh handler in call_unwind_handler() on x64.
by Paul Gofman (＠gofman) 17 Oct '23

17 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52396 -- v2: ntdll: Use .seh handler in call_unwind_handler() on x64. ntdll/tests: Add test for collided unwind. ntdll: Use .seh handler in call_handler() on x64. ntdll: Set EH_NESTED_CALL flag in call_stack_handlers() on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/4113

2 4

[PATCH 0/4] MR4113: ntdll: Use .seh handler in call_unwind_handler() on x64.
by Paul Gofman (＠gofman) 17 Oct '23

17 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52396 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4113

2 4

2025

2024

2023

2022

wine-gitlab October 2023