October 2023 - wine-gitlab

[PATCH v24 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

This goes on top of MR 345. -- v24: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 4

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:44:29 2023 +0000, Zhiyi Zhang wrote: > It looks to me that AllowDarkModeForWindow() and SetPreferredAppMode() > set window-specific properties so that dark mode can be enabled/disabled > for individual windows. And ShouldAppsUseDarkMode() should consider > that. For the moment, returning the AppsUseLightTheme value for > ShouldAppsUseDarkMode() is probably enough. https://github.com/ysc3839/win32-darkmode/blob/master/win32-darkmode/DarkMo… also lists these undocumented functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48282

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:39:28 2023 +0000, Zhiyi Zhang wrote: > In that case, you should implement them. For ShouldAppsUseDarkMode(), > there is a recent MR at > https://gitlab.winehq.org/wine/wine/-/merge_requests/3959 that > implements ShouldSystemUseDarkMode(). I think ShouldAppsUseDarkMode() is > similar and uses the AppsUseLightTheme registry key. For > AllowDarkModeForWindow() and SetPreferredAppMode(), they can be > implemented as stubs for the moment. I also came across > https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017 > which lists their usage. It looks to me that AllowDarkModeForWindow() and SetPreferredAppMode() set window-specific properties so that dark mode can be enabled/disabled for individual windows. And ShouldAppsUseDarkMode() should consider that. For the moment, returning the AppsUseLightTheme value for ShouldAppsUseDarkMode() is probably enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48281

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:39:28 2023 +0000, Louis Lenders wrote: > Hi Zhiyi, it seems it's all more complicated then I thought. The tests > failed and it seems i put the wrong function names at those ordinals. > The thread below at Autohotkey suggests that the ordinals belong to some > undocumented functions ShouldAppsUseDarkMode, AllowDarkModeForWindow > and SetPreferredAppMode, apparently they can only be imported by ordinal. > So should I now only test that they can be imported by ordinal > (something like > proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func[i].ordinal)); > ok(proc, "getting function by ordinal failed"); )? > ) > autohotkey thread: https://www.autohotkey.com/boards/viewtopic.php?t=94661&start=20 In that case, you should implement them. For ShouldAppsUseDarkMode(), there is a recent MR at https://gitlab.winehq.org/wine/wine/-/merge_requests/3959 that implements ShouldSystemUseDarkMode(). I think ShouldAppsUseDarkMode() is similar and uses the AppsUseLightTheme registry key. For AllowDarkModeForWindow() and SetPreferredAppMode(), they can be implemented as stubs for the moment. I also came across https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017 which lists their usage. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48279

1 0

[PATCH 0/1] MR4069: winemac.drv: Use ObjC literals.
by Brendan Shanks (＠bshanks) 11 Oct '23

11 Oct '23

ObjC literals provide a simpler syntax for creating `NSNumber` objects, and creating/accessing `NSArray` and `NSDictionary`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4069

3 2

[PATCH v2 0/1] MR366: vkd3d-shader/hlsl: Add tex2Dlod() function.
by Nikolay Sivov (＠nsivov) 10 Oct '23

10 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add tex2Dlod() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/366

2 2

[PATCH 0/1] MR4070: wow64cpu: Use RTL_CONSTANT_STRING.
by Brendan Shanks (＠bshanks) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4070

2 1

[PATCH 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.
by Mohamad Al-Jaf (＠maljaf) 10 Oct '23

10 Oct '23

Called by Roon. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4046

2 6

Re: [PATCH v4 0/1] MR3766: uninstaller: Don't overallocate in FetchFromRootKey. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3766

1 0

Re: [PATCH v6 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

1 0

2025

2024

2023

2022

wine-gitlab October 2023