Find only supports one Column to filter on.
The parser for this will be the same for both Find/Filter with the only different
is the Filter supports multiple columns.
In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases).
--
v2: msado15: Implement _Recordset Find
https://gitlab.winehq.org/wine/wine/-/merge_requests/2498
--
v2: vkd3d-shader/tpf: Write out comparison mode sampler declarations and corresponding sampling instruction.
vkd3d-shader/hlsl: Parse SampleCmp() method.
vkd3d-shader/hlsl: Parse SamplerComparisonState objects.
vkd3d-shader/hlsl: Use a function table for object methods handlers.
vkd3d-shader/hlsl: Move object type checks to methods handlers.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/206
> If you mean setting `O_NONBLOCK` on `server`, that would cause `accept` to return `EWOULDBLOCK` or `EAGAIN`.
No, I mean you can set O_NONBLOCK on "client", i.e. the socket that calls connect().
> By "clean up", do you mean only calling `WaitForSingleObject` on it, or is there more that I would need to do?
Wait for it and close the handle. It should be unnecessary if you just use nonblocking i/o with the socket, though.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33265
> ~~Yes,~~ `SO_REUSEADDR` is a valid option on AF_UNIX sockets and is supported by this patch. I'll add a test for it. It looks like this is only true for abstract AF_UNIX sockets, which are expressly unsupported due to Windows' own lack of support for them.
Okay, I think I was assuming that "unbinding" meant doing the opposite of bind(), rather than "allowing other sockets to use that address". It'd be nice to have some tests for that functionality, then:
* test that trying to use the same address *without* deleting the socket fails (even if you close the socket handle? That part is very surprising to me.)
* test that trying to use the same address after deleting the socket succeeds, which currently isn't actually tested.
* Can the socket be used normally after deleting it?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33264
On Fri May 19 04:17:50 2023 +0000, Ally Sommers wrote:
> That's true, but `PATH_MAX` is 4096 on my system, while `sun_path` is a
> `char[108]`. The path returned by `wine_get_unix_file_name` can very
> easily exceed that. Thus a vararg is needed to conditionally pass the
> Unix path to wineserver if we're dealing with an AF_UNIX socket.
I still don't understand the issue. The sockaddr we pass to the server is already variable-sized. It's passed as variable-sized input data, using the "ioctl" request, with the code IOCTL_AFD_BIND. Why is sockaddr_un any different from sockaddr_in?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33263
Toolbar buttons won't adjust its size to fit the DPI setting. This two patches set a DPI-considered size to those buttons to make them look better in HiDPI.
Here are some comparisons on Wine with 192 DPI:

vs


vs

--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2849
Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c:
> stat = GdipCreateFontFamilyFromName(L"Times New Roman", NULL, nativeFamily);
>
> if (stat == FontFamilyNotFound)
> + // Liberation Serif is free replacement of Times New Roman font
`//` comments are not allowed in Wine. Also, I don't think a comment is really needed for this.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33255
Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c:
> stat = GdipCreateFontFamilyFromName(L"Liberation Mono", NULL, nativeFamily);
>
> if (stat == FontFamilyNotFound)
> - ERR("Missing 'Courier New' font\n");
> + stat = GdipGetGenericFontFamilySansSerif(nativeFamily);
Wouldn't it be better to fall back to a monospace font Wine ships with?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33254