Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c:
> stat = GdipCreateFontFamilyFromName(L"Times New Roman", NULL, nativeFamily);
>
> if (stat == FontFamilyNotFound)
> + // Liberation Serif is free replacement of Times New Roman font
`//` comments are not allowed in Wine. Also, I don't think a comment is really needed for this.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33255
Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c:
> stat = GdipCreateFontFamilyFromName(L"Liberation Mono", NULL, nativeFamily);
>
> if (stat == FontFamilyNotFound)
> - ERR("Missing 'Courier New' font\n");
> + stat = GdipGetGenericFontFamilySansSerif(nativeFamily);
Wouldn't it be better to fall back to a monospace font Wine ships with?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33254
Block records are not processed; only the bitcode is validated.
--
v9: vkd3d-shader/dxil: Read and validate global abbreviated operands.
vkd3d-shader/dxil: Read and validate local abbreviated operands.
vkd3d-compiler: Introduce dxbc-dxil and dxbc-auto source types.
vkd3d-shader/dxbc: Introduce an option to autodetect the DXBC source type.
vkd3d-shader/dxil: Read and validate DXIL bitcode unabbreviated blocks.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44
> Do real world programs expect the socket to be able to be bound to a different address afterwards?
Yes, `SO_REUSEADDR` is a valid option on AF_UNIX sockets and is supported by this patch. I'll add a test for it.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33224