Block records are not processed; only the bitcode is validated.
--
v9: vkd3d-shader/dxil: Read and validate global abbreviated operands.
vkd3d-shader/dxil: Read and validate local abbreviated operands.
vkd3d-compiler: Introduce dxbc-dxil and dxbc-auto source types.
vkd3d-shader/dxbc: Introduce an option to autodetect the DXBC source type.
vkd3d-shader/dxil: Read and validate DXIL bitcode unabbreviated blocks.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44
> Do real world programs expect the socket to be able to be bound to a different address afterwards?
Yes, `SO_REUSEADDR` is a valid option on AF_UNIX sockets and is supported by this patch. I'll add a test for it.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33224
On Thu May 18 17:53:59 2023 +0000, Zebediah Figura wrote:
> The thread should be unnecessary, you can just use nonblocking I/O. It
> doesn't make a big difference, but it's probably easier to read without
> the thread.
> If you do use the thread, you need to clean it up.
If you mean setting `O_NONBLOCK` on `server`, that would cause `accept` to return `EWOULDBLOCK` or `EAGAIN`.
By "clean up", do you mean only calling `WaitForSingleObject` on it, or is there more that I would need to do?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33223
On Thu May 18 16:46:23 2023 +0000, Zebediah Figura wrote:
> > @zfigura Can you elaborate on this? I don't see a clean way of doing
> this in ntdll without modifying `struct afd_bind_params`, `struct
> afd_connect_params`, etc. to add a field for the Unix path, since none
> of the other `sock_ioctl` cases add on varargs.
> afd_bind_params et al. should already take a variable sized sockaddr,
> and the struct definitions in include/wine/afd.h mention that
> specifically. Am I missing something?
That's true, but `PATH_MAX` is 4096 on my system, while `sun_path` is a `char[108]`. The path returned by `wine_get_unix_file_name` can very easily exceed that. Thus a vararg is needed to conditionally pass the Unix path to wineserver if we're dealing with an AF_UNIX socket.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33222