May 2023 - wine-gitlab

Re: [PATCH v2 0/4] MR2786: Add support for AF_UNIX sockets
by Loïc Rebmeister (＠Fox2Code) 14 May '23

14 May '23

"Unfortunately, last time I tried to write tests for Unix sockets, I started triggering kernel panics in Windows." It seems like a Windows specific issue! A kernel panic should never occur, even when provided with invalid data. @dropbear I think you could use the code and turn it into a test for theses patches? I think it's best to ignore Windows <-> Unix communications tests for now as I don't think `winetest` allow running tests in both Windows and Unix space at the same time, that … [View More]

1 0

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 14 May '23

14 May '23

Also how can I remove the option to compile winesni.drv on macos from the configure script? Everything I change didn't do the trick with Mac OS pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808#note_32725

1 0

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 14 May '23

14 May '23

On Sun May 14 12:03:33 2023 +0000, Loïc Rebmeister wrote: > Nevermind I saw `org.freedesktop.StatusNotifierItem` used in the rest of > the code and assumed it was already supported, but I checked commit > names and saw it was intentional. > I saw the rest of the code reference `org.freedesktop.StatusNotifierItem` > A wine standard would be to remove the > `org.freedesktop.StatusNotifierItem` from the KDE SNI Implementation > commit, and then add the references back on the … [View More]

1 0

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Loïc Rebmeister (＠Fox2Code) 14 May '23

14 May '23

On Sun May 14 11:59:45 2023 +0000, Loïc Rebmeister wrote: > `watcher_interface_name` is `org.kde.StatusNotifierItem` and this code > is only checking that. > Is this intentional that `org.freedesktop.StatusNotifierItem` is not checked? Nevermind I saw `org.freedesktop.StatusNotifierItem` used in the rest of the code and assumed it was already supported, but I checked commit names and saw it was intentional. I saw the rest of the code reference `org.freedesktop.StatusNotifierItem` A … [View More]

1 0

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Loïc Rebmeister (＠Fox2Code) 14 May '23

14 May '23

Loïc Rebmeister (@Fox2Code) commented about dlls/winesni.drv/dbus.c: > + if (!(connection = p_dbus_bus_get_private( DBUS_BUS_SESSION, &error ))) { > + WARN("failed to get system dbus connection: %s\n", error.message ); > + p_dbus_error_free( &error ); > + goto err; > + } > + > + msg = p_dbus_message_new_method_call("org.freedesktop.DBus", > + "/org/freedesktop/DBus", > + … [View More]

1 0

[PATCH 0/1] MR2814: ntdll: calling virtual_free_teb when thread exit
by Fan WenJie (＠fanwenjie) 14 May '23

14 May '23

virtual_free_teb called on thread exit can save memory. pthread_create run start_thread_wrapper on a small size stack, start_thread_wrapper calls start_thread and switch on a big size thread stack. when thread exit, switch stack pointer return to the small size stack and free memory of the thread. Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2814

3 2

[PATCH v3 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v3: explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

[PATCH v2 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v2: explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

[PATCH 0/1] MR2813: ntdll/tests: Use win_skip() for missing APIs.
by Francois Gouget (＠fgouget) 13 May '23

13 May '23

A missing API is a todo in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2813

3 2

[PATCH 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

2025

2024

2023

2022

wine-gitlab May 2023