May 2023 - wine-gitlab

[PATCH 0/3] MR2497: Modules list handling in dbghelp.
by eric pouech (＠epo) 12 May '23

12 May '23

The aim of this series is to re-implement dbghelp.EnumerateLoadedModules* in order to match Windows' behavior (especially in wow64 environments). The serie includes: - a bunch of tests to compare 3 different sets of loaded modules: + the load DLL debug events (generated by kernel) + the output of dbghelp.EnumerateLoadedModules(), which is a wrapper around kernel32.EnumProcesModulesEx (yet modifying some information) + the actual list of loaded modules in dbghelp (SymEnumerateModules). => the later list can be populated automatically from the second if requested to dbghelp (this is what is tested). => for the record, winedbg uses the first set to populate the third set. We just test the content of first set, not the population to the third. - the reimplementation of EnumerateLoadedModules to match Window's behavior (especially regarding paths information) Despite the three sets look similar, they have quite a few differences to be taken care of (especially in wow64 setup). Note: having the correct paths (esp. in wow64) is important as dbghelp sometimes tries some wild guesses based on the path (like bitness <g>) or (in some other places) don't rely on path information and retries things on its own. The long target is to simplify the module lookup by relying on more solid information. @julliard: the paths for wow64 modules returned from kernel32 don't match windows behavior: wine returns 32bit system modules from c:\windows\syswow64 whereas windows returns them from c:\windows\system32 (except a couple of exceptions: 32bit ntdll and exe main module). Implementation in dbghelp includes the correction of this. (I opted not to change ntdll at once: testing on windows show that kernel32.EnumProcesModulesEx returns exactly the ldr_data list, and I didn't feel like adding this burden to this patch ;-). Let me know if you want ntdll to be fixed before this patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2497

3 7

[PATCH v3 0/2] MR2578: Fixing module paths in LdrPath (corner case).
by eric pouech (＠epo) 12 May '23

12 May '23

The serie intent is to fix unexpected paths in module's list: This happens: - when running under old / (new) wow64 - when main module is located under the syswow64 directory - the 32 bit modules are stored in LdrData (and then exposed through a couple of ways) under syswow64 (they are normally stored under system32, letting the redirection come into play when needed) This triggers a couple of errors in winetest (as we're using c:\windows\syswow64\msinfo32.exe in many tests to trigger a wow64 process from a winetest program). This is the fix awaited in MR!2497. @julliard: I'm not 100% happy with the fix itself by reintroducting ref to the redirected DLLs in ntdll/PE but couldn't find a better idea. -- v3: ntdll,wow64: Unredirect DLLs filename before storing them into LdrData. kernel32: Harden some wow64 module tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2578

2 4

[PATCH v3 0/4] MR2792: wine{alsa,coreaudio,oss,pulse}: Move AudioClock into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 12 May '23

12 May '23

-- v3: wineoss: Use mmdevapi's AudioClock. winecoreaudio: Use mmdevapi's AudioClock. winealsa: Use mmdevapi's AudioClock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2792

3 5

Re: [PATCH v2 0/8] MR2801: winemac: Use a new type of NtUserMessageCall to move IME input processing to imm32. - approved
by Huw Davies (＠huw) 12 May '23

12 May '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2801

1 0

[PATCH v7 0/12] MR2637: winex11: Use messages instead of user callbacks and handle them in the default IME UI window procedure.
by Rémi Bernon (＠rbernon) 12 May '23

12 May '23

-- v7: winemac: Use the default IME implementation for ImeToAsciiEx. winemac: Process IME input through the driver interface. win32u: Introduce a new ImeProcessKey call through NtUserMessageCall. winemac: Send IME key input from ImeProcessKey. winemac: Wait for IME input result on the unix side. winemac: Delay ime_set_text until ImeToAsciiEx requests it. winex11: Use IMN_WINE_SET_COMP_STRING / ImeToAsciiEx instead of callbacks. win32u: Introduce a new ImeToAsciiEx call through NtUserMessageCall. winex11: Send an internal WM_IME_NOTIFY wparam on composition updates. winex11: Use ime_comp_buf != NULL instead of ximInComposeMode. winex11: Use an internal WM_IME_NOTIFY wparam to get cursor pos. winex11: Use an internal WM_IME_NOTIFY wparam to set open status. https://gitlab.winehq.org/wine/wine/-/merge_requests/2637

3 18

[PATCH 0/1] MR2802: wordpad: Resize buttons of toolbar to make them align with height of the font list combox.
by Jactry Zeng (＠jactry) 12 May '23

12 May '23

The current size set to these buttons is too small when in HiDPI. And toolbar doesn't resize buttons for HiDPI, so we will need to reset it with TB_SETBUTTONSIZE manually. On Windows with a 250% scale: ![before](/uploads/940809f0147ccc11299e216e102cf19d/before.PNG) vs ![after](/uploads/878699945699579f683d005b53ef7a1f/after.PNG) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2802

2 1

[PATCH 0/8] MR2801: winemac: Use a new type of NtUserMessageCall to move IME input processing to imm32.
by Rémi Bernon (＠rbernon) 12 May '23

12 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2801

3 10

Re: [PATCH v6 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Torge Matthies (＠tmatthies) 12 May '23

12 May '23

rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2710#note_32614

1 0

[PATCH v2 0/4] MR2792: wine{alsa,coreaudio,oss,pulse}: Move AudioClock into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 12 May '23

12 May '23

-- v2: wineoss: Use mmdevapi's AudioClock. winecoreaudio: Use mmdevapi's AudioClock. winealsa: Use mmdevapi's AudioClock. winepulse: Move AudioClock into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2792

3 7

[PATCH 0/1] MR2794: ntdll: add attribute "force_align_arg_pointer" to hanlder of signal on i386 & x86_64
by Fan WenJie (＠fanwenjie) 12 May '23

12 May '23

For example, on x86_64, value of sp on begin of callee must be 16n-8, because sp was 16n before instruction "call" on caller. But initilize value of sp on signal stack is 16n instead of 16n-8. It may cause error when store and load xmm register. add "force_align_arg_pointer" to hanlder of signal can avoid potential risks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2794

3 8

2025

2024

2023

2022

wine-gitlab May 2023