May 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR2802: wordpad: Resize buttons of toolbar to make them align with height of the font list combox. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2802

1 0

Re: [PATCH v4 0/4] MR2792: wine{alsa,coreaudio,oss,pulse}: Move AudioClock into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2792

1 0

Re: [PATCH v3 0/8] MR2801: winemac: Use a new type of NtUserMessageCall to move IME input processing to imm32. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2801

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Zebediah Figura (＠zfigura) 12 May '23

12 May '23

On Fri May 12 21:07:04 2023 +0000, Matteo Bruni wrote: > Ah, now I realize I read the "go further" in the MR description as > "work". I'd like to know that too. I kind of ask because—while I don't want to hold up progress upstream—as the person who is both maintaining the Wine-Staging patch, and working on (admittedly long stalled) actual tests for tangents, if this doesn't actually help the bug, all this patch is going to do is add more rebase headache for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32671

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

On Fri May 12 21:07:04 2023 +0000, Zebediah Figura wrote: > Does this actually make the program work? Ah, now I realize I read the "go further" in the MR description as "work". I'd like to know that too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32670

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Zebediah Figura (＠zfigura) 12 May '23

12 May '23

Does this actually make the program work? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32669

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/mesh.c: > return hr; > } > > +/************************************************************************* > + * D3DXComputeTangent (D3DX9_36.@) > + */ Your choice, but I would just get rid of this comment header. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32668

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/mesh.c: > return hr; > } > > +/************************************************************************* > + * D3DXComputeTangent (D3DX9_36.@) > + */ > +HRESULT WINAPI D3DXComputeTangent(ID3DXMesh *mesh, const DWORD stage_idx, DWORD tangent_idx, > + DWORD binorm_idx, DWORD wrap, const DWORD *adjacency) > +{ > + FIXME("mesh %p, stage_idx %lu, tangent_idx %lu, binorm_idx %lu, wrap %lu, adjacency %p.\n", We usually end FIXME messages for stubs with "stub!\n". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32667

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/mesh.c: > return hr; > } > > +/************************************************************************* > + * D3DXComputeTangent (D3DX9_36.@) > + */ > +HRESULT WINAPI D3DXComputeTangent(ID3DXMesh *mesh, const DWORD stage_idx, DWORD tangent_idx, That "const" shouldn't be there. I guess it doesn't matter in practice but it does look quite weird. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32666

1 0

[PATCH 0/5] MR2805: winemac: High-res/retina mode fixes
by Brendan Shanks (＠bshanks) 12 May '23

12 May '23

This fixes two issues: - since WineContentView became layer-backed in Wine 6.17, windows do not display correctly on a non-retina monitor when high-res/retina mode is enabled. (The needed downscaling was not being done). - additionally on macOS 10.13 and earlier, the desired minification/downscaling filter was being ignored, causing poor image quality. Enabling rasterization for the layer seems to work around this and uses the correct filter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2805

2 5

2025

2024

2023

2022

wine-gitlab May 2023