May 2023 - wine-gitlab

[PATCH v4 0/4] MR1710: mf: Discard end of presentation on IMFMediaSession_Stop.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

MR !607 was trying to fix an issue with Life Is Strange Remastered, but although it fixed some race conditions with presentation end, the issue it was trying to fix is still there. The game calls IMFMediaSession_Stop while the presentation is ending, expects that command to quickly execute, interrupting the presentation end and emitting a MESessionStopped event instead of the MESessionEnded. Delaying the Stop command and emitting the MESessionEnded event breaks the game assumptions and it crashes. -- v4: mf: Discard end of presentation on IMFMediaSession_Stop. mf/tests: Test IMFMediaSession_Stop command near presentation end. mf/tests: Test Start / Pause / Stop IMFMEdiaSession events. mf/tests: Split wait_media_event helper into wait_next_media_event. https://gitlab.winehq.org/wine/wine/-/merge_requests/1710

3 10

[PATCH v2 0/5] MR2782: mf/tests: Test byte stream handler resolution time and media source presentation descriptor.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

This tests that the resolution should be quick enough to not trigger an Unreal Engine race condition. This also checks the determinism of the media source presentation descriptor stream ordering, as well as the stream selection updates when the media source is started. -- v2: mf/tests: Test media source presentation stream descriptor update. winegstreamer: Keep a reference on the media source start descriptor. mf/tests: Test media sources stream descriptors attributes. mf/tests: Test media sources with multiple audio/video streams. mf/tests: Test byte stream handler to media source resolution time. https://gitlab.winehq.org/wine/wine/-/merge_requests/2782

3 12

[PATCH v2 0/1] MR2348: comdlg32: Add parent dir button to "Item" file dialog.
by Florian Will (＠w-flo) 17 Jun '23

17 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29912 Now it looks like this (this patch adds the separator & "up" button): ![Bildschirmfoto_vom_2023-03-08_13-34-36](/uploads/cd30de5b3fa5f39accb4dd14a3f54421/Bildschirmfoto_vom_2023-03-08_13-34-36.png) -- v2: comdlg32: Add parent dir button to "Item" file dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2348

2 5

[PATCH v3 0/2] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 13 Jun '23

13 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- v3: winecfg: Mention protocol associations. winemenubuilder: Create .desktop files for programs that open URIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

4 11

[PATCH 0/1] MR2887: winegstreamer: Make sure threads are not waiting for event_cond object.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

First we set the EOS state, so the wait_parser_stream_buffer function doesn't call pthread_cond_wait again. Then we must call pthread_cond_signal to make sure that no one is waiting for it, if we don't do that, there is the possibility of hanging wg_parser_disconnect at the free_stream call, because pthread_cond_destroy will hang when the cond object is being waited by other threads. Specifically this helps to fix a hang in some applications, specially Unreal Engine games when changing sources too fast in a MediaPlayer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2887

3 6

[PATCH v5 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v5: gitlab: Run user32 32-bit tests with nulldrv driver. user32/tests: Update todos specific to the X11 display driver. user32/tests: Check graphics driver and add todos for nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

2 5

[PATCH 0/3] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 07 Jun '23

07 Jun '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 12

[PATCH v13 0/12] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 06 Jun '23

06 Jun '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v13: comdlg32: Add Ctrl+Backspace delete word to IFileDialog address edit. comdlg32: Use path word break in IFileDialog address edit. comctl32: Fix PathWordBreakProc. comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace. fixup: comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

6 22

[PATCH v2 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) 06 Jun '23

06 Jun '23

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v2: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. vkd3d-shader/hlsl: Handle resource components individually for SM 5.0. vkd3d-shader/tpf: Introduce struct extern_resource. vkd3d-shader/hlsl: Allow derefs to provide the data_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

6 37

[PATCH v3 0/1] MR2773: include: Add xamlom.idl file.
by Biswapriyo Nath (＠Biswa96) 06 Jun '23

06 Jun '23

-- v3: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2773

3 8

2025

2024

2023

2022

wine-gitlab May 2023