May 2023 - wine-gitlab

[PATCH v2 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) 08 Jul '23

08 Jul '23

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v2: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. kernelbase: Implement URL_UNESCAPE_AS_UTF8 for UrlUnescapeW(). shlwapi/tests: Test UrlUnescapeW() with independent data. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

4 6

[PATCH 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) 04 Jul '23

04 Jul '23

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

4 11

[PATCH v2 0/4] MR2822: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) 29 Jun '23

29 Jun '23

-- v2: wined3d: Remove no longer used arguments from wined3d_texture_update_desc(). wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers(). wined3d: Factor out a swapchain_create_texture() helper. dxgi: Do not create a d3d11 swapchain object for the implicit swapchain. https://gitlab.winehq.org/wine/wine/-/merge_requests/2822

3 5

[PATCH v15 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) 26 Jun '23

26 Jun '23

Block records are not processed; only the bitcode is validated. -- v15: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce a dxbc-dxil source type. include: Introduce a function to detect the DXBC source type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 6

[PATCH v3 0/3] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) 23 Jun '23

23 Jun '23

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- v3: vkd3d-shader: Synthesize signatures for d3dbc shaders. vkd3d-shader: Introduce an API to retrieve all signatures from DXBC shaders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

4 20

[PATCH 0/1] MR1045: include: Add wine/winrt.h and define IInspectable helpers there.
by Paul Gofman (＠gofman) 23 Jun '23

23 Jun '23

And use that instead of duplicating those helpers across the tree. Besides removing existing duplicates, I am planning to add yet another WinRT dll (gamepad) and we will likely add more in the future, each of those can use that, as well as potentially more common helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1045

5 6

[PATCH 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 21 Jun '23

21 Jun '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

4 7

[PATCH 0/1] MR1305: ntdll: The maximum length for a path is MAX_PATH.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

see "https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-li…". Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1305

3 3

[PATCH 0/1] MR1306: win32u: When the window is not visible but has WS_VISIBLE flag, we should update the vis rgn.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

When the child window and the parent window are no longer in the same process, the parent window shadow does not update the vis rgn of the child window and modify the WS_VISIBLE style of the child window. so we need to update the vis rgn when another process gets the DC of the child window. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1306

2 2

[PATCH 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '23

20 Jun '23

Reference https://bugs.winehq.org/show_bug.cgi?id=54985 From the line we see the mingw version used causes an In file included from /usr/share/mingw-w64/include/unknwnbase.h:47, [ 935s] from /usr/share/mingw-w64/include/objidlbase.h:439, [ 935s] from include/combaseapi.h:29, [ 935s] from include/objbase.h:267, [ 935s] from include/ole2.h:25, [ 935s] from /usr/share/mingw-w64/include/wtypes.h:13, [ 935s] from include/winscard.h:22, [ 935s] from include/windows.h:68, [ 935s] from libs/vkd3d/include/private/vkd3d_common.h:23, [ 935s] from libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:49, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.y:24, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.l:23: [ 935s] /usr/share/mingw-w64/include/wtypesbase.h:148:16: error: redefinition of 'struct _SECURITY_ATTRIBUTES' [ 935s] 148 | typedef struct _SECURITY_ATTRIBUTES { The included file winscard.h seemed a little odd. The vkd3d isn't going to use this. Adding the define WIN32_LEAN_AND_MEAN to the Makefile.in (in wine), produce the following warnings. /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:75:5: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration] 75 | abort(); | ^~~~~ /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:258:14: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 258 | *major = atoi(version); Adding header <stdlib.h> removed all the warnings. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

5 7

2025

2024

2023

2022

wine-gitlab May 2023