June 2023 - wine-gitlab

[PATCH v5 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v5: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

4 8

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

On Thu Jun 8 10:01:18 2023 +0000, Santino Mazza wrote: > In this API the callbacks are the `Tx` functions from `ITextHost`, right? Yes. See the existing tests in `dlls/riched20/tests/txtsrv.c`. We don't currently do much testing on which `ITextHost` members get called, but at least there's already an implementation there to get you started. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35115

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 09:55:30 2023 +0000, Huw Davies wrote: > > I couldn't debug it too much, because the crash happens only in the > ITextHost implementation from a microsoft forms dll. > Ah, so it may be related to which host callbacks get called. I think > we're going to need some tests that look at that. In this API the callbacks are the `Tx` functions from `ITextHost`, right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35114

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

> I couldn't debug it too much, because the crash happens only in the ITextHost implementation from a microsoft forms dll. Ah, so it may be related to which host callbacks get called. I think we're going to need some tests that look at that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35113

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 09:52:58 2023 +0000, Huw Davies wrote: > That'll mean that the host's `TxViewChange` method would get called - > we'd need a test to see if that's the case. It still seems like we're > hiding the problem. What crash did you see when using `ME_WrapMarkedParagraphs()`? I couldn't debug it too much, because the crash happens only in the ITextHost implementation from a microsoft forms dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35112

1 0

[PATCH 0/1] MR3019: msi: Release record instead of free.
by Daniel Lehman (＠dlehman25) 08 Jun '23

08 Jun '23

../dlls/msi/dialog.c:4476:11: warning: attempt to call free on non-heap object 'hdr' [-Wfree-nonheap-object] free( &rec->hdr ); ^ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3019

3 2

[PATCH 0/1] MR3018: msi: Fix memory leak on error path in MSI_ProcessMessage (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3018

3 2

[PATCH 0/1] MR3015: winhttp: Fix double free on error path in queue_task (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

queue_task cannot free the struct because it doesn't know whether the struct contains pointers to other dynamically allocated memory that also needs to be freed (as is the case with struct send_request). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3015

3 2

[PATCH 0/1] MR3013: wusa: Fix memory leak on error path in read_components (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

If read_identity returns FALSE, it has already called clear_identity. This is the same problem as in merge request !2970. Unfortunately I did not notice at first that the problem was present in two places. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

3 2

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

That'll mean that the host's `TxViewChange` method would get called - we'd need a test to see if that's the case. It still seems like we're hiding the problem. What crash did you see when using `ME_WrapMarkedParagraphs()`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35104

1 0

2025

2024

2023

2022

wine-gitlab June 2023