June 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR226: vkd3d-shader/hlsl: Fold redudant casts again after lower narrowing casts. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/226

1 0

Re: [PATCH v4 0/7] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

1 0

[PATCH v7 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v7: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

2 1

[PATCH 0/1] MR2887: winegstreamer: Make sure threads are not waiting for event_cond object.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

First we set the EOS state, so the wait_parser_stream_buffer function doesn't call pthread_cond_wait again. Then we must call pthread_cond_signal to make sure that no one is waiting for it, if we don't do that, there is the possibility of hanging wg_parser_disconnect at the free_stream call, because pthread_cond_destroy will hang when the cond object is being waited by other threads. Specifically this helps to fix a hang in some applications, specially Unreal Engine games when changing sources too fast in a MediaPlayer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2887

3 6

[PATCH v6 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v6: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

2 1

[PATCH v3 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v3: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

2 5

[PATCH v7 0/5] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v7: vkd3d-shader/hlsl: Handle 'texkill' jump type. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader: Make some helpers available from hlsl.c. vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

2 6

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 10:13:38 2023 +0000, Huw Davies wrote: > Yes. See the existing tests in `dlls/riched20/tests/txtsrv.c`. We > don't currently do much testing on which `ITextHost` members get called, > but at least there's already an implementation there to get you started. From what I see when reading the trace calls with `WINETEST_DEBUG` set, windows calls two times TxViewChange, I suppose the first time it's called by the SetText call, and then the second one is called by EM_SETSEL, in wine we don't call it. There are also other functions from the TextHost that get called and we don't do it in wine, so I'm going to write tests for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35179

1 0

[PATCH v2 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v2: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

4 13

[PATCH v3 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 08 Jun '23

08 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. - Modified format strings. -- v3: ntdll: Avoid requests with null pointer but invalid size. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 3

2025

2024

2023

2022

wine-gitlab June 2023