July 2023 - wine-gitlab

[PATCH 0/7] MR3262: dxgi: Introduce a worker thread for each D3D12 swapchain (second part).
by Giovanni Mascellani (＠giomasce) 13 Jul '23

13 Jul '23

This MR completes https://gitlab.winehq.org/wine/wine/-/merge_requests/3165. The architecture was changed slightly from what is explained there after some discussion: instead of adding special support for `vkQueueSubmit()` and `vkQueuePresentKHR()`, vkd3d is not changed. Instead, the behavior of `vkd3d_acquire_vk_queue()` is specified, with a recommendation on how to ensure that frames are presented in order (see https://gitlab.winehq.org/wine/vkd3d/-/commit/b2a1f6b5e4f59fbc7f91ada7e5656…). The recommended behavior is implemented in this MR, and it is known to fix presentation bugs on The Medium. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3262

4 11

[PATCH v5 0/1] MR3269: wininet: Handle http headers correctly when length is 0
by Hans Lehnert (＠hanslehnert) 13 Jul '23

13 Jul '23

In HttpSendRequestW and HttpSendRequestExW, if the header pointer is not null but the length parameter is 0, the header length should be derived from the string length instead. In HttpSendRequestA and HttpSendRequestExA, on the same scenario, the function should fail instead. -- v5: wininet: Handle http headers correctly when length is 0 https://gitlab.winehq.org/wine/wine/-/merge_requests/3269

3 3

[PATCH v3 0/2] MR3198: combase: Pass the correct destination context when unmarshaling using the standard marshaler.
by Connor McAdams (＠cmcadams) 13 Jul '23

13 Jul '23

This fixes an issue I ran into in UI Automation using an interface proxy marshaled with `MSHCTX_INPROC`. `CoUnmarshalInterface` always passes `MSHCTX_LOCAL` when using the standard marshaler, regardless of what was passed to `CoMarshalInterface`. When passing an interface that uses the free threaded marshaler as an argument to a method on the proxy retrieved from `CoUnmarshalInterface`, it passes `MSHCTX_LOCAL` when trying to marshal, which the results in the free threaded marshaler trying to create a proxy/stub which fails. -- v3: combase: Use correct destination context in CoUnmarshalInterface when using the standard marshaler. ole32/tests: Extend test_marshal_channel_buffer() test to include IRpcProxyBufferWrapper checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/3198

3 7

[PATCH v5 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) 13 Jul '23

13 Jul '23

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v5: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. vkd3d-shader/hlsl: Handle resource components individually for SM 5.0. vkd3d-shader/tpf: Introduce struct extern_resource. vkd3d-shader/hlsl: Allow derefs to provide the data_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

4 13

[PATCH 0/6] MR278: vkd3d-shader/dxil: Emit the shader instructions.
by Conor McCarthy (＠cmccarthy) 13 Jul '23

13 Jul '23

Sufficient for compiling a no-op pixel shader. This should probably be rebased on top of !263 because it introduces vkd3d_spirv_get_type_id_for_data_type(), which 263 renders unnecessary. !263 is not essential, but I think using two different type systems in the backend is not ideal. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/278

2 6

[PATCH v4 0/2] MR3301: Improve trace output
by Vitaly Lipatov (＠lav) 13 Jul '23

13 Jul '23

-- v4: secur32: Print also text name for EXTENDED_NAME_FORMAT argument. advapi32: Print also text name for POLICY_INFORMATION_CLASS argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/3301

2 2

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0])) > + return "(unknown)"; > + return string_NameFormat[NameFormat]; > +} > + > BOOLEAN WINAPI GetUserNameExW( > EXTENDED_NAME_FORMAT NameFormat, LPWSTR lpNameBuffer, PULONG nSize) > { > - TRACE("(%d %p %p)\n", NameFormat, lpNameBuffer, nSize); > + TRACE("(%d %s %p %p)\n", NameFormat, debugstr_NameFormat(NameFormat), lpNameBuffer, nSize); Written this way, it would make it appear that the function takes 4 parameters. I would suggest revising to make it clear that this is two representations of the same parameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38855

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/advapi32/lsa.c: > + "PolicyAuditEventsInformation", > + "PolicyPrimaryDomainInformation", > + "PolicyPdAccountInformation", > + "PolicyAccountDomainInformation", > + "PolicyLsaServerRoleInformation", > + "PolicyReplicaSourceInformation", > + "PolicyDefaultQuotaInformation", > + "PolicyModificationInformation", > + "PolicyAuditFullSetInformation", > + "PolicyAuditFullQueryInformation", > + "PolicyDnsDomainInformation" > +}; > + > +static LPCSTR debugstr_InformationClass(IN POLICY_INFORMATION_CLASS InformationClass) > +{ > + if (InformationClass >= sizeof(string_InformationClass)/sizeof(string_InformationClass[0])) ```suggestion:-0+0 if (InformationClass >= ARRAY_SIZE(string_InformationClass)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38854

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0])) ```suggestion:-0+0 if (NameFormat >= ARRAY_SIZE(string_NameFormat)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38853

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > } > > +static LPCSTR string_NameFormat[] = > +{ > + "NameUnknown", > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" The values in the EXTENDED_NAME_FORMAT enumeration are not contiguous, so you need to fill in some gaps. For instance, NameUniqueId is 6. If passed in, this method would return "NameUserPrincipal". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38852

1 0

2025

2024

2023

2022

wine-gitlab July 2023