July 2023 - wine-gitlab

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0])) ```suggestion:-0+0 if (NameFormat >= ARRAY_SIZE(string_NameFormat)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38853

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 12 Jul '23

12 Jul '23

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > } > > +static LPCSTR string_NameFormat[] = > +{ > + "NameUnknown", > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" The values in the EXTENDED_NAME_FORMAT enumeration are not contiguous, so you need to fill in some gaps. For instance, NameUniqueId is 6. If passed in, this method would return "NameUserPrincipal". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38852

1 0

Re: [PATCH v2 0/3] MR3318: include: Update Kerberos related headers - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3318

1 0

Re: [PATCH v6 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo. - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

1 0

Re: [PATCH v2 0/1] MR3315: ntdll: Fix NtContinue from within exception context on ARM64 - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3315

1 0

Re: [PATCH v2 0/1] MR3316: windows.globalization: Use separate AddRef/Release methods for the language factory. - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3316

1 0

Re: [PATCH v3 0/1] MR3309: kernel32/tests: Update a todo that succeeds with the new wow64 architecture. - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3309

1 0

Re: [PATCH v2 0/6] MR3306: Remove DECLSPEC_HIDDEN - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3306

1 0

Re: [PATCH v2 0/3] MR3304: Remove DECLSPEC_HIDDEN from Media Foundation - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3304

1 0

Re: [PATCH v2 0/1] MR3307: wbemdisp: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 12 Jul '23

12 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3307

1 0

2025

2024

2023

2022

wine-gitlab July 2023