July 2023 - wine-gitlab

[PATCH v10 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v10: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit from abort_thread. ntdll: Avoid calling abort_thread from the signal stack. ntdll: Use is_inside_syscall more consistently. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 9

[PATCH 0/1] MR3416: ieframe: Forward WM_PAINT messages to the document host and all its child windows.
by Torge Matthies (＠tmatthies) 09 Oct '23

09 Oct '23

Windows gives this content special protection from being painted over, by some means that I have not investigated yet. Emulate this protection for the trivial case of an InvalidateRect(...); call on the parent window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3416

4 9

[PATCH 0/4] MR229: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 2
by Francisco Casas (＠fcasas) 06 Oct '23

06 Oct '23

Support for relative addressing in SM4. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/229

6 27

[PATCH v3 0/8] MR1684: d3d10/effect: Further improvements to expressions support.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

-- v3: d3d10/effect: Add 'ceil' instruction for expressions. d3d10/effect: Add 'dot' instruction support for expressions. d3d10/effect: Add trigonometric instructions support for expressions. d3d10/effect: Add support for shift instructions. d3d10/effect: Add 'or' instruction support for expressions. d3d10/effect: Add more integer instructions for expressions. d3d10/effect: Add signed integer compare instructions for expressions. d3d10/effect: Implement instructions used for signed integer division. https://gitlab.winehq.org/wine/wine/-/merge_requests/1684

3 14

[PATCH 0/1] MR3025: include: Add missing interfaces in wia_lh.idl
by Biswapriyo Nath (＠Biswa96) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3025

3 5

[PATCH 0/1] MR2684: mf: Request more samples for transforms when needed.
by Shaun Ren (＠shaunren) 29 Sep '23

29 Sep '23

This avoids stalling the pipeline when upstream nodes have not given enough samples for processing. If there are multiple upstream nodes, request samples in a round-robin fashion. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2684

3 3

[PATCH 0/3] MR2325: d3d10/effect: Implement instructions used for signed integer division.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2325

4 15

[PATCH 0/1] MR235: include: Add missing constants in d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/235

4 7

[PATCH v24 0/6] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 Sep '23

13 Sep '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v24: winesni.drv: add dbus watch instead of using plain unix fds and flush winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 7

[PATCH 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) 10 Sep '23

10 Sep '23

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

4 6

2025

2024

2023

2022

wine-gitlab July 2023