July 2023 - wine-gitlab

[PATCH v6 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 29 Aug '23

29 Aug '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v6: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

4 6

[PATCH 0/3] MR3153: loader: Add BootId registry key.
by Daniel Lehman (＠dlehman25) 25 Aug '23

25 Aug '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=55129 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3153

3 6

[PATCH 0/1] MR1809: gdiplus: Use width replace height in GdipCreateBitmapFromHICON.
by caibb2018 (＠caibb2018) 22 Aug '23

22 Aug '23

Signed-off-by: caibb2018 <1204611687(a)qq.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809

4 4

[PATCH v2 0/1] MR264: vkd3d-shader/ir: Rename vkd3d_shader_instruction to ir_instr.
by Zebediah Figura (＠zfigura) 21 Aug '23

21 Aug '23

There are a few motivations for this: * Identifiers beginning with vkd3d_shader_ look like external API. Changing the prefix makes it clear that this is an internal API. * vkd3d_shader is a very long prefix, which is annoying to type [not least because "vkd3d" itself is an unwieldy name.] This is also a motivation for shortening "instruction" to "instr". * The "vkd3d_instruction" is increasingly growing from a simple parsed representation of sm4 bytecode, to a proper IR in its own right—e.g. we are using it for sm1 and sm6, are performing passes over it, and we have plans to extend its scope further, e.g. to HLSL compilation. Give it a name that reflects and clearly communicates what it is. -- v2: vkd3d-shader/ir: Rename vkd3d_shader_instruction to ir_instr. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/264

5 12

[PATCH v6 0/1] MR279: vkd3d: Implement ID3D12Device1.
by Conor McCarthy (＠cmccarthy) 21 Aug '23

21 Aug '23

-- v6: vkd3d: Implement ID3D12Device1 with stubs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/279

3 2

[PATCH v2 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 20 Aug '23

20 Aug '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- v2: server: Check for SO_DEFAULT_HEADERS before using it. https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

4 10

[PATCH v6 0/3] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) 17 Aug '23

17 Aug '23

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v6: add a skip log when there is no simsun font in test env. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 5

[PATCH v4 0/10] MR3418: Draft: Add tryok() for tests that may need multiple attempts to succeed
by Francois Gouget (＠fgouget) 16 Aug '23

16 Aug '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is to loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, the tryok() failures area ignored but cause one more attempt to be made. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which marks the current attempt as failed as if calling tryok(0), and returns true if another attempt can be made. * attempt_failed() which returns true if an ok() call failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the few cases I looked at. But I think this mechanism has value even if the two end up coexisting indefinitely. This MR uses the tryok() in some actual tests for illustration and testing purposes. The final MR will probably split most of those off to separate MRs. -- v4: mmdevapi/tests: Replace flaky with tryok() in the capture tests. mmdevapi/tests: Replace flaky with tryok() in the render tests. quartz/tests: Replace flaky() with tryok() to work around scheduling delays. DEBUG ieframe/tests: tryok() framework testing ground. ieframe/tests: Work around a network session race condition. advapi32/tests: Replace the custom loop with tryok() mechanism. ntdll/tests: Use tryok() to fix a free disk space race with other processes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

4 16

[PATCH v2 0/2] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 15 Aug '23

15 Aug '23

-- v2: vkd3d: Write Vulkan descriptors in a worker thread. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

3 3

[PATCH 0/1] MR293: vkd3d-shader/hlsl: Force sm1 inputs to be 4-component only for vertex shaders.
by Zebediah Figura (＠zfigura) 15 Aug '23

15 Aug '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/293

4 5

2025

2024

2023

2022

wine-gitlab July 2023