August 2023 - wine-gitlab

Re: [PATCH v17 0/2] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 31 Aug '23

31 Aug '23

On Thu Aug 31 12:26:04 2023 +0000, Yuxuan Shui wrote: > I see, in current version all threads Waits on the same Address, so the > address' futex queue is contended. Threads are spinning on > `queue->lock`, so there is a chance for the lock to be released and the > threads never actually call `futex` (in this synthetic test anyway). > Whereas with this MR threads are generally waiting on different > addresses, so they always enter futex. Another observation is current SRWLOCK is pretty unfair (again, in this one test). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3504#note_43962

1 0

Re: [PATCH v17 0/2] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 31 Aug '23

31 Aug '23

On Thu Aug 31 12:25:16 2023 +0000, Yuxuan Shui wrote: > oh my, native SRWLOCK is really really fast. Even when compared to the > current, no wait list version. > I noticed with exclusive locks, current SRWLOCK would show >100% CPU > usage. I think this means there are some spinning going on? I see, in current version all threads Waits on the same Address, so the address' futex queue is contended. Threads are spinning on `queue->lock`, so there is a chance for the lock to be released and the threads never actually call `futex` (in this synthetic test anyway). Whereas with this MR threads are generally waiting on different addresses, so they always enter futex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3504#note_43958

1 0

[PATCH v9 0/3] MR318: ci: Execute the tests, also on AMD.
by Giovanni Mascellani (＠giomasce) 31 Aug '23

31 Aug '23

Running the tests on AMD requires rebuilding the Docker image, unfortunately, so the pipelines for this MR won't work until the MR itself is accepted (and the image is regenerated). -- v9: ci: Briefly document the CI setup. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/318

3 4

Re: [PATCH v17 0/2] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 31 Aug '23

31 Aug '23

oh my, native SRWLOCK is really really fast. Even when compared to the current, no wait list version. I noticed with exclusive locks, current SRWLOCK would show >100% CPU usage. I think this means there are some spinning going on? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3504#note_43949

1 0

[PATCH v8 0/3] MR318: ci: Execute the tests, also on AMD.
by Giovanni Mascellani (＠giomasce) 31 Aug '23

31 Aug '23

Running the tests on AMD requires rebuilding the Docker image, unfortunately, so the pipelines for this MR won't work until the MR itself is accepted (and the image is regenerated). -- v8: ci: Briefly document the CI setup. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/318

2 3

[PATCH v5 0/10] MR3645: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 7.
by Gabriel Ivăncescu (＠insn) 31 Aug '23

31 Aug '23

-- v5: mshtml: Implement Cycle Collection for XMLHttpRequest. mshtml: Implement Cycle Collection for HTMLPerformanceTiming. mshtml: Move PerformanceTiming related fields to the window. mshtml: Move HTMLPerformanceNavigation related fields to the window. mshtml: Implement Cycle Collection for inner windows. mshtml: Get rid of NULL checks for the dispex vtbl. mshtml: Implement Cycle Collection for outer windows. mshtml: Implement Cycle Collection for HTMLLocation. mshtml: Separate the HTMLLocation from the outer window. mshtml: Actually traverse the object-specific edges. https://gitlab.winehq.org/wine/wine/-/merge_requests/3645

3 12

[PATCH v4 0/2] MR3172: vkd3d: Import upstream release 1.8
by Alexandre Julliard (＠julliard) 31 Aug '23

31 Aug '23

-- v4: vkd3d: Import upstream commit 269747dbf3ee32bf23e6d1ab388d2a058ca90f9f. vkd3d: Import upstream release 1.8. https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

4 8

Re: [PATCH v3 0/5] MR310: hlsl: Define some intrinsics in HLSL.
by Giovanni Mascellani (＠giomasce) 31 Aug '23

31 Aug '23

> Mostly because it's not terribly practical to check in anything that outputs more than one or two lines. I think we should adopt the vkd3d_bytecode_buffer scheme and track the status on the vkd3d_string_buffer instead of attempting to propagate errors up from vkd3d_string_buffer_resize(). Agreed. What I don't like is that no check of allocation failure is done at all. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/310#note_43932

1 0

[PATCH v2 0/6] MR3691: include: Deduplicate WineTest helpers. (2/2)
by Rémi Bernon (＠rbernon) 31 Aug '23

31 Aug '23

-- v2: dinput: Get rid of duplicated winetest helpers. include: Avoid using strcmp directly in wine/test.h. include: Introduce winetest wrappers for vprintf and GetTickCount. include: Pass a temporary buffer to winetest_elapsed. include: Rename winetest_printf to winetest_print_location. include: Initialize winetest global counters to 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/3691

3 8

[PATCH 0/1] MR3255: win32u: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 31 Aug '23

31 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3255

4 6

2025

2024

2023

2022

wine-gitlab August 2023