February 2024 - wine-gitlab

Re: [PATCH v25 0/4] MR4982: dmime: load MIDI files
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

On Thu Feb 8 18:34:03 2024 +0000, Rémi Bernon wrote: > Yes since playing midi tracks turned out to be more involved, let's do this piecemeal like you said. i made this MR just about parsing, is this mergeable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4982#note_60649

1 0

[PATCH 0/1] MR5006: msxml3: Enable XPath object cache.
by Hans Leidekker (＠hans) 08 Feb '24

08 Feb '24

This gives a 30% performance increase in a local test with a very large document. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5006

3 3

[PATCH v2 0/1] MR4828: mf: Only preroll when starting from stopped state.
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

Stream sink such as evr can't be prerolled a second time, and when we are restarting from a paused state, those stream sink will already be prerolled so don't preroll them again. Otherwise we will be waiting for Prerolled events that will never come. Split from !4545, splitting the fix from the tests because turns out the tests are contentious. -- v2: mf: Only preroll when starting from stopped state. https://gitlab.winehq.org/wine/wine/-/merge_requests/4828

3 2

[PATCH v23 0/6] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v23: dmime: Create a band track for MIDI segments. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Parse MIDI tracks. dmime: Add stubs for MIDI tracks dmime: Parse MIDI headers. dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 8

[PATCH v2 0/1] MR4914: ntdll: Avoid sending context in wait_suspend() when not required.
by Paul Gofman (＠gofman) 08 Feb '24

08 Feb '24

Currently usr1_handler always delivers the context to server. With AVX enabled the single context size is around 1k (while there are two of those for wow64). I am now working on a more generic xstate support in contexts (mostly motivated by AVX512), with AVX512 the single context to be transferred to server is ~1k bigger. The context is needed to be passed to the server from usr1_handler only for NtGetContextThread, NtSetContextThread and NtSuspendThread handling (e. g., when stop_thread is called on the server). The vast majority of usr1_handler usage is for kernel APCs (e. g., APC_ASYNC_IO involved in every async operation) that don't need the thread context transferred to the server and back. My measurements of single SERVER_START_REQ( select ) in server_select() shows that the turnaround time of the request with the context (on native x64 without wow context) is almost two times bigger on average when currently supported AVX context is involved (that is, on every usr1_handle invocation on a machine supporting AVX). So, this patch is expected to increase the time of relatively rare calls which actually need contexts by roughly 50% but decrease the turnaround time of frequent calls involving system APCs by 50%. The difference will be more in favour of this patch once huge AVX512 contexts are added. -- v2: ntdll: Avoid sending context in wait_suspend() when not required. https://gitlab.winehq.org/wine/wine/-/merge_requests/4914

5 23

[PATCH v22 0/7] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v22: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Parse MIDI tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 8

[PATCH v21 0/7] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v21: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 11

[PATCH v20 0/9] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v20: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse set tempo meta events. dmime: Parse MIDI tracks. dmime: Add stubs for MIDI tracks dmime: Parse MIDI headers. dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 9

Re: [PATCH v2 0/6] MR5053: wined3d: FFP refactoring.
by Zebediah Figura (＠zfigura) 08 Feb '24

08 Feb '24

> Would it make sense to rename shader_select()/vp_enable()/fp_enable() to something like shader_apply_draw_state()/vp_apply_draw_state()/fp_apply_draw_state(), along the lines of wined3d_context_vk_apply_draw_state()? Good idea; I'll make that change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5053#note_60620

1 0

[PATCH v19 0/10] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v19: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse set tempo meta events. dmime: Parse MIDI tracks. dmime: Add stubs for MIDI tracks dmime: Parse MIDI headers. dmime/test: add MIDI loading test dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 13

2025

2024

2023

2022

wine-gitlab February 2024