On Mon Apr 22 09:02:12 2024 +0000, Alexandros Frantzis wrote:
> Hi @shmerl, I have already reviewed and approved this MR (and cannot
> merge myself). I guess it has fallen through the cracks, or perhaps
> @julliard and/or @rbernon would like to review themselves?
Yeah, may be some mix up about who can approve it for the final merge. See [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65890)
> It's perhaps instead that approval only show up if the person is assigned as a reviewer, or that it was overlooked.
It would be good to merge it for the next release.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68466
As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR:
1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information.
2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated).
3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`.
4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland.
At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR:
1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations.
2. Remove the `wglDescribePixelFormat` driver API.
Thanks!
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5517
Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute`
--
v5: shell32: Restore the ability of running native unix programs with ShellExecute
https://gitlab.winehq.org/wine/wine/-/merge_requests/5400
On Mon Apr 22 09:02:12 2024 +0000, Shmerl wrote:
> @afrantzis: A gentle ping. Can you please review and merge this?
Hi @shmerl, I have already reviewed and approved this MR (and cannot merge myself). I guess it has fallen through the cracks, or perhaps @julliard and/or @rbernon would like to review themselves?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68401