In source_reader_create_transform(), store the result of
IMFActivate_ActivateObject() so that in the event of failure, resources
are freed and an appropriate HRESULT is returned.
Previously, if every object's activation failed, the last part of the
function was not aware of this.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5515
The default behaviour for gstreamer is to use the URI to create the
stream-id. Without this, gstreamer creates a random stream-id per pad
which can cause inconsistent ordering on the decodebin src pads.
This in turn can cause issues, for example, with audio stream selection.
The first commit is a partial cherry-pick of eda34f74c6ad from Proton.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5511
On Mon Apr 22 09:02:12 2024 +0000, Alexandros Frantzis wrote:
> Hi @shmerl, I have already reviewed and approved this MR (and cannot
> merge myself). I guess it has fallen through the cracks, or perhaps
> @julliard and/or @rbernon would like to review themselves?
Yeah, may be some mix up about who can approve it for the final merge. See [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65890)
> It's perhaps instead that approval only show up if the person is assigned as a reviewer, or that it was overlooked.
It would be good to merge it for the next release.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68466