August 2024 - wine-gitlab

[PATCH 0/11] MR6207: include: Introduce new COM implementation helper macros.
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

3 12

[PATCH 0/1] MR6208: include: Always declare _setjmp in setjmp.h on i386 targets.
by Jacek Caban (＠jacek) 05 Aug '24

05 Aug '24

Clang supports _setjmp but, like most MSVC-style builtins, it still requires function declaration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6208

2 1

[PATCH 0/7] MR6204: mshtml: Add support for prototype chains and more prototype objects.
by Jacek Caban (＠jacek) 05 Aug '24

05 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6204

3 8

[PATCH v2 0/4] MR6199: Draft: winewayland.drv: Fix keyboard focused out behavior
by YuriK7 (＠riyu12383) 05 Aug '24

05 Aug '24

Fix the wayland side of https://bugs.winehq.org/show_bug.cgi?id=55336 ### Exit menu key by default: That's the actual behavior, any non-special key will exit the menu key, and be sent to the client. I was also wondering if we should add `menu_sys_key = f10_key = 0;` when receiving a `WM_ACTIVATE` in `win32u/defwnd.c`'s `default_window_proc` but I guess not ? ### Fix repeated key for no reason: For some reason when ALT is pressed, it is spammed and thus spams SYS_COMMAND. This fix that, but I don't know what I am doing here. I don't see any repeating key spamming with winex11 but I could be wrong. However alt/SYS_COMMAND should not be repeated. That wasn't happening with winex11.drv. ### Fix release_all_keys modifier filtering: That was the main reason why alt-tab leads to the menu key, NtUserGetAsyncKeyboardState also uses left and right system keys. ### Fix release_all_keys scan value: This one is incomplete, the scan code or something else is broken, at least with the down arrow on a french azerty keyboard. Even though release_all_keys sends the input for the down arrow, it is not transmitted to NtUserTranslateMessage. keyboard_handle_key send a key=28 and scan=0x150, but release_all_keys sends key=28 and scan=0x50. Winex11 sends 0x50, but internally NtUserTranslateMessage receives 0x150. This results in the down arrow kept being repeated while being focused out, and after focusing in, pressing again the arrow is needed. I tried changing things but ultimately it doesn't change anything. Maybe NtUserMapVirtualKeyEx is broken or is it the handling of the keyboard layout ? Or is it actually keyboard_handle_key ? Winex11 and winemac uses `if !(NtUserGetAsyncKeyboardState(state)) return;` but I guess here we don't need to as we want to release all keys even if it fails ? -- v2: winewayland.drv: Fix release_all_keys scan value winewayland.drv: Fix release_all_keys modifier filtering server: Fix repeated key for no reason https://gitlab.winehq.org/wine/wine/-/merge_requests/6199

3 5

[PATCH v7 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 05 Aug '24

05 Aug '24

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v7: shell32: add support for balloon icon copying https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

3 3

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Zhiyi Zhang (＠zhiyi) 05 Aug '24

05 Aug '24

> virtual monitor is different than physical monitor,it has no builtin resolution. it is a window on host. for example, wine explorer.exe /desktop=123x456 can also show. so it has no need for apply builtin mode. Of course, the virtual monitor window doesn't have any real resolution. However, it's a virtual monitor, its purpose is to simulate a physical monitor. That's why we added a bunch of fake resolutions so that functions like ChangeDisplaySettings() can succeed. The initial resolution/size of the virtual monitor should be the one specified by the user, either via the registry or command line. > we can chat by weixin, my weixinhao fan-wenjie You can use #winehackers at libera IRC. So that others can see and maybe join the conversation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77734

1 0

[PATCH v2 0/1] MR5960: ntdll: Remove superflous null check (coverity)
by Fabian Maurer (＠DarkShadow44) 05 Aug '24

05 Aug '24

It's dereferenced later in create_window_handle anyways -- v2: win32u: Remove superflous null check (coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

4 4

[PATCH v5 0/1] MR6123: shdocvw: Add IEParseDisplayNameWithBCW semi-stub.
by Dmitry Timoshkov (＠dmitry) 05 Aug '24

05 Aug '24

-- v5: shdocvw: Add IEParseDisplayNameWithBCW semi-stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6123

5 11

Re: [PATCH v12 0/6] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 05 Aug '24

05 Aug '24

On Mon Aug 5 15:13:24 2024 +0000, Zhiyi Zhang wrote: > Hi, you need to rebase your patches on top of wine master. Thanks for looking into this. After some difficulties I finally managed to do so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6166#note_77807

1 0

[PATCH v3 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 05 Aug '24

05 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v3: comctl32/progress: Add states for progress bar. comctl32/tests: Add tests for progress bar states. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 10

2025

2024

2023

2022

wine-gitlab August 2024