August 2024 - wine-gitlab

[PATCH v7 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 05 Aug '24

05 Aug '24

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v7: shell32: add support for balloon icon copying https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

3 3

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Zhiyi Zhang (＠zhiyi) 05 Aug '24

05 Aug '24

> virtual monitor is different than physical monitor,it has no builtin resolution. it is a window on host. for example, wine explorer.exe /desktop=123x456 can also show. so it has no need for apply builtin mode. Of course, the virtual monitor window doesn't have any real resolution. However, it's a virtual monitor, its purpose is to simulate a physical monitor. That's why we added a bunch of fake resolutions so that functions like ChangeDisplaySettings() can succeed. The initial resolution/size of the virtual monitor should be the one specified by the user, either via the registry or command line. > we can chat by weixin, my weixinhao fan-wenjie You can use #winehackers at libera IRC. So that others can see and maybe join the conversation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77734

1 0

[PATCH v2 0/1] MR5960: ntdll: Remove superflous null check (coverity)
by Fabian Maurer (＠DarkShadow44) 05 Aug '24

05 Aug '24

It's dereferenced later in create_window_handle anyways -- v2: win32u: Remove superflous null check (coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

4 4

[PATCH v5 0/1] MR6123: shdocvw: Add IEParseDisplayNameWithBCW semi-stub.
by Dmitry Timoshkov (＠dmitry) 05 Aug '24

05 Aug '24

-- v5: shdocvw: Add IEParseDisplayNameWithBCW semi-stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6123

5 11

Re: [PATCH v12 0/6] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 05 Aug '24

05 Aug '24

On Mon Aug 5 15:13:24 2024 +0000, Zhiyi Zhang wrote: > Hi, you need to rebase your patches on top of wine master. Thanks for looking into this. After some difficulties I finally managed to do so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6166#note_77807

1 0

[PATCH v3 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 05 Aug '24

05 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v3: comctl32/progress: Add states for progress bar. comctl32/tests: Add tests for progress bar states. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 10

Re: [PATCH v2 0/5] MR6148: include/codecapi.h: Add encoder defines. - approved
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6148

1 0

[PATCH 0/1] MR6132: win32u: Implement EVENT_SYSTEM_CAPTURESTART/END.
by Esme Povirk (＠madewokherd) 05 Aug '24

05 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6132

4 3

Re: [PATCH v3 0/4] MR6074: Draft: Add support for HID multi toplevel-collections
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

Thanks, this looks good. I have opened a separate MR (https://gitlab.winehq.org/wine/wine/-/merge_requests/6206) with various minor changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6074#note_77777

1 0

Re: [PATCH v3 0/4] MR6074: Draft: Add support for HID multi toplevel-collections
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

Rémi Bernon (@rbernon) commented about dlls/winebus.sys/main.c: > RtlEnterCriticalSection(&ext->cs); > list_add_tail(&ext->reports, &report->entry); > > - if (!ext->collection_desc.ReportIDs[0].ReportID) last_report = ext->last_reports[0]; > + for ( i = 0; i < ext->collection_desc.CollectionDescLength; ++i ) > + { > + HIDP_COLLECTION_DESC *desc = &ext->collection_desc.CollectionDesc[i]; > + for ( j = 0; j < ext->collection_desc.ReportIDsLength; ++j ) > + { > + if (ext->collection_desc.ReportIDs[j].CollectionNumber != desc->CollectionNumber) continue; > + if (!ext->collection_desc.ReportIDs[j].ReportID) last_report = ext->last_reports[0]; > else last_report = ext->last_reports[report_buf[0]]; > memcpy(last_report->buffer, report_buf, report_len); > + break; > + } > + } I'm not sure to understand this. Is it to cover the case where some of the TLC use report IDs while other don't, and I don't think that can happen? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6074#note_77776

1 0

2025

2024

2023

2022

wine-gitlab August 2024