On Fri Feb 28 22:41:11 2025 +0000, Bernhard Übelacker wrote:
> I am not sure if I understand you right. Before this patch `res ==
> STATUS_INVALID_PARAMETER` was part of the ok and the if condition around
> the skip. After my patch the ok should never get reached with `res ==
> STATUS_INVALID_PARAMETER`, so isn't checking for it superfluous?
> I am happy with either way, should I add it again?
Maybe I have misread part of the patch, sorry for that.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7445#note_96273
Since 9b8409fce4da18e3d9a914a9e5831d10eb9052de, a PE compiler is required for 32 bit arm.
That can either be supplied by using plain Clang (from a distro), or llvm-mingw. However when using plain Clang (in MSVC mode), we're lacking compiler builtin functions that either would be provided by MSVC libraries or by compiler-rt libraries bundled in llvm-mingw.
Vendor a copy of the relevant files from compiler-rt and include them when building for arm in MSVC mode.
This allows building a functional wine for 32 bit arm without requiring third party tools such as llvm-mingw.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7205