February 2025 - wine-gitlab

[PATCH 0/1] MR7306: winex11.drv: Don't call NtUserGetWindowLongW() from X11DRV_GetWindowStateUpdates() with win_data_mutex held.
by Paul Gofman (＠gofman) 07 Mar '25

07 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7306

3 8

[PATCH 0/9] MR5057: Draft: winewayland.drv: Use virtual display devices to implement mode change emulation
by Alexandros Frantzis (＠afrantzis) 07 Mar '25

07 Mar '25

This WIP branch prototypes the usage of virtual display devices (through "virtual desktop" mode at the moment) to support display mode emulation in the Wayland driver. It works by allowing the driver to mark each host adapter with a virtual_id, which, if present, signals to win32u that it should include the adapter in the virtual display configuration. The virtual configuration (along with the virtual ids) is reported back to the driver though a new user driver function. If none of the host adapters is marked with a virtual id (i.e., all other drivers) we fall back to the single virtual display mode as before. Some deficiencies and open questions with the prototype: 1. Virtual desktop mode implies a lot of behavior that we don't want at this point the Wayland driver (e.g., taskbar window, changing the display mode to the virtual desktop resolution at startup, some changes in fsclip behavior). One way forward would be to have a "virtual display devices" mode separate from the "virtual desktop" mode, so that drivers can opt in only to the desired behavior (virtual desktop would imply virtual devices, to maintain the current behavior). 2. It's not clear to me what would be the best way for a driver to opt in or out of certain core behavior. Perhaps the driver would change some volatile registry key which other components would consult? Or introduce a user driver function for core to query the driver about such features on demand? Is there some precedence I can get inspiration from? 3. At the moment, the prototype calls the new "NotifyVirtualDevices" user driver callback only in the process which the display update occurred. This means that other processes don't get notified of the virtual devices mapping to host devices, so, in the Wayland driver case, we are not able to scale windows from those processes properly. One approach would be for core to ensure that the NotifyVirtualDevices callback is called once in all processes, but I am not sure what's the best way to achieve this (or even if this is the preferred approach). Another way would be to have a mechanism for the driver to query the virtual device info (+mappings) on demand, and just broadcast a message to all windows. In this case it could even be done internally by the driver (so more in line with what the part-12 MR is doing), if we don't want to introduce a more global behavior. Perhaps there is some even better mechanism, which would also be more fitting to how we envision the virtual display/devic es to evolve going forward. Let me know what you think! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5057

5 25

[PATCH v3 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon (＠rbernon) 05 Mar '25

05 Mar '25

-- v3: include: Fix wmemchr C++ warning. include: Fix InlineIsEqualGUID C++ warning. include: Add some _BitScanForward(64) declarations in intrin.h. include: Add a __shiftright128 intrinsic definition. include: Add a _umul128 intrinsic definition. include: Move FILE_DISPOSITION_INFO after DeleteFile(A|W). include: Add a MB_CUR_MAX definition in ctype.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

3 14

[PATCH 0/3] MR7416: wined3d: Interpret Y'CbCr values as being from the reduced range.
by Elizabeth Figura (＠zfigura) 04 Mar '25

04 Mar '25

This is an adjustment of 7324. d3d9:visual already has a test that's relatively close to what a simplified version of the tests in 7324 looked like, so I made the few changes to expand that test to match and then ported it to ddraw. Implementation-wise, this removes the SD/HD difference (which only exists on NVidia and is not necessary to improve the mentioned application). It also removes the clamping of YUV values, which as the tests show is not correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7416

6 8

[PATCH v4 0/6] MR7233: wineswmidi: Add SW Synth MIDI driver part 0.
by Anton Baskanov (＠baskanov) 04 Mar '25

04 Mar '25

-- v4: wineswmidi: Initialize DirectMusic when opening the device. https://gitlab.winehq.org/wine/wine/-/merge_requests/7233

2 8

[PATCH 0/1] MR3131: gdiplus: Fix gif shows misplaced.
by Jiajin Cui (＠jin-king1) 04 Mar '25

04 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54271 Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3131

3 6

[PATCH v3 0/7] MR7432: mp3dmod: Add future support for Float encoding and fix various discrepancies with Windows
by Brendan McGrath (＠redmcg) 04 Mar '25

04 Mar '25

This MR adds the ability to support float encoding (which will be used by the IMFTransform interface). It also adds tests and addresses a number of small discrepancies discovered between the Wine and native implementation. -- v3: mp3dmod: Ensure nChannels is greater than zero on input. mp3dmod/tests: Add test for nChannels = 0 on input. https://gitlab.winehq.org/wine/wine/-/merge_requests/7432

3 9

[PATCH 0/1] MR7281: include: Prefer builtin atomics on x86 unless known broken.
by William Horvath (＠whrvt) 04 Mar '25

04 Mar '25

Clang presents as GCC 4.2.1, so it was always using the fallbacks for `InterlockedExchange{,Pointer}` on the non-PE side. The fix for the GCC `__atomic_*` bug linked in the comment for the `__WINE_ATOMIC_*` macros first appeared in GCC 8: https://github.com/gcc-mirror/gcc/commit/d8c40eff56f69877b33c697ded756d50fd… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7281

3 6

[PATCH v3 0/2] MR7119: ntdll, loader: Add __attribute__((used)) to a few symbols that shouldn't be discarded.
by William Horvath (＠whrvth) 04 Mar '25

04 Mar '25

These changes are enough to allow building the entirety of the native (ELF) side with `-flto`. -- v3: loader: Mark thread_ldt, thread_data, wld_start "used". ntdll: Mark call_init_thunk and abort_thread "used". https://gitlab.winehq.org/wine/wine/-/merge_requests/7119

4 5

[PATCH 0/6] MR7436: d3dx9: More changes to D3DXSaveSurfaceToFileInMemory().
by Connor McAdams (＠cmcadams) 03 Mar '25

03 Mar '25

This patch series reworks `D3DXSaveSurfaceToFileInMemory()` to use the new `d3dx_save_pixels_to_memory()` function. It also adds support for selecting a replacement pixel format when the image file format being saved to doesn't have direct support for the pixel format being saved. The code for calculating the best replacement format was inspired by the code in `check_texture_requirements()` in `d3dx9_36/texture.c`. This should fix WineHQ bug 51584, but I haven't tested that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7436

3 11

2025

2024

2023

2022

wine-gitlab February 2025