April 2025 - wine-gitlab

[PATCH v17 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v17: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH v16 0/7] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v16: server: Fixup for deleting socket files https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 10

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > set_error( STATUS_OBJECT_NAME_COLLISION ); > goto error; > } > ftruncate( fd->unix_fd, 0 ); Here is a direct usage of the `unix_fd`, which may be a problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100892

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:51:04 2025 +0000, Ralf Habacker wrote: > and added to the opened inode list. This is normal behavior and not fd_unix related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100890

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:43 2025 +0000, Ralf Habacker wrote: > and is set as the `fd->closed` Here is no fd_unix related issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100888

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:06 2025 +0000, Ralf Habacker wrote: > Here the `unix_fd` is saved for closing the file, which is -1 in the > case of sockets. `unix_fd` is used in `inode_close_pending()`, `inode_destroy()`, `inode_add_closed_fd()`, `fd_destroy()` and `unmount_fd()` to close the file. In any of the mentioned location the call to close() is guarded with `if (fd->unix_fd != -1)`, so these function are already save the socket case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100886

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > fd->inode = inode; > fd->closed = closed_fd; > fd->cacheable = !inode->device->removable; > list_add_head( &inode->open, &fd->inode_entry ); and added to the opened inode list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100884

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > closed_fd->unix_name = fd->unix_name; > closed_fd->disp_flags = 0; > fd->inode = inode; > fd->closed = closed_fd; and is set as the `fd->closed` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100883

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > free( path ); > } > > closed_fd->unix_fd = fd->unix_fd; Here the `unix_fd` is saved for closing the file, which is -1 in the case of sockets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100882

1 0

[PATCH 0/1] MR7821: winhttp/tests: Add broken to test_redirect.
by Bernhard Übelacker (＠bernhardu) 15 Apr '25

15 Apr '25

Followup of d2e03e5b43. [This is a testbot run.](https://testbot.winehq.org/JobDetails.pl?Key=157865) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7821

3 2

2025

2024

2023

2022

wine-gitlab April 2025