- wine-gitlab - winehq.org

[PATCH 0/5] MR7150: crypt32: Do not delete root certs which were not imported from host.
by Paul Gofman (＠gofman) 16 Jan '25

16 Jan '25

Currently the logic of syncing of certificates with host effectively assumes that all the root certificates come from host and doesn't mind the certificates added by the app (those erroneously get deleted during host sync). That fixes Battle.net being unable to complete game installs / update after Battle net update on 14 Jan 2025. This is not for code freeze obviously. The issue is that Battle.net fails to verify certificate chain which depends on an ephemeral certificate marked valid for DNS:localbattle.net (which resolves to 127.0.0.1) server auth. The certificate is self signed and is added to system root storage by Battle.bet setup (and also possibly later if it is missing). The addition of certificate to system root storage works per se, but then upon syncing host root certificates (in another process or new prefix start) the certificate gets wiped from registry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7150

3 6

Re: [PATCH v3 0/1] MR7149: gdiplus: Check for MapFont result in generate_font_link_info. - approved
by Alexandre Julliard (＠julliard) 16 Jan '25

16 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7149

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 16 Jan '25

16 Jan '25

from the top directory where you compiled Wine ./wine programs/winetest/x86_64-windows/winetest.exe -o - cmd.exe -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92048

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 16 Jan '25

16 Jan '25

Thank you. I know nothing about running these tests. I just opened a command prompt via "wine cmd" and then just launched the test .cmd file. When I have some time I'll research how to run the tests, assuming that it's in the dev docs here somewhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92045

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Patrick Laimbock (＠Patrick) 16 Jan '25

16 Jan '25

> I don't want to break something else this late. That makes total sense :smiley: I'm happy to test anything so feel free to ping me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92038

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon (＠rbernon) 16 Jan '25

16 Jan '25

On Thu Jan 16 11:31:22 2025 +0000, Patrick Laimbock wrote: > Hi Rémi. With the change below (bug51357.patch) from > https://bugs.winehq.org/show_bug.cgi?id=51357 the wrong mouse offset is > fixed in the VST plugin's main window titled 'Spire'. But, e.g. clicking > the 'menu' button shows the menu in the wrong place. See screenshot. The > menu should appear below the 'menu' button (top row) in the window > titled 'Spire'. So the change above does not fix the issue but hopefully > it gives you an idea what the problem might be. If you need more > information please let me know. Thanks! > [bug51357.patch](/uploads/dea8a1e711846f7e7642c16eacd284b4/bug51357.patch) > ![Screenshot_From_2025-01-16_11-49-56](/uploads/decbb70d2abc1b99d3fd28e0b6382080/Screenshot_From_2025-01-16_11-49-56.png) Thank you! Yes, I think we could consider doing something like and use window-relative coordinates all the time, now that we're better tracking the X window tree position, and stopped using XTranslateCoordinates. It would have to wait until Wine 10 is released though, I don't want to break something else this late. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92037

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Patrick Laimbock (＠Patrick) 16 Jan '25

16 Jan '25

On Sat Dec 7 21:33:25 2024 +0000, Rémi Bernon wrote: > I don't know for sure but there are probably some ways to make it work. > It works already more or less well with embedded systray windows, so > maybe doing something similar could be enough. > Alternatively mouse input is mapped in `map_event_coords` and we > preferred event root/x_root/y_root values when available because it > avoided some inconsistencies when moving windows, but window positioning > has been refactored lately, and maybe this isn't necessary anymore. > Using window-relative mouse input could solve your case too (or we could > also perhaps consider a winecfg option to prefer it over absolute positions). Hi Rémi. With the change below (bug51357.patch) from https://bugs.winehq.org/show_bug.cgi?id=51357 the wrong mouse offset is fixed in the VST plugin's main window titled 'Spire'. But, e.g. clicking the 'menu' button shows the menu in the wrong place. See screenshot. The menu should appear below the 'menu' button (top row) in the window titled 'Spire'. So the change above does not fix the issue but hopefully it gives you an idea what the problem might be. If you need more information please let me know. Thanks! [bug51357.patch](/uploads/dea8a1e711846f7e7642c16eacd284b4/bug51357.patch) ![Screenshot_From_2025-01-16_11-49-56](/uploads/decbb70d2abc1b99d3fd28e0b6382080/Screenshot_From_2025-01-16_11-49-56.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92034

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 16 Jan '25

16 Jan '25

if you can start cmd.exe and notepad.exe from your installation, that should be sufficient to run the tests are you running the tests with winetest or make test? the later can sometimes have issues with some symlinks from the build directory. using the former is safer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92028

1 0

Re: [PATCH v2 0/1] MR7149: gdiplus: Check for MapFont result in generate_font_link_info. - approved
by Esme Povirk (＠madewokherd) 16 Jan '25

16 Jan '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7149

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 15 Jan '25

15 Jan '25

OK, well, these tests appear to be practically a complete failure on my system. I'm receiving what appears to be an endless stream of lines like "Can't recognize 'temp.bat "Z:\\home\joe..." as an external command"..., etc. Admittedly, my wine build system is minimal; I do not have nearly all of the dependencies installed, but it was enough to build a basic wine installation including my changes to DIR. What I can probably do is make the changes to DIR as I think they should be, and either submit those changes or leave them here for someone else if they want to devote the time and effort into getting the tests to run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92010

1 0

2025

2024

2023

2022

wine-gitlab