We use 4*3 as the stride for GdipCreateBitmapFromScan0 in all test cases in test_CloneBitmapArea,
but bmp_3x3_data_24bpp_rgb only has 9 bytes per row. GdipCreateBitmapFromScan0 also expects the
stride to be a multiple of 4, so pad bmp_3x3_data_24bpp_rgb to be 12 bytes per row.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8218
On Fri Jun 6 18:17:35 2025 +0000, eric pouech wrote:
> @jacek just testing this (yeah a bit late sorry), it looks like the .pdb
> file only contains the public symbols.
> using: clang version 20.1.5
> do we need a later clang version?
I tested mostly with LLVM git, but version 19 seems to work too, unless I'm checking it wrong. For example, I get:
```
$ llvm-pdbutil dump --symbols programs/notepad/x86_64-windows/notepad.pdb |grep NOTEPAD_WndProc
7468 | S_LPROC32 [size = 56] `…
[View More]NOTEPAD_WndProc`
```
Do you not see such symbols in your build or did you mean something else?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8193#note_105685
[View Less]
--
v3: widl: Add rows for the requires keyword.
widl: Add rows for the exclusiveto attribute.
widl: Add rows for the uuid attribute.
widl: Add rows for the interface type.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8222
According to a comment in emf_create, description is expected to be "App name\0Title\0\0". But in
the test cases we only ever passed "winetest\0", so emf_create reads out-of-bound trying to find the
title.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8219
IWinInetHttpInfo_QueryInfo returns a multibyte string, not a wide string. We
were also wrongly expecting it to have a NUL terminator.
* * *
this one doesn't feel good. IWinInetHttpInfo_QueryInfo calls HttpInfo_QueryInfo (urlmon), which calls HttpQueryInfoA (wininet), so it returns char*. but inside, HttpQueryInfoA is calling HttpQueryInfoW and does charset conversion. so we are converting the string to multibyte and back.
maybe there's an API that returns wchar* i don't know about.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8228
This MR does:
- improve startup time when loading a large PDB file
(a chromium based PDB file (larger than 4G) now loads in 3,5s)
(at the begining of this rewrite, loading the very same PDB file
ended with a reboot triggered by the Linux OOM after 30 minutes
of heavy swap)
- finally untie the new PDB backend for the old one (they are now
considered as two independant debug formats, so that we can
eventually drop the old one at some point)
--
v2: dbghelp: Let new PDB reader …
[View More]exist independantly of the old one.
dbghelp: Rename declarations for old PBD backend.
dbghelp: Simplify signature of PDB unwinders.
dbghelp: Get fpo stream information directly in new PDB reader.
dbghelp: Speed up global symbols at startup.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8225
[View Less]
getItemAndInstanceFromTable only checks if the table is NULL, but didn't check
if it actually contains any entries. It just assumes it does and will return
index 1 in some cases, resulting in out-of-bound access of the table down the
line.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8230
If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working.
--
v4: comdlg32: Don't use a shadow devmode structure in PrintDlgA.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA.
comdlg32: Don't use a shadow devmode structure in …
[View More]PrintDlgW.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8220
[View Less]