On Fri Oct 31 17:40:12 2025 +0000, Paul Gofman wrote:
> I think the patch "ntdll: Add is_pseudo_handle() helper." should be
> renamed to reflect the fact it changes the check in cache_inproc_sync()
> instead of saying that it is helper. Otherwise, I don't see more issues
> so far.
Thanks for the thorough review. This is fixed as well now.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9305#note_120292
Current code attempts to copy a file to itself. File is not actually copied; instead, a file sharing error is received. This result is ugly and differs from native. Behavior now appears to be the same as native with changes in this MR .
--
v8: cmd/tests: Add tests for COPY to self.
cmd: Don't attempt to copy a file to itself.
cmd: Fix error parsing <NUL in the lexer.
xcopy/tests: Add test for XCOPY to self.
xcopy: Don't attempt to copy a file to itself.
https://gitlab.winehq.org/wine/wine/-/merge_requests/9112
Follow up to !8505. Depends on !5988 to be merged first. Includes commits from both of these MRs.
Note how some sample times are still marked TODO for non-thinned mode, because seemingly after 5988, delta buffers no longer have pts. The corresponding samples are still assigned a bogus sample time, because `has_pts` isn't checked by `media_stream_send_sample`. This is probably something to address once/if 5988 gets merged.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9327