September 2022 - Wine-gitlab

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes - closed
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This merge request was closed by Joel Holdsworth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924

1 0

[PATCH v2 0/1] MR942: ntdll: Unify get_file_info and fd_get_file_info.
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

In the ntdll file handling code, there are currently two duplicated file info setting functions: `get_file_info` and `fd_get_file_info`. One pasted on path strings, and the other based on file descriptors respectively. This patch set simplifies the code by unifying both functions into a single function ~~powered by `fstatat` instead of `lstat` and `fstat`~~. -- v2: ntdll: Unify get_file_info and fd_get_file_info. https://gitlab.winehq.org/wine/wine/-/merge_requests/942

4 7

[PATCH 0/4] MR943: uiautomationcore: Add more nested node features. (v2)
by Connor McAdams (＠cmcadams) 27 Sep '22

27 Sep '22

Changes since last MR: - Store list entry inside of `struct uia_node` instead of doing linear search for removal. - Replace `WARN` with `ERR` if provider thread shuts down with nodes still in the provider thread list. - Use `wine/rbtree.h` for looking up HUIANODEs by runtime ID. - Get rid of `struct uia_node *container_node` inside of `struct uia_provider`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/943

2 6

[PATCH 0/1] MR18: include: Use __MINGW_PRINTF_FORMAT when compiling with MinGW.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

The default for MinGW is always ms_printf rather than gnu_printf, but if we are using ucrtbase or ANSI stdio, we want gnu_printf. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/18

4 3

[PATCH 0/1] MR19: maintainers: New file.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

Based on the Wine maintainers file. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19

4 3

[PATCH 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon 27 Sep '22

27 Sep '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/944

1 6

[PATCH v2 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 27 Sep '22

27 Sep '22

Add the ability to disconnect nested node providers, and return element properties for nested nodes. -- v2: uiautomationcore: Add UIAutomationType_Element property support for nested node providers. uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Track all HUIANODEs returned from the provider thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/908

3 13

[PATCH 0/1] MR942: ntdll: Unify get_file_info and fd_get_file_info.
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

In the ntdll file handling code, there are currently two duplicated file info setting functions: `get_file_info` and `fd_get_file_info`. One pasted on path strings, and the other based on file descriptors respectively. This patch set simplifies the code by unifying both functions into a single function powered by `fstatat` instead of `lstat` and `fstat`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/942

4 4

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Erich Hoover (＠ehoover) 27 Sep '22

27 Sep '22

> ... > > My gut is that if extended attributes are "universal enough" > (and usable enough), and we can easily implement DOS attributes over > them, modulo slight differences in the API, then there isn't really any > need to implement something truly portable. I could be wrong about this, > though. What platforms do you consider to be important here? I ask because the current implementation (without fallback) supports Linux, Mac OS, FreeBSD, and NetBSD. That seems to me to be the "important" ones. > > There is also the storage of [NT extended-attribute (EA)](https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/n…) values to consider, when we move toward a non-stub implementation of this feature. > > > > Perhaps it would be preferable to produce a design that can be encompass all these issues. The NTFS spec separates DOS Attributes (Flags) from Extended Attributes (EA). I would not recommend mixing the two, for fear of an accidental name collision. If you want to design a fallback mechanism that supports both of these features the same way, then I would suggest structuring it like so: ``` .WINE_METADATA/<filename>/<feature> ``` That way when a copy/move operation is performed on a file then it's easier to copy both features together. > I don't have a good read on this, personally. I suppose it at least > partly depends on whether NT extended attributes are used by any > program. I'm at least not aware of any usage? I am not aware of any non-MS usage, but it is documented. So, I would not be surprised if some copy protection mechanism does something with it our chooses to do so at some point in the future. I do know that the Single Instance Storage (SIS) minifilter driver uses an extended attribute to "back reference" the single instance files to find the duplicates/originals. > I think working out the design completely before submitting any patches > would probably be a good idea. > > ... If the OS list above is sufficient then I think we're covered, if we need a fallback implementation then this probably needs a little more thought. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9410

1 0

[PATCH v16 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 27 Sep '22

27 Sep '22

-- v16: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7