May 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/9] MR2733: imm32: Tests and fixes for ImmTranslateMessage
by Rémi Bernon 02 May '23

02 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2733

2 10

Re: [PATCH v3 0/4] MR2726: wine{alsa,coreaudio,oss,pulse}: Move SimpleAudioVolume into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 02 May '23

02 May '23

On Mon May 1 22:33:05 2023 +0000, Davide Beatrici wrote: > Oops, this should've been set to `-1` for `winecoreaudio`: https://gitlab.winehq.org/wine/wine/-/blob/2b7ba08743d3a4062a1a1f12a952e329… !2732 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2726#note_31705

1 0

Re: [PATCH v3 0/4] MR2726: wine{alsa,coreaudio,oss,pulse}: Move SimpleAudioVolume into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 01 May '23

01 May '23

Davide Beatrici (@davidebeatrici) commented about dlls/mmdevapi/session.c: > } > > +static inline struct audio_session_wrapper *impl_from_ISimpleAudioVolume(ISimpleAudioVolume *iface) > +{ > + return CONTAINING_RECORD(iface, struct audio_session_wrapper, ISimpleAudioVolume_iface); > +} > + > +static void set_stream_volumes(struct audio_client *This) > +{ > + struct set_volumes_params params; > + > + params.stream = This->stream; > + params.master_volume = (This->session->mute ? 0.0f : This->session->master_vol); > + params.volumes = This->vols; > + params.session_volumes = This->session->channel_vols; > + params.channel = 0; Oops, this should've been set to `-1` for `winecoreaudio`: https://gitlab.winehq.org/wine/wine/-/blob/2b7ba08743d3a4062a1a1f12a952e329… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2726#note_31703

1 0

[PATCH v6 0/3] MR188: vkd3d-shader/tpf: Add support for emitting sample_l instructions
by Ethan Lee (＠flibitijibibo) 01 May '23

01 May '23

>From what I can tell, the recent work on SampleBias/SampleLevel did all of the work for us, we just need to take the same framework and include the case for the `sample_l` instruction. Tested with some shaders from the native Linux version of Little Racers STREET. -- v6: vkd3d-shader/tpf: For sample_l/sample_b, set lod swizzle to SCALAR. vkd3d-shader/tpf: Add support for emitting sample_l instructions tests: Add a test for SampleLevel() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/188

2 4

[PATCH v5 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation.
by Nikolay Sivov (＠nsivov) 01 May '23

01 May '23

-- v5: vkd3d-shader/hlsl: Partially implement static expressions evaluation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180

2 1

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Rémi Bernon 01 May '23

01 May '23

It indicates a misuse of the API and is undefined behavior according to Glib / GStreamer semantics. Glib tells about it nicely and returns a sensible value, but it should be fixed on the caller side. > The g_return family of macros (g_return_if_fail(), g_return_val_if_fail(), g_return_if_reached(), g_return_val_if_reached()) should only be used for programming errors, a typical use case is checking for invalid parameters at the beginning of a public function. They should not be used if you just mean “if (error) return”, they should only be used if you mean “if (bug in program) return”. The program behavior is generally considered undefined after one of these checks fails. They are not intended for normal control flow, only to give a perhaps-helpful warning before giving up. > > https://docs.gtk.org/glib/logging.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546#note_31696

1 0

Re: [PATCH v2 0/1] MR2730: include: Add DXGI_DEBUG_D3D11 in d3d11sdklayers.idl - approved
by Alexandre Julliard (＠julliard) 01 May '23

01 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2730

1 0

Re: [PATCH v2 0/1] MR2728: gdiplus: Traverse and draw the whole string - approved
by Alexandre Julliard (＠julliard) 01 May '23

01 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2728

1 0

Re: [PATCH v2 0/8] MR2729: printing: Use EMF spool files while printing. - approved
by Alexandre Julliard (＠julliard) 01 May '23

01 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2729

1 0

Re: [PATCH v3 0/4] MR2726: wine{alsa,coreaudio,oss,pulse}: Move SimpleAudioVolume into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 01 May '23

01 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2726

1 0