October 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4104: README: Update FreeBSD information
by Gerald Pfeifer (＠gerald) Oct. 15, 2023

Oct. 15, 2023

Bump minimum version from 8.0 to 12.4, the minimum release supported upstream. Streamline the FreeBSD section. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4104

2 1

[PATCH 0/12] MR4102: Draft: winewayland.drv: Implement keyboard input support.
by Rémi Bernon Oct. 15, 2023

Oct. 15, 2023

@afrantzis Can't seem to be possible to add you as a reviewer, probably you need to request "Access" to the wine/wine project (near the top of the project page). What do you think of something like that? It is very different from the current winex11 code, but I believe it will match keyboard layouts in a much more accurate way, and it's also IMO much simpler. If that works well with Wayland, I think it could be a good hint that it might work as well in X11 and make a case for my other MR to use that approach there. I was a bit annoyed that it doesn't seem possible to retrieve the Xkb "layout:variant" string here, but only the layout description, so I had to use xkbregistry to match it back to the known layouts. It is mostly only there to provide a more accurate HKL value (which should match the layout langid), and scan to vk mapping table, and custom layouts should still work. The lang would be neutral then, and the scan to vk table is QWERTY by default, which is the most common case, and doesn't enforce any vkey -> unicode mapping anyway. So, if the xkbregistry dependency is an issue we could probably make it optional and dynamically loaded, and skip the langid and scan to vk specialized mappings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4102

2 12

[PATCH v3 0/8] MR4014: winewayland.drv: part 8: More window management
by Alexandros Frantzis (＠afrantzis) Oct. 15, 2023

Oct. 15, 2023

This MR improves window management related behavior and adds support for more scenarios. Some highlights (please see the full commit list and messages for more info): 1. Better support for tiled states. 2. Detect and handle fullscreen windows. 3. Increased robustness against state disagreements between Wine and the Wayland compositor. 4. Move top-level windows to (0,0) (using that fixed point for now, we will later generalize this mechanism for multiple monitors), in order to: a. maximize the accessible mouse input region (which may be clipped in Windows virtual screen space, but still accessible in Wayland space). b. introduce the basic mechanism to allow windows applications to (very roughly!) track which output(s) they are really on (to be continued in the full multi-monitor form). Although (4) is not a perfect solution for the lack of absolute positioning, it has worked well in practice in its full, multi-monitor implementation (i.e., in the experimental branch). I wonder if for (4a) in particular we can do better, e.g., by being able to emit input that circumvents the normal virtual screen clipping. Is there a way to do this already? If not, do you think that such an approach would be a feasible and acceptable way forward, or is virtual screen input clipping fundamentally baked in the current core design and assumptions? Thanks! -- v3: winewayland.drv: Avoid resizing fullscreen windows. winewayland.drv: Rename wayland_surface_configure_is_compatible for consistency. winewayland.drv: Use surface geometry to satisfy state size constraints. winewayland.drv: Handle application-initiated fullscreen state. winewayland.drv: Store and use the latest window config for a wayland_surface. winewayland.drv: Explicitly set the visible window rectangle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4014

3 12

[PATCH v2 0/1] MR4052: secur32/tests: Skip the tests instead of crashing if Kerberos is not supported.
by Francois Gouget (＠fgouget) Oct. 13, 2023

Oct. 13, 2023

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55555 -- v2: secur32/tests: Skip the tests instead of crashing if Kerberos is not supported. https://gitlab.winehq.org/wine/wine/-/merge_requests/4052

3 3

[PATCH v4 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) Oct. 13, 2023

Oct. 13, 2023

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v4: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

3 8

[PATCH 0/1] MR4087: winemac.drv: Fix redundant calls to [NSCursor set].
by Brendan Shanks (＠bshanks) Oct. 13, 2023

Oct. 13, 2023

Since `self.cursorFrames` is a copy property, its pointer value will only equal `frames` when both are nil. Also return early from the function if the array contents are equivalent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4087

2 1

[PATCH v3 0/6] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) Oct. 13, 2023

Oct. 13, 2023

-- v3: winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_start. winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Introduce link_src_to_sink. winegstreamer: Use NTSTATUS value in wg_muxer_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

2 6

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) Oct. 13, 2023

Oct. 13, 2023

> So I copied and modified a version-check from dlls/schedsvc/rpcapi.c to skip the tests on early winversions. There are still test failures but they seem to happen in ShouldSystemUseDarkMode. That looks reasonable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48599

1 0

Re: [PATCH v5 0/8] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Nikolay Sivov (＠nsivov) Oct. 12, 2023

Oct. 12, 2023

We have a number of debugstr_an(..., 4) used for the same purpose in different modules. It will give different output if replaced with fourcc helper, because of isprint(), but still might be worth considering. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994#note_48597

1 0

Re: [PATCH v3 0/1] MR4044: propsys: Implement PropVariantToUInt32WithDefault - approved
by Alexandre Julliard (＠julliard) Oct. 12, 2023

Oct. 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4044

1 0