June 2023 - Wine-GitLab - list.winehq.org

[PATCH v9 0/4] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) July 11, 2023

July 11, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v9: server: Use *at syscalls to implement temporary chmod behaviour server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

7 23

[PATCH 0/1] MR241: vkd3d-shader/spirv: Add support for VKD3DSIM_LINEAR_NOPERSPECTIVE_SAMPLE interpolation qualifier.
by Andrey Gusev (＠agusev) July 10, 2023

July 10, 2023

Used by F1 2018. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/241

5 5

[PATCH 0/1] MR253: vkd3d-shader/hlsl: Skip unallocated variables when looking for reservation conflicts.
by Zebediah Figura (＠zfigura) July 10, 2023

July 10, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/253

4 4

[PATCH v4 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo.
by Victor Hermann Chiletto (＠vitorhnn) July 9, 2023

July 9, 2023

This MR attempts to bring Wine's handling of `setlocale` and `_create_locale` more in line with the behavior of native >= `msvcr110`. It does this by replacing the usage of the LCID based `GetLocaleInfo` with the sname based `GetLocaleInfoEx`. `GetLocaleInfo` doesn't support neutral locales, even on native, which causes problems with neutral Chinese locales like `zh-Hans` and `zh-Hant`. It also improves the accuracy of the internal `__lc_locale_name_func`, as tests indicate that it returns `LOCALE_SNAME`s instead of ISO 639 language names. Potential future improvements: * Modifying the generation of the `pclmap` and `pcumap` fields of `threadlocaleinfostruct` to work on WCHARs. * I've done some changes to `__thread_data` which make it not fully match native, I'll submit a follow up which fixes this. -- v4: make_unicode: rename Hong Kong SAR China to Hong Kong SAR to match native behavior. msvcrt: Use GetLocaleInfoEx to compare locale info. msvcrt: Remap synonyms to snames. msvcrt: Skip exhaustive locale search with valid snames. msvcrt: Convert locale_to_LCID to snames. msvcrt: Use snames instead of LCIDs in create_locinfo. msvcr120/tests: Check ___lc_locale_name_func with neutral Chinese locales. msvcr110/tests: Add tests for new setlocale behaviors. https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

3 13

[PATCH v2 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) July 8, 2023

July 8, 2023

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v2: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. kernelbase: Implement URL_UNESCAPE_AS_UTF8 for UrlUnescapeW(). shlwapi/tests: Test UrlUnescapeW() with independent data. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

4 6

[PATCH v3 0/2] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens.
by Conor McCarthy (＠cmccarthy) July 7, 2023

July 7, 2023

-- v3: vkd3d-shader/tpf: Read complete swizzle/mask info for dst params. vkd3d-shader/tpf: Read complete swizzle/mask info for src params. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

4 9

[PATCH 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)
by Fabian Maurer (＠DarkShadow44) July 6, 2023

July 6, 2023

When there are no caches, this variable would be uninitialized. Reported by clang-scan. Not sure if that can ever happen, but IMHO initializing doesn't do harm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

4 4

[PATCH v4 0/2] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu July 5, 2023

July 5, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v4: win32u: Don't clip fullscreen windows while capturing mouse pointer. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

2 6

[PATCH 0/21] MR221: Draft: vkd3d: Implement tiled resources
by Conor McCarthy (＠cmccarthy) July 5, 2023

July 5, 2023

Depends on branch tiled_resource1, MR 216. The first new commit is "Add tests for GetResourceTiling()." -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/221

2 22

[PATCH 0/6] MR3139: mf/session: Introduce new asynchronous MFT wrapper.
by Rémi Bernon July 5, 2023

July 5, 2023

This is the first part of a series implementing an asynchronous MFT wrapper around the synchronous session transforms. The idea is to use the async MFT behavior for all the session transforms. I believe this is generally useful, and goes in the direction of support native async MFT, although there is none at the moment, and it will also improve the behavior of the session with decoder transforms. These MFT do not generate a sample for each input samples, and may require more input to be requested. Using the async MFT behavior, we would generate METransformInputNeeded events when appropriate, and the session would react to them and request more samples from upstream. Similarly, producing output will trigger METransformOutputAvailable events, and the session can react to these events and push the samples downstream if there were requested, or queue them. Moreover, for very large video decoding or video processing, the synchronous transform may be performing slowly, and this currently blocks the session callbacks, causing stutter in the playback. Using the async MFT, we can process samples asynchronously, in the multi threaded queue. The complete async_transform implementation can be seen in the https://gitlab.winehq.org/rbernon/wine/-/commits/mr/mf-async-transform branch. I also have a local tree with fully working decoder MFTs, but it requires more changes elsewhere and some media source refactor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3139

3 11