July 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) Sept. 10, 2023

Sept. 10, 2023

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

4 6

[PATCH 0/1] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) Sept. 9, 2023

Sept. 9, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 6

[PATCH v3 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) Sept. 8, 2023

Sept. 8, 2023

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: winebuild: Zero space between Wine signature and PE header in "builtin" files. https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

3 8

[PATCH v3 0/10] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) Sept. 6, 2023

Sept. 6, 2023

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v3: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

3 17

[PATCH 0/2] MR535: Draft: winebus: implement BusQueryContainerID for USB devices when using bus_udev
by Claire (＠ClearlyClaire) Sept. 4, 2023

Sept. 4, 2023

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. While MRs !359 and !360 implement getting the ContainerID of the IMMDevice, this MR implements getting the ContainerID from the HID device. As for !360, I marked this MR as a draft because I understand that the way the ��GUID�� is generated is far from ideal. Furthermore, there is code duplication with !360 in the way the container's sysfspath is found and how a GUID is generated from it, so moving that part elsewhere would make sense. But as for !360, I think I will need help with those tasks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/535

4 4

[PATCH 0/1] MR3125: include: Use visibility hidden attribute on w64-mingw32-clang.
by Alex Henrie (＠alexhenrie) Sept. 1, 2023

Sept. 1, 2023

w64-mingw32-gcc does not support it, but w64-mingw32-clang does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3125

4 4

[PATCH 0/1] MR3255: win32u: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 31, 2023

Aug. 31, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3255

4 6

[PATCH v8 0/6] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Conor McCarthy (＠cmccarthy) Aug. 29, 2023

Aug. 29, 2023

-- v8: vkd3d-shader/dxil: Implement DX instruction StoreOutput. vkd3d-shader/dxil: Declare shader outputs. vkd3d-shader/dxil: Implement the DXIL CALL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283

3 17

[PATCH 0/1] MR3132: vbscript: Coerce to VT_BOOL when evaluating jump conditions.
by Nikolay Sivov (＠nsivov) Aug. 29, 2023

Aug. 29, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3132

4 10

[PATCH v6 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) Aug. 29, 2023

Aug. 29, 2023

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v6: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

4 6