February 2024 - Wine-GitLab

Re: [PATCH v2 0/1] MR5046: advapi32: CryptEnumProviders doesn't return pdwProvType when szProvName is NULL.
by Hans Leidekker (＠hans) Feb. 20, 2024

Feb. 20, 2024

Hans Leidekker (@hans) commented about dlls/advapi32/crypt.c: > } > > RegEnumKeyExW(hKey, dwIndex, provNameW, pcbProvName, NULL, NULL, NULL, NULL); > + > + if (pdwProvType) > + { > + HKEY hSubkey; > + DWORD size = sizeof(DWORD); > + > + RegOpenKeyW(hKey, provNameW, &hSubkey); > + RegQueryValueExW(hSubkey, L"Type", NULL, NULL, (BYTE*)pdwProvType, &size); You should check these calls for failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5046#note_62022

1 0

Re: [PATCH v2 0/1] MR5046: advapi32: CryptEnumProviders doesn't return pdwProvType when szProvName is NULL.
by Hans Leidekker (＠hans) Feb. 20, 2024

Feb. 20, 2024

Hans Leidekker (@hans) commented about dlls/advapi32/crypt.c: > } > > RegEnumKeyExW(hKey, dwIndex, provNameW, pcbProvName, NULL, NULL, NULL, NULL); > + > + if (pdwProvType) pdwProvType doesn't appear to be optional. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5046#note_62021

1 0

Re: [PATCH v2 0/1] MR5046: advapi32: CryptEnumProviders doesn't return pdwProvType when szProvName is NULL.
by Hans Leidekker (＠hans) Feb. 20, 2024

Feb. 20, 2024

Hans Leidekker (@hans) commented about dlls/advapi32/tests/crypt.c: > ERROR_NO_MORE_ITEMS, GetLastError()); > > /* check expected versus actual values returned */ > + type = -1; > + providerLen = -1; > result = pCryptEnumProvidersA(dwIndex, NULL, 0, &type, NULL, &providerLen); > - ok(result && providerLen==cbName, "expected %i, got %i\n", (int)cbName, (int)providerLen); > + ok(result, "expected TRUE, got %ld\n", result); > + ok(type==dwType, "expected %ld, got %ld\n", dwType, type); > + ok(providerLen==cbName, "expected %i, got %i\n", (int)cbName, (int)providerLen); Please use spaces around operators, format DWORD with %lu and remove the casts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5046#note_62020

1 0

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Henri Verbeet (＠hverbeet) Feb. 20, 2024

Feb. 20, 2024

> I guess `hlsl_types_are_equal()` should be updated too? I added a check for HLSL_TYPE_UAV and "rasteriser_ordered", but I notice we don't compare formats there either for UAVs. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_62016

1 0

[PATCH v7 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) Feb. 20, 2024

Feb. 20, 2024

-- v7: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

3 7

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Giovanni Mascellani (＠giomasce) Feb. 20, 2024

Feb. 20, 2024

> We probably should, but I think we're also allowed to just clamp to \[0, 1\]. It's not immediately clear to me whether a corresponding caps bit exists for this in d3d12. If, as it seems, there isn't one, then I think `DepthBoundsTestSupported` should be intended as advertising support for an unrestricted range, so shouldn't be set unless we're able to uphold to that promise (i.e., `VK_EXT_depth_range_unrestricted` is available). Why is clamping to \[0, 1\] a good solution? The application is likely to misrender if we change the requested parameters under its feet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_62012

1 0

[PATCH 0/5] MR5121: winevulkan: Move NULL window handling out of winex11.
by Rémi Bernon Feb. 20, 2024

Feb. 20, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5121

1 6

[PATCH v3 0/4] MR645: vkd3d-shader/dxil: Implement DX intrinsics AtomicBinOp and AtomicCompareExchange.
by Conor McCarthy (＠cmccarthy) Feb. 20, 2024

Feb. 20, 2024

-- v3: vkd3d-shader/dxil: Implement DX intrinsic AtomicCompareExchange. vkd3d-shader/dxil: Implement DX intrinsic AtomicBinOp. tests/shader-runner: Add tests for UAV atomic ops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/645

4 7

[PATCH v13 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) Feb. 20, 2024

Feb. 20, 2024

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v13: vkd3d-shader/hlsl: Implement atan and atan2. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

3 3

[PATCH 0/9] MR5096: sapi: Implement some ISpeechVoice methods.
by Shaun Ren (＠shaunren) Feb. 20, 2024

Feb. 20, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5096

3 10