winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
757 discussions
Start a n
N
ew thread
New commits on branch master
by Alexandre Julliard
05 Nov '07
05 Nov '07
URL:
http://source.winehq.org/git/wine.git/?a=commit;h=94799c3cc72d1189ae13379a7…
Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Nov 5 12:35:29 2007 +0100 kernel32: Fix the image size in a test to avoid a BSOD on Windows XP SP1. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83e2f4426845ef73a8eef6a52…
Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Nov 5 12:35:18 2007 +0100 winex11: Fix compilation on systems that don't support either nameless unions or nameless structs. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7b00b60cf5e7b9ac829983bdf…
Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Nov 5 12:35:10 2007 +0100 user32: Fix compilation on systems that don't support either nameless unions or nameless structs. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=04dc115b547b17464824559fc…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Nov 5 11:10:07 2007 +0000 rpcrt4: Handle FC_IGNORE in the base type functions. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b8af667739cd40906f502825b…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Nov 5 11:09:52 2007 +0000 include: Fix a typo in midles.h. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6f44627b047674552ccaf61e6…
Author: Nigel Liang <ncliang(a)gmail.com> Date: Sat Nov 3 18:24:49 2007 -0700 wininet: Release object in HttpSendRequestExW before return on error. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=73e2ff5901f224f20c0e847af…
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Nov 3 17:24:34 2007 +1100 msxml: Fix a memory leak. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=597a77f7d600fa6190d53cc65…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 10:04:52 2007 +0100 d3dx8: Fix the number and the type of variables in d3dx8.spec. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4bbe41bb5e51c16a058905aac…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:59:33 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveOrthoLH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=23d9da1eb9d167d8d2eec1435…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:57:33 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveOrthoRH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=515d7101cefd465998852552e…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:54:39 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveOffCenterLH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=110fcb492633089e2beb24077…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:52:45 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveOffCenterRH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bc386fd753e748d9442fcc844…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:50:53 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveFovLH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f45e991c784cd71ce31473531…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:48:43 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveFovRH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bde962f0ff734a6c84aa51cca…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:46:37 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveLH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5154b203b0e5af6190f541234…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:43:11 2007 +0100 d3dx8: Implement D3DXMatrixPerspectiveRH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=324aad45454a2c51742750a32…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:39:30 2007 +0100 d3dx8: Implement D3DXMatrixLookAtLH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8d996a22a888b7ba9232dd20e…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:33:51 2007 +0100 d3dx8: Implement D3DXMatrixLookAtRH. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=15f029a5eedc52f3cab998ec9…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:30:14 2007 +0100 d3dx8: Implement D3DXMatrixRotationYawPitchRoll. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=11bd418aa20dcfe04f69976bd…
Author: David Adam <David.Adam(a)math.cnrs.fr> Date: Sat Nov 3 09:26:14 2007 +0100 d3dx8: Implement D3DXMatrixRotationQuaternion. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ebb2fa1aa3639b21a88a8839c…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Nov 3 17:02:49 2007 +0000 shell32: Constify some variables. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1a0b23cd7dd940da57d881e15…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:50:02 2007 -0500 msi: Implement the CCPSearch standard action. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c1cf26997cdf491642b2086a…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:49:07 2007 -0500 msi: Explicitly check the returned value against -1 as the variable is unsigned. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3a5178e900bd0e12875d00628…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:48:15 2007 -0500 msi: Don't update a table entry when applying a transform if the string value is the same. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9d71238a16a60e6295eec743b…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:47:12 2007 -0500 msi: Fix the location used to write the user's environment variables. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2df062182a12c25c5a4c607b0…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:45:32 2007 -0500 msi: Remove an unused parameter. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=556a01d7c5077fb9708c2ab91…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:44:41 2007 -0500 msi: Use a magic constant to silence signedness comparison warnings. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=546bcef0bbdf974f18a260a40…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:43:52 2007 -0500 msi: MsiQueryProductState returns INSTALLSTATE, not UINT. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b03082c397533cdeeb8da6bd9…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:41:22 2007 -0500 msi: MsiQueryFeatureState and MsiUseFeatureEx return INSTALLSTATE, not UINT. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=37895faaa8f3e06f6e1489834…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:40:25 2007 -0500 msi: MsiViewGetError returns MSIDBERROR, not UINT. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=76275bea098e8994e2fc2f87f…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:39:30 2007 -0500 msi: Remove an unused parameter. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cf8e9e3311b611dda88d617fa…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:37:44 2007 -0500 msi: Remove an unused parameter. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bb54ed1335ed2847aa42fc624…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:36:49 2007 -0500 msi: Fix the sign of an index variable. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1a896348d56c0261a7280d0cc…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:36:01 2007 -0500 msi: Remove a legacy error check. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=35a6782d7ba96d73874356d36…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:35:13 2007 -0500 msi: Test and implement the MSIMODIFY_DELETE command. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=341d1fa7b5ec3593131286dd2…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:34:23 2007 -0500 msi: Initialize a handle in case MsiGetSummaryInformation fails. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=21bde9d974cad3efc2b1067b7…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:33:37 2007 -0500 msi: Fix the location used to read machine context source list info. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=21619964dab4f1a4f351c0870…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:32:45 2007 -0500 msi: szUserSid must be NULL if context is MSIINSTALLCONTEXT_MACHINE. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=14d439c8634db2f06b49fd2a4…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:32:00 2007 -0500 msi: Handle the MSIINSTALLCONTEXT_USERMANAGED context. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3d5b3ef90311095383f2a9095…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:30:38 2007 -0500 msi: Reimplement MsiSourceListAddSourceEx to handle reordering the source list. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d9a8f0b5fe0b33d1a0a7d909e…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:29:47 2007 -0500 msi: The options must include a source type. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7fe6aad7fa54a9e9e0bdb8e69…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:27:39 2007 -0500 msi: An empty source is an invalid parameter. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dde89244e5af63f1b2bd435ae…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:20:09 2007 -0500 msi: Append a slash to network and url sources. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=798429f9caa3b235937cf8a19…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:26:34 2007 -0500 msi: Validate the product code. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=861ae27a4f26455d5a9e3d041…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:19:13 2007 -0500 msi: Return the error from OpenSourceKey. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=266ee0f5718755ca224bd1d11…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:16:13 2007 -0500 msi: Add tests for MsiSourceListAddSourceEx. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=22c10da044d872878932b4fa4…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:14:49 2007 -0500 msi: Don't create the product source key when adding a source. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=44e1c7d79b2a61d9772b07927…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:12:56 2007 -0500 msi: Implement MsiSourceListAddSourceExA. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=405d0be4f79d4468ac1841831…
Author: James Hawkins <truiken(a)gmail.com> Date: Mon Nov 5 04:11:47 2007 -0500 msi: do_query is supposed to fail, so don't release a handle that is never initialized. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3cfad1fbf35b77d5415ba4b46…
Author: Alex Villacís Lasso <a_villacis(a)palosanto.com> Date: Sun Nov 4 15:06:17 2007 -0500 riched20: Fix detection of CFE_LINK on WinXP-SP2. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ba2e3f57d21ce02ea89cd42f1…
Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Nov 4 09:11:49 2007 -0700 dinput: Add stub for DIPROP_AUTOCENTER property. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7fd3fe59e43c82c5031dd5e76…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sun Nov 4 15:57:23 2007 -0800 wsock32: Don't use HEAP_ZERO_MEMORY for memory that's fully initialized anyway. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=44c64aef31f0e21e300e99442…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sun Nov 4 15:48:36 2007 -0800 wsock32: Correctly handle the case where a table size is 0 in IP_MIB_TABLE_ENTRY_ID. Spotted by Gerald Pfeifer. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fdc607d0b46d3342c33344d64…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Nov 4 17:26:58 2007 +0100 shdocvw: Fixed typos. Found by Detlef Riekenberg. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=48d393bdfef5655063a7fd98d…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Nov 4 17:09:20 2007 +0100 urlmon: Added https protocol class factory stub implementation. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0fa989827eecff61c40542cae…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Nov 4 12:40:00 2007 +0100 shell32: Update Norwegian Bokmål translation. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=559b38c34ce9e43e623be74c3…
Author: Dan Kegel <dank(a)kegel.com> Date: Sun Nov 4 06:26:06 2007 -0800 cabinet: FCICreate: Initialize oldCCAB. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c2330178eba94ea96db8a1bb0…
Author: Dan Kegel <dank(a)kegel.com> Date: Sat Nov 3 16:46:46 2007 -0700 cabinet: FCIAddFile: Set defaults in case callback doesn't set some fields. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c473f386424807ad9d08b6e8…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 13:05:06 2007 -0700 comdlg32: Grammar fixes. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0a5b6c858eec44da678ed92dc…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 13:04:46 2007 -0700 comdlg32: Implement OFN_CREATEPROMPT checking. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=deadc6cf7b56fdc1ea66548ee…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 12:25:17 2007 -0700 crypt32: Don't define function pointers that are NULL (and unused). URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3d1ba2ab9d4808587648ca09b…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 12:23:06 2007 -0700 crypt32: Don't store a redundant copy of data in the message store. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8b17846d6abdc013817a6f3a0…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 12:09:32 2007 -0700 crypt32: Initialize a variable. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9f808670ac418e03432779660…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sun Nov 4 17:25:44 2007 +0100 wined3d: UnlockRect regression fix. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d39abb766797de0c3a13e9f3d…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sat Nov 3 15:14:03 2007 +0100 wined3d: Only use p8 conversion on render targets. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1f340164017ede7bc4a2a4a3e…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sat Nov 3 14:28:06 2007 +0100 wined3d: Fix LockedRect regression. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c7683ee4a3bfb05498f60c105…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sat Nov 3 01:04:36 2007 +0100 wined3d: Fix glsl detection bug. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=58b030c270e68c4e130a7decb…
Author: Kai Blin <kai.blin(a)gmail.com> Date: Sat Nov 3 08:45:12 2007 +0100 ws2_32: Map SO_REUSEADDR. BSD socket SO_REUSEADDR is not a complete match, but features like "allow binding to a port immediately after closing it" seem to be compatible. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bb4ba8e21b699889112cd39a4…
Author: Kai Blin <kai.blin(a)gmail.com> Date: Sat Nov 3 08:45:22 2007 +0100 netapi32: Fix valgrind warnings. For now, those pointers are always null, anyway. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b0bc8e58def27bdf7d4c376fb…
Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Fri Nov 2 15:25:26 2007 -0700 widl: Don't output a void conformance for NdrClearOutParameters. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8d15820f7934551a66005bf9c…
Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Fri Nov 2 15:24:08 2007 -0700 widl: Handle pointers to conformant arrays (e.g., "[size_is(, n)] int **p; "). URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8caa325eb7e5225a042622d8f…
Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Fri Nov 2 15:22:47 2007 -0700 rpcrt4: Initialize allocated pointers to NULL in PointerUnmarshall. This patch initializes allocated pointers in PointerUnmarshall since later code checks the value for NULL (specifically, NdrConformantArrayUnmarshall). URL:
http://source.winehq.org/git/wine.git/?a=commit;h=eaffc0a0da2b1fbf607423574…
Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Fri Nov 2 15:21:51 2007 -0700 rpcrt4/tests: Initialize memory in the get_name test. This initializes the memory for an [in] parameter. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0d016254a0cb5f61d84c8da65…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 21:43:55 2007 +0100 wined3d: Don't test D3DDEVICE surfaces in dsurface tests. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4bd65f2a667d51e9bb1bab452…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Nov 1 00:50:07 2007 +0100 d3d8: Initialize the vertex decl when allocating it. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d97e3fd0862425c72cc25460b…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 21:28:11 2007 +0100 wined3d: Move texture->sysmem specific code into its special function. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4678cd75befd62fb8fa67ecab…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 22:23:22 2007 +0100 wined3d: Move drawable->sysmem specific code to its special function. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2d11b509b403a84483f2cadec…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 21:08:20 2007 +0100 wined3d: Move sysmem->drawable specific blit code out of LoadLocation. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1367e007501e5fa24a4863773…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 21:31:09 2007 +0100 wined3d: Remove a wrong return. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7c97b8019350bca4081d87bef…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 21:30:50 2007 +0100 wined3d: Remove an unneeded check. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e15b6096c620546a1fff433da…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Nov 2 19:51:53 2007 +0100 iexplore: Added self-registration code. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=151f18e69ca6edb65427bb279…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 19:10:09 2007 +0000 include: Add a new header file: midles.h. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c4a1a081a92f5a95aa1b08835…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 19:09:23 2007 +0000 rpcrt4: Factorise out the argument processing from NdrStubCall2 into two functions. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83bc80ada0af3a8e1531e65e9…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 19:09:07 2007 +0000 rpcrt4: Move some type definitions from ndr_stubless.c to ndr_stubless.h. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3eac5b4e5958dee105a4ef493…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 19:08:57 2007 +0000 rpcrt4: Add a small bit of documentation as to what NdrStubCall2 does. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d1696ff5feaf290db27335730…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 19:08:21 2007 +0000 include: Take care to not declare CtxtHandle and PCtxtHandle more than once when including both sspi.h and wincred.h. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6b213042480602b81303eec17…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Nov 2 19:53:02 2007 +0100 mshtml: AsyncOpen code clean up. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cd07f7282467a84b57e319d7a…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Nov 2 19:52:45 2007 +0100 mshtml: More test fixes. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d8acdcc2b453092d4ea2a7e7a…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Nov 2 09:03:32 2007 -0700 url: Fix prototype of FileProtocolHandlerA. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f49880c6af89837828185aedc…
Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Nov 2 11:55:26 2007 +0000 include: Add a couple more interfaces. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=381e48ec138f5d3587baea18c…
Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Nov 2 11:54:03 2007 +0000 inetcomm: Add two missing member functions. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=54ab69c4f5b93fa74f0402d8a…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:53:26 2007 +0000 inetcomm: Add a stub implementation of the IMimeMessage object returned from MimeOleCreateMessage. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=78c90082a57421926f26ffc28…
Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Nov 2 11:52:27 2007 +0000 inetcomm: Add a stub for MimeOleCreateVirtualStream. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=70705829dd2dd8415fe348fb2…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:51:23 2007 +0000 inetcomm: Include mimeole.h and fix the type of MimeOleCreateMessage. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83efdf300cc69791c2aa744b6…
Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Nov 2 11:50:47 2007 +0000 include: Add a few defines and fill out IMimeMessageCallback. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fe99768dc9707b81f1a324ef9…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:50:16 2007 +0000 include: Add mimeole.idl. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=abd95840a58635a51e4804042…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:49:29 2007 +0000 inetcomm: Add stubs for MimeOleSetCompatMode and MimeOleCreateMessage. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3ace5e53d9dfbeed459717d06…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:43:29 2007 +0000 inetcomm: Call InternetTransport_RegisterClass and UnregisterClass on process attach and detach respectively, to register a window class and initialize Winsock. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cef74e263f49833441acda00c…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:42:52 2007 +0000 inetcomm: Use InternetTransport_ChangeStatus in InternetTransport_DropConnection so that the callback gets called. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a3a2789f666e6c8384ad7f7c8…
Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Nov 2 13:46:13 2007 +0000 inetcomm: Add self-registration code. Based on a patch by Rob Shearman. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=994014b15a2a339df40f99414…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:39:03 2007 +0000 inetcomm: Add a framework for connecting to a server and sending/receiving data asynchronously with callbacks being called in the context of the original thread, using window messages. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=08050758de2f654d4bc13f7e5…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 14:15:44 2007 +0000 include: Add imnact.idl and imnxport.idl. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a54a990b3b68a126e02ef6805…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 2 15:26:49 2007 +0100 server: Allow to specify the class name instead of the atom to find a window. URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1fc461f98b1af3f25e261921b…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 2 15:16:25 2007 +0100 server: Allow to specify the class name instead of the atom to create a window.
1
0
0
0
Alexander Nicolaysen Sørnes : version: Small improvements to tables
by Chris Morgan
05 Nov '07
05 Nov '07
Module: appdb Branch: master Commit: f851d9378f026acacb7904db46cec9a44cf5545c URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=f851d9378f026acacb7904db…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Nov 4 22:32:19 2007 +0100 version: Small improvements to tables --- include/version.php | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/include/version.php b/include/version.php index ea8c121..3984a1e 100644 --- a/include/version.php +++ b/include/version.php @@ -1475,7 +1475,7 @@ class version { $oTableRow->AddTextCell("Vendor"); $oTableRow->AddTextCell("Application"); $oTableRow->AddTextCell("Version"); - $oTableRow->AddTextCell("Has Super Maintainer"); + $oTableRow->AddTextCell("Has Maintainer"); return $oTableRow; } @@ -1585,11 +1585,7 @@ class version { $oApp = new application($this->iAppId); $oVendor = new vendor($oApp->iVendorId); - $aSuper_maintainers = Maintainer::getSuperMaintainersUserIdsFromAppId($this->iAppId); - if($aSuper_maintainers) - $bHasSuperMaintainer = true; - else - $bHasSuperMaintainer = false; + $aMaintainers = Maintainer::getSuperMaintainersUserIdsFromAppId($this->iAppId); $oTableRow = new TableRow(); $oTableRow->AddTextCell(print_date(mysqldatetime_to_unixtimestamp($this->sSubmitTime))); @@ -1597,7 +1593,7 @@ class version { $oTableRow->AddTextCell($oVendor->objectMakeLink()); $oTableRow->AddTextCell($oApp->objectMakeLink()); $oTableRow->AddTextCell($this->sName); - $oTableRow->AddCell(new TableCell($bHasSuperMaintainer ? "Yes" : "No")); + $oTableRow->AddTextCell(sizeof($aMaintainers) ? "YES" : "No"); $oOMTableRow = new OMTableRow($oTableRow); return $oOMTableRow;
1
0
0
0
Alexander Nicolaysen Sørnes : version: Properly handle missing test results
by Chris Morgan
05 Nov '07
05 Nov '07
Module: appdb Branch: master Commit: 5c6b3bb45ede3a31b0c388dd5decb3bb2b1ebb66 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=5c6b3bb45ede3a31b0c388dd…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Nov 4 23:09:12 2007 +0100 version: Properly handle missing test results --- application.css | 6 ++++++ include/html.php | 14 ++++++++++++++ include/version.php | 45 ++++++++++++++++++++++++++++++++++----------- 3 files changed, 54 insertions(+), 11 deletions(-) diff --git a/application.css b/application.css index 15b99dc..0746379 100644 --- a/application.css +++ b/application.css @@ -63,6 +63,12 @@ div.info_contents { padding:10px; background-color: #eee; } div.title_class { font-weight: bold; border-bottom: 1px solid; padding: 4px; font-size: 140%; background-color: #ddd; } +/* Classes for a note box */ +div.note_container { margin:6px; border: 1px solid; } +div.note_body { padding: 10px; background-color: #ffe732; } +div.note_title { font-weight: bold; border-bottom: 1px solid; padding: 4px; + font-size: 140%; background-color: #ffc004; } + /* classes for the main page */ div.rating_header { padding: 8px; } div.rating_title { padding-bottom: 4px; font-weight: bold; font-size: 160%; } diff --git a/include/html.php b/include/html.php index e8cdfdb..b0aa6c8 100644 --- a/include/html.php +++ b/include/html.php @@ -286,4 +286,18 @@ function make_inx_option_list($varname, $inx = null) } +/* Displays a note box */ +function html_note($shTitle, $shBody) +{ + $shRet = '<div class="note_container">'; + $shRet .= '<div class="note_title">'; + $shRet .= $shTitle; + $shRet .= '</div>'; + $shRet .= '<div class="note_body">'; + $shRet .= $shBody; + $shRet .= '</div></div>'; + + return $shRet; +} + ?> diff --git a/include/version.php b/include/version.php index 3b9bd2f..ea8c121 100644 --- a/include/version.php +++ b/include/version.php @@ -987,11 +987,7 @@ class version { ////////////////////// // Show test data - echo "<div class='info_container'>\n"; - echo "\t<div class='title_class'>\n"; - echo "\t\tSelected test results <small><small>(selected in 'Test Results' table below)</small></small>\n"; - echo "\t</div>\n"; /* Set if the use chose to display a particular test report */ if($iTestingId) @@ -999,18 +995,45 @@ class version { else if($this->iVersionId) /* Let's query for the latest rest report */ { $iTestingId = testData::getNewestTestIdFromVersionId($this->iVersionId); - $oTest = new testData($iTestingId); + + if($iTestingId) /* We want all entries to have test data, but old versions might lack + it, or data may have been deleted */ + $oTest = new testData($iTestingId); } else /* Perhaps we have a cached entry? There should be */ { $aTests = $this->getTestResults(); - $oTest = $aTests[0]; + + if(sizeof($aTests)) /* ... but we cannot be certain */ + $oTest = $aTests[0]; } - echo "<div class='info_contents'>\n"; - $oTest->ShowTestResult(); - echo "</div>\n"; + if($oTest) + { + echo "<div class='info_container'>\n"; - echo "</div>\n"; // end the 'info_container' div + echo "\t<div class='title_class'>\n"; + echo "\t\tSelected test results <small><small>(selected in 'Test Results' table below)</small></small>\n"; + echo "\t</div>\n"; + + echo "<div class='info_contents'>\n"; + + $oTest->ShowTestResult(); + + echo "</div>\n"; + + echo "</div>\n"; + } else /* Show a note saying that no test results are present, + and encourage the user to take action */ + { + echo html_note('No Test Results', + 'This version has no test results, please consider submitting some.<br />'. + 'They may be part of the '. + 'version or application description. If they are, please '. + 'consider becoming a maintainer and remove them, submitting '. + 'a proper test report instead.'); + } + + // end the 'info_container' div // end show test data ///////////////////// @@ -1020,7 +1043,7 @@ class version { if($oTest->iTestingId) { $oTest->ShowVersionsTestingTable($this->objectMakeUrl()."&iTestingId=", 5); - } else /* We are previewing the version */ + } else if($oTest) /* We are previewing the version */ { $oTable = $oTest->CreateTestTable(); $oTable->AddRow($oTest->CreateTestTableRow(0, ""));
1
0
0
0
Rob Shearman : inetcomm: Add stub implementation of inetcomm.dll.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: beab2c17e9218e069abf6b464f61467a5ccd0558 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=beab2c17e9218e069abf6b464…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Fri Nov 2 11:35:34 2007 +0000 inetcomm: Add stub implementation of inetcomm.dll. --- .gitignore | 1 + Makefile.in | 2 + configure | 3 + configure.ac | 1 + dlls/Makefile.in | 5 ++ dlls/inetcomm/Makefile.in | 14 +++++ dlls/inetcomm/inetcomm.spec | 106 +++++++++++++++++++++++++++++++++++++++++ dlls/inetcomm/inetcomm_main.c | 87 +++++++++++++++++++++++++++++++++ 8 files changed, 219 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=beab2c17e9218e069abf6…
1
0
0
0
Christian Eggers : ctapi32: Added wrapper dll for ctapi (CardTerminal API).
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: f89c6de727e2ed222071e1ffacc1481dc50d6eb8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f89c6de727e2ed222071e1ffa…
Author: Christian Eggers <christian(a)p2400.wgnetz.xx> Date: Fri Nov 2 13:46:18 2007 +0100 ctapi32: Added wrapper dll for ctapi (CardTerminal API). --- Makefile.in | 2 + configure | 3 + configure.ac | 1 + dlls/Makefile.in | 1 + dlls/ctapi32/Makefile.in | 12 ++++ dlls/ctapi32/ctapi.h | 107 +++++++++++++++++++++++++++++++ dlls/ctapi32/ctapi32.c | 155 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ctapi32/ctapi32.spec | 3 + 8 files changed, 284 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f89c6de727e2ed222071e…
1
0
0
0
Rok Mandeljc : wnaspi32: Fix controller number validation.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: 47d1fee7fc4964edebbb735fa3f3e111194c4f13 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=47d1fee7fc4964edebbb735fa…
Author: Rok Mandeljc <manrok(a)email.si> Date: Thu Nov 1 08:09:33 2007 +0100 wnaspi32: Fix controller number validation. --- dlls/wnaspi32/winaspi32.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wnaspi32/winaspi32.c b/dlls/wnaspi32/winaspi32.c index 8c76878..438b2a1 100644 --- a/dlls/wnaspi32/winaspi32.c +++ b/dlls/wnaspi32/winaspi32.c @@ -109,7 +109,7 @@ ASPI_OpenDevice(SRB_ExecSCSICmd *prb) } LeaveCriticalSection(&ASPI_CritSection); - if (prb->SRB_HaId > ASPI_GetNumControllers()) + if (prb->SRB_HaId >= ASPI_GetNumControllers()) return -1; hc = ASPI_GetHCforController( prb->SRB_HaId ); @@ -314,8 +314,8 @@ ASPI_ExecScsiCmd(SRB_ExecSCSICmd *lpPRB) DWORD SRB_Status; num_controllers = ASPI_GetNumControllers(); - if (lpPRB->SRB_HaId > num_controllers) { - WARN("Failed: Wanted hostadapter %d, but we have only %d.\n", + if (lpPRB->SRB_HaId >= num_controllers) { + WARN("Failed: Wanted hostadapter with index %d, but we have only %d.\n", lpPRB->SRB_HaId, num_controllers ); return WNASPI32_DoPosting( lpPRB, SS_INVALID_HA );
1
0
0
0
Rok Mandeljc : wnaspi32: Fix Controller -> H/C mapping.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: 3a59ac0829cefece6fa551bf5062af8e1670372a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3a59ac0829cefece6fa551bf5…
Author: Rok Mandeljc <manrok(a)email.si> Date: Thu Nov 1 08:09:10 2007 +0100 wnaspi32: Fix Controller -> H/C mapping. --- dlls/wnaspi32/aspi.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/wnaspi32/aspi.c b/dlls/wnaspi32/aspi.c index e950d7d..11c3f3b 100644 --- a/dlls/wnaspi32/aspi.c +++ b/dlls/wnaspi32/aspi.c @@ -181,7 +181,8 @@ DWORD ASPI_GetHCforController( int controller ) HKEY hkeyScsi, hkeyPort; DWORD i = 0, numPorts; int num_ha = controller + 1; - WCHAR wPortName[11]; + WCHAR wPortName[15]; + WCHAR wBusName[15]; if (RegOpenKeyExW(HKEY_LOCAL_MACHINE, wDevicemapScsi, 0, KEY_QUERY_VALUE | KEY_ENUMERATE_SUB_KEYS, &hkeyScsi) != ERROR_SUCCESS ) @@ -212,7 +213,7 @@ DWORD ASPI_GetHCforController( int controller ) return 0xFFFFFFFF; } - if (RegEnumKeyW(hkeyPort, -num_ha, wPortName, sizeof(wPortName)) != ERROR_SUCCESS) + if (RegEnumKeyW(hkeyPort, -num_ha, wBusName, sizeof(wBusName)) != ERROR_SUCCESS) { ERR("Failed to enumerate keys\n"); RegCloseKey(hkeyPort); @@ -220,7 +221,7 @@ DWORD ASPI_GetHCforController( int controller ) } RegCloseKey(hkeyPort); - return ((--i) << 16) + atoiW(&wPortName[9]); + return (atoiW(&wPortName[9]) << 16) + atoiW(&wBusName[9]); } int SCSI_OpenDevice( int h, int c, int t, int d )
1
0
0
0
Rok Mandeljc : wnaspi32: Do the command dumping only after device has been verified.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: 1161d0e15e6d41c62096b3e442e77115b9aa4e7a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1161d0e15e6d41c62096b3e44…
Author: Rok Mandeljc <manrok(a)email.si> Date: Thu Nov 1 08:08:42 2007 +0100 wnaspi32: Do the command dumping only after device has been verified. --- dlls/wnaspi32/winaspi32.c | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/dlls/wnaspi32/winaspi32.c b/dlls/wnaspi32/winaspi32.c index 0f8e2f9..8c76878 100644 --- a/dlls/wnaspi32/winaspi32.c +++ b/dlls/wnaspi32/winaspi32.c @@ -313,6 +313,18 @@ ASPI_ExecScsiCmd(SRB_ExecSCSICmd *lpPRB) int fd; DWORD SRB_Status; + num_controllers = ASPI_GetNumControllers(); + if (lpPRB->SRB_HaId > num_controllers) { + WARN("Failed: Wanted hostadapter %d, but we have only %d.\n", + lpPRB->SRB_HaId, num_controllers + ); + return WNASPI32_DoPosting( lpPRB, SS_INVALID_HA ); + } + fd = ASPI_OpenDevice(lpPRB); + if (fd == -1) { + return WNASPI32_DoPosting( lpPRB, SS_NO_DEVICE ); + } + /* FIXME: hackmode */ #define MAKE_TARGET_TO_HOST(lpPRB) \ if (!TARGET_TO_HOST(lpPRB)) { \ @@ -345,18 +357,6 @@ ASPI_ExecScsiCmd(SRB_ExecSCSICmd *lpPRB) } ASPI_DebugPrintCmd(lpPRB); - num_controllers = ASPI_GetNumControllers(); - if (lpPRB->SRB_HaId > num_controllers) { - WARN("Failed: Wanted hostadapter %d, but we have only %d.\n", - lpPRB->SRB_HaId, num_controllers - ); - return WNASPI32_DoPosting( lpPRB, SS_INVALID_HA ); - } - fd = ASPI_OpenDevice(lpPRB); - if (fd == -1) { - return WNASPI32_DoPosting( lpPRB, SS_NO_DEVICE ); - } - sg_hd = NULL; sg_reply_hdr = NULL;
1
0
0
0
Rok Mandeljc : wnaspi32: Call ASPI_GetNumControllers() only once.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: 084636c5189d0d2a67985067f6c002441e3ed931 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=084636c5189d0d2a67985067f…
Author: Rok Mandeljc <manrok(a)email.si> Date: Thu Nov 1 08:08:13 2007 +0100 wnaspi32: Call ASPI_GetNumControllers() only once. --- dlls/wnaspi32/winaspi32.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/wnaspi32/winaspi32.c b/dlls/wnaspi32/winaspi32.c index e06bb9b..0f8e2f9 100644 --- a/dlls/wnaspi32/winaspi32.c +++ b/dlls/wnaspi32/winaspi32.c @@ -308,6 +308,7 @@ ASPI_ExecScsiCmd(SRB_ExecSCSICmd *lpPRB) WORD ret; DWORD status; int in_len, out_len; + int num_controllers = 0; int error_code = 0; int fd; DWORD SRB_Status; @@ -343,9 +344,11 @@ ASPI_ExecScsiCmd(SRB_ExecSCSICmd *lpPRB) break; } ASPI_DebugPrintCmd(lpPRB); - if (lpPRB->SRB_HaId > ASPI_GetNumControllers()) { - ERR("Failed: Wanted hostadapter %d, but we have only %d.\n", - lpPRB->SRB_HaId,ASPI_GetNumControllers() + + num_controllers = ASPI_GetNumControllers(); + if (lpPRB->SRB_HaId > num_controllers) { + WARN("Failed: Wanted hostadapter %d, but we have only %d.\n", + lpPRB->SRB_HaId, num_controllers ); return WNASPI32_DoPosting( lpPRB, SS_INVALID_HA ); }
1
0
0
0
Rok Mandeljc : wnaspi32: Degrade ERR of not finding registry entry for a device to TRACE.
by Alexandre Julliard
02 Nov '07
02 Nov '07
Module: wine Branch: master Commit: a2a34bd80bf2244a1065a1b3daca1fda4d845a0f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a2a34bd80bf2244a1065a1b3d…
Author: Rok Mandeljc <rok.mandeljc(a)email.si> Date: Thu Nov 1 08:07:50 2007 +0100 wnaspi32: Degrade ERR of not finding registry entry for a device to TRACE. --- dlls/wnaspi32/aspi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wnaspi32/aspi.c b/dlls/wnaspi32/aspi.c index 07f6bf6..e950d7d 100644 --- a/dlls/wnaspi32/aspi.c +++ b/dlls/wnaspi32/aspi.c @@ -155,7 +155,7 @@ BOOL SCSI_GetDeviceName( int h, int c, int t, int d, LPSTR devstr, LPDWORD lpcbD snprintf(buffer, sizeof(buffer), KEYNAME_SCSI, h, c, t, d); if( RegOpenKeyExA(HKEY_LOCAL_MACHINE, buffer, 0, KEY_ALL_ACCESS, &hkeyScsi ) != ERROR_SUCCESS ) { - ERR("Could not open HKLM\\%s\n", buffer); + TRACE("Could not open HKLM\\%s; device does not exist\n", buffer); return FALSE; }
1
0
0
0
← Newer
1
...
65
66
67
68
69
70
71
...
76
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
Results per page:
10
25
50
100
200