wine-commits June 2010

wine-commits@winehq.org

3 participants
663 discussions

Marcus Meissner : mshtml: Add check for doc_obj being NULL (Coverity).
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: 4169d4dfb89cf2c69fdd2050f43e2491f08be6b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4169d4dfb89cf2c69fdd2050f… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jun 5 09:21:36 2010 +0200 mshtml: Add check for doc_obj being NULL (Coverity). --- dlls/mshtml/htmlwindow.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 1701b53..1ba1101 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -58,7 +58,7 @@ static void window_set_docnode(HTMLWindow *window, HTMLDocumentNode *doc_node) htmldoc_addref(&doc_node->basedoc); } - if(doc_node && window->doc_obj->usermode == EDITMODE) { + if(doc_node && window->doc_obj && window->doc_obj->usermode == EDITMODE) { nsIDOMNSHTMLDocument *nshtmldoc; nsAString mode_str; nsresult nsres;

1 0

Marcus Meissner : shlwapi: Handle NULL ptr return from allocation (Coverity ).
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: f01c43c47b9fe4bbc64874edb0af3bcd30c2b9a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f01c43c47b9fe4bbc64874edb… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jun 3 13:10:17 2010 +0200 shlwapi: Handle NULL ptr return from allocation (Coverity). --- dlls/shlwapi/ordinal.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/shlwapi/ordinal.c b/dlls/shlwapi/ordinal.c index 18295e4..5f332f3 100644 --- a/dlls/shlwapi/ordinal.c +++ b/dlls/shlwapi/ordinal.c @@ -4506,12 +4506,18 @@ INT WINAPIV ShellMessageBoxWrapW(HINSTANCE hInstance, HWND hWnd, LPCWSTR lpText, { const WCHAR *ptr; UINT len = LoadStringW(hInstance, LOWORD(lpText), (LPWSTR)&ptr, 0); + if (len) { szText = HeapAlloc(GetProcessHeap(), 0, (len + 1) * sizeof(WCHAR)); if (szText) LoadStringW(hInstance, LOWORD(lpText), szText, len + 1); } pszText = szText; + if (!pszText) { + WARN("Failed to load id %d\n", LOWORD(lpText)); + __ms_va_end(args); + return 0; + } } else pszText = lpText;

1 0

Nikolay Sivov : comctl32/rebar: Use defined constants as parameters.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: fb1d5310ad22af0f01f5ce26fd648b0ccb643571 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb1d5310ad22af0f01f5ce26f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Jun 7 12:44:38 2010 +0400 comctl32/rebar: Use defined constants as parameters. --- dlls/comctl32/rebar.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/comctl32/rebar.c b/dlls/comctl32/rebar.c index 7a2995c..c254e34 100644 --- a/dlls/comctl32/rebar.c +++ b/dlls/comctl32/rebar.c @@ -2452,7 +2452,7 @@ REBAR_InsertBandT(REBAR_INFO *infoPtr, INT iIndex, LPREBARBANDINFOW lprbbi, BOOL REBAR_DumpBand (infoPtr); REBAR_Layout(infoPtr); - InvalidateRect(infoPtr->hwndSelf, 0, TRUE); + InvalidateRect(infoPtr->hwndSelf, NULL, TRUE); return TRUE; } @@ -2653,7 +2653,7 @@ REBAR_SetBandInfoT(REBAR_INFO *infoPtr, INT iBand, LPREBARBANDINFOW lprbbi, BOOL if (uChanged & (RBBIM_CHILDSIZE | RBBIM_SIZE | RBBIM_STYLE | RBBIM_IMAGE)) { REBAR_Layout(infoPtr); - InvalidateRect(infoPtr->hwndSelf, 0, 1); + InvalidateRect(infoPtr->hwndSelf, NULL, TRUE); } return TRUE; @@ -2798,7 +2798,7 @@ REBAR_ShowBand (REBAR_INFO *infoPtr, INT iBand, BOOL show) } REBAR_Layout(infoPtr); - InvalidateRect(infoPtr->hwndSelf, 0, 1); + InvalidateRect(infoPtr->hwndSelf, NULL, TRUE); return TRUE; } @@ -3399,7 +3399,7 @@ REBAR_SetRedraw (REBAR_INFO *infoPtr, BOOL redraw) if (infoPtr->fStatus & BAND_NEEDS_REDRAW) { REBAR_MoveChildWindows (infoPtr, 0, infoPtr->uNumBands); REBAR_ForceResize (infoPtr); - InvalidateRect (infoPtr->hwndSelf, 0, TRUE); + InvalidateRect (infoPtr->hwndSelf, NULL, TRUE); } infoPtr->fStatus &= ~BAND_NEEDS_REDRAW; }

1 0

Alexander Scott-Johns : msvcrt/test: Add some simple _vsnwprintf_s tests.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: d313c0b98285fa43fd679dc4d6f9d3d1ab60eafd URL: http://source.winehq.org/git/wine.git/?a=commit;h=d313c0b98285fa43fd679dc4d… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Mon Jun 7 03:04:53 2010 +0100 msvcrt/test: Add some simple _vsnwprintf_s tests. --- dlls/msvcrt/tests/printf.c | 61 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c index eaf248b..b48db51 100644 --- a/dlls/msvcrt/tests/printf.c +++ b/dlls/msvcrt/tests/printf.c @@ -812,6 +812,9 @@ static void test_vsnwprintf(void) static int (__cdecl *p__vscprintf)(const char *format, __ms_va_list valist); static int (__cdecl *p__vscwprintf)(const wchar_t *format, __ms_va_list valist); +static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, + size_t count, const wchar_t *format, + __ms_va_list valist); static int __cdecl _vscprintf_wrapper(const char *format, ...) { @@ -852,6 +855,58 @@ static void test_vscwprintf(void) ok( ret == 8, "got %d expected 8\n", ret ); } +static int __cdecl _vsnwprintf_s_wrapper(wchar_t *str, size_t sizeOfBuffer, + size_t count, const wchar_t *format, ...) +{ + int ret; + __ms_va_list valist; + __ms_va_start(valist, format); + ret = p__vsnwprintf_s(str, sizeOfBuffer, count, format, valist); + __ms_va_end(valist); + return ret; +} + +static void test_vsnwprintf_s(void) +{ + const wchar_t format[] = { 'A','B','%','u','C',0 }; + const wchar_t out7[] = { 'A','B','1','2','3','C',0 }; + const wchar_t out6[] = { 'A','B','1','2','3',0 }; + const wchar_t out2[] = { 'A',0 }; + const wchar_t out1[] = { 0 }; + wchar_t buffer[14] = { 0 }; + int exp, got; + + /* Enough room. */ + exp = wcslen(out7); + + got = _vsnwprintf_s_wrapper(buffer, 14, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out7, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); + + got = _vsnwprintf_s_wrapper(buffer, 12, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out7, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); + + got = _vsnwprintf_s_wrapper(buffer, 7, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out7, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); + + /* Not enough room. */ + exp = -1; + + got = _vsnwprintf_s_wrapper(buffer, 6, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out6, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); + + got = _vsnwprintf_s_wrapper(buffer, 2, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out2, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); + + got = _vsnwprintf_s_wrapper(buffer, 1, _TRUNCATE, format, 123); + ok( exp == got, "length wrong, expect=%d, got=%d\n", exp, got); + ok( !wcscmp(out1, buffer), "buffer wrong, got=%s\n", wine_dbgstr_w(buffer)); +} + START_TEST(printf) { test_sprintf(); @@ -863,6 +918,7 @@ START_TEST(printf) p__vscprintf = (void *)GetProcAddress(GetModuleHandle("msvcrt.dll"), "_vscprintf"); p__vscwprintf = (void *)GetProcAddress(GetModuleHandle("msvcrt.dll"), "_vscwprintf"); + p__vsnwprintf_s = (void *)GetProcAddress(GetModuleHandle("msvcrt.dll"), "_vsnwprintf_s"); if (p__vscprintf) test_vscprintf(); @@ -873,4 +929,9 @@ START_TEST(printf) test_vscwprintf(); else win_skip("_vscwprintf not available\n"); + + if (p__vsnwprintf_s) + test_vsnwprintf_s(); + else + win_skip("_vsnwprintf_s not available\n"); }

1 0

Alexander Scott-Johns : msvcrt: Fix spec file.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: d3c00aab839e4042095f86f5079906bb9d611bb7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d3c00aab839e4042095f86f50… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Sun Jun 6 15:51:45 2010 +0100 msvcrt: Fix spec file. --- dlls/msvcrt/msvcrt.spec | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 0cc51f5..604a5ce 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -986,9 +986,9 @@ @ cdecl _vsnprintf_s(ptr long long str ptr) MSVCRT_vsnprintf_s @ cdecl _vsnprintf_s_l(ptr long long str ptr ptr) MSVCRT_vsnprintf_s_l @ cdecl _vsnwprintf(ptr long wstr ptr) MSVCRT_vsnwprintf -@ cdecl _vsnwprintf_l(ptr long wstr ptr ptr) MSVCRT_vsnprintf_l -@ cdecl _vsnwprintf_s(ptr long long wstr ptr) MSVCRT_vsnprintf_s -@ cdecl _vsnwprintf_s_l(ptr long long wstr ptr ptr) MSVCRT_vsnprintf_s_l +@ cdecl _vsnwprintf_l(ptr long wstr ptr ptr) MSVCRT_vsnwprintf_l +@ cdecl _vsnwprintf_s(ptr long long wstr ptr) MSVCRT_vsnwprintf_s +@ cdecl _vsnwprintf_s_l(ptr long long wstr ptr ptr) MSVCRT_vsnwprintf_s_l # stub _vsprintf_l # stub _vsprintf_p # stub _vsprintf_p_l

1 0

Alexander Scott-Johns : msvcrt: The sizeOfBuffer argument of _vsnwprintf_s is measured in wide characters, not bytes.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: d56113cd4fba1822984dc5204cb22875ba2eb2e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d56113cd4fba1822984dc5204… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Mon Jun 7 02:54:14 2010 +0100 msvcrt: The sizeOfBuffer argument of _vsnwprintf_s is measured in wide characters, not bytes. --- dlls/msvcrt/wcs.c | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index 90bc3b8..78e42b2 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -1147,17 +1147,17 @@ int CDECL MSVCRT_vsnwprintf_s_l( MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer { int len, ret; - len = sizeOfBuffer/sizeof(MSVCRT_wchar_t); + len = sizeOfBuffer; if(count!=-1 && len>count+1) len = count+1; ret = vsnwprintf_internal(str, len, format, locale, TRUE, valist); if(ret<0 || ret==len) { - if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer/sizeof(MSVCRT_wchar_t)) { + if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer) { MSVCRT__invalid_parameter( NULL, NULL, NULL, 0, 0 ); *MSVCRT__errno() = MSVCRT_ERANGE; - memset(str, 0, sizeOfBuffer); + memset(str, 0, sizeOfBuffer*sizeof(MSVCRT_wchar_t)); } else str[len-1] = '\0'; @@ -1242,8 +1242,7 @@ int CDECL MSVCRT_swprintf_s(MSVCRT_wchar_t *str, MSVCRT_size_t numberOfElements, int r; __ms_va_start(ap, format); - r = MSVCRT_vsnwprintf_s(str, numberOfElements*sizeof(MSVCRT_wchar_t), - INT_MAX, format, ap); + r = MSVCRT_vsnwprintf_s(str, numberOfElements, INT_MAX, format, ap); __ms_va_end(ap); return r; @@ -1271,8 +1270,7 @@ int CDECL _vscwprintf( const MSVCRT_wchar_t *format, __ms_va_list args ) int CDECL MSVCRT_vswprintf_s(MSVCRT_wchar_t* str, MSVCRT_size_t numberOfElements, const MSVCRT_wchar_t* format, __ms_va_list args) { - return MSVCRT_vsnwprintf_s(str, numberOfElements*sizeof(MSVCRT_wchar_t), - INT_MAX, format, args); + return MSVCRT_vsnwprintf_s(str, numberOfElements, INT_MAX, format, args ); } /********************************************************************* @@ -1281,8 +1279,8 @@ int CDECL MSVCRT_vswprintf_s(MSVCRT_wchar_t* str, MSVCRT_size_t numberOfElements int CDECL MSVCRT_vswprintf_s_l(MSVCRT_wchar_t* str, MSVCRT_size_t numberOfElements, const MSVCRT_wchar_t* format, MSVCRT__locale_t locale, __ms_va_list args) { - return MSVCRT_vsnwprintf_s_l(str, numberOfElements*sizeof(MSVCRT_wchar_t), - INT_MAX, format, locale, args ); + return MSVCRT_vsnwprintf_s_l(str, numberOfElements, INT_MAX, + format, locale, args ); } /*********************************************************************

1 0

Alexander Scott-Johns : include/msvcrt: Define _TRUNCATE; use it in the tests.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: 4e8e2f39c5c028d6812578119885b3edef76d0ec URL: http://source.winehq.org/git/wine.git/?a=commit;h=4e8e2f39c5c028d6812578119… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Sun Jun 6 16:24:09 2010 +0100 include/msvcrt: Define _TRUNCATE; use it in the tests. --- dlls/msvcrt/tests/string.c | 8 ++++---- include/msvcrt/stdlib.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c index f6c0e2c..1a362a1 100644 --- a/dlls/msvcrt/tests/string.c +++ b/dlls/msvcrt/tests/string.c @@ -1215,22 +1215,22 @@ static void test_mbstowcs(void) return; } - err = pmbstowcs_s(&ret, wOut, 6, mSimple, -1/*_TRUNCATE*/); + err = pmbstowcs_s(&ret, wOut, 6, mSimple, _TRUNCATE); ok(err == 0, "err = %d\n", err); ok(ret == 5, "ret = %d\n", (int)ret); ok(!memcmp(wOut, wSimple, sizeof(wSimple)), "wOut = %s\n", wine_dbgstr_w(wOut)); - err = pmbstowcs_s(&ret, wOut, 6, mHiragana, -1/*_TRUNCATE*/); + err = pmbstowcs_s(&ret, wOut, 6, mHiragana, _TRUNCATE); ok(err == 0, "err = %d\n", err); ok(ret == 3, "ret = %d\n", (int)ret); ok(!memcmp(wOut, wHiragana, sizeof(wHiragana)), "wOut = %s\n", wine_dbgstr_w(wOut)); - err = pwcstombs_s(&ret, mOut, 6, wSimple, -1/*_TRUNCATE*/); + err = pwcstombs_s(&ret, mOut, 6, wSimple, _TRUNCATE); ok(err == 0, "err = %d\n", err); ok(ret == 5, "ret = %d\n", (int)ret); ok(!memcmp(mOut, mSimple, sizeof(mSimple)), "mOut = %s\n", mOut); - err = pwcstombs_s(&ret, mOut, 6, wHiragana, -1/*_TRUNCATE*/); + err = pwcstombs_s(&ret, mOut, 6, wHiragana, _TRUNCATE); ok(err == 0, "err = %d\n", err); ok(ret == 5, "ret = %d\n", (int)ret); ok(!memcmp(mOut, mHiragana, sizeof(mHiragana)), "mOut = %s\n", mOut); diff --git a/include/msvcrt/stdlib.h b/include/msvcrt/stdlib.h index 6633ee9..35a9782 100644 --- a/include/msvcrt/stdlib.h +++ b/include/msvcrt/stdlib.h @@ -47,6 +47,8 @@ typedef struct #define _MAX_PATH 260 #endif +/* Make the secure string functions (names end in "_s") truncate their output */ +#define _TRUNCATE ((size_t)-1) typedef struct _div_t { int quot;

1 0

Alexander Scott-Johns : msvcrt: Rename _TRUNCATE to MSVCRT__TRUNCATE.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: 2663079c6036f07053f4627f4dbf1193b579e148 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2663079c6036f07053f4627f4… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Sun Jun 6 16:11:09 2010 +0100 msvcrt: Rename _TRUNCATE to MSVCRT__TRUNCATE. --- dlls/msvcrt/heap.c | 4 ++-- dlls/msvcrt/mbcs.c | 4 ++-- dlls/msvcrt/msvcrt.h | 2 +- dlls/msvcrt/wcs.c | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/msvcrt/heap.c b/dlls/msvcrt/heap.c index ad6bb37..b1d4076 100644 --- a/dlls/msvcrt/heap.c +++ b/dlls/msvcrt/heap.c @@ -578,7 +578,7 @@ int CDECL strncpy_s(char *dest, MSVCRT_size_t numberOfElements, return MSVCRT_EINVAL; } - if(count!=_TRUNCATE && count<numberOfElements) + if(count!=MSVCRT__TRUNCATE && count<numberOfElements) end = count; else end = numberOfElements-1; @@ -586,7 +586,7 @@ int CDECL strncpy_s(char *dest, MSVCRT_size_t numberOfElements, for(i=0; i<end && src[i]; i++) dest[i] = src[i]; - if(!src[i] || end==count || count==_TRUNCATE) { + if(!src[i] || end==count || count==MSVCRT__TRUNCATE) { dest[i] = '\0'; return 0; } diff --git a/dlls/msvcrt/mbcs.c b/dlls/msvcrt/mbcs.c index 8fca06d..76d562c 100644 --- a/dlls/msvcrt/mbcs.c +++ b/dlls/msvcrt/mbcs.c @@ -1783,7 +1783,7 @@ int CDECL MSVCRT__mbstowcs_s_l(MSVCRT_size_t *ret, MSVCRT_wchar_t *wcstr, return MSVCRT_EINVAL; } - if(count==_TRUNCATE || size<count) + if(count==MSVCRT__TRUNCATE || size<count) conv = size; else conv = count; @@ -1791,7 +1791,7 @@ int CDECL MSVCRT__mbstowcs_s_l(MSVCRT_size_t *ret, MSVCRT_wchar_t *wcstr, conv = MSVCRT__mbstowcs_l(wcstr, mbstr, conv, locale); if(conv<size) wcstr[conv++] = '\0'; - else if(conv==size && (count==_TRUNCATE || wcstr[conv-1]=='\0')) + else if(conv==size && (count==MSVCRT__TRUNCATE || wcstr[conv-1]=='\0')) wcstr[conv-1] = '\0'; else { MSVCRT__invalid_parameter(NULL, NULL, NULL, 0, 0); diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 8dd8881..f68790b 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -709,7 +709,7 @@ typedef void (__cdecl *MSVCRT___sighandler_t)(int); #define _MB_CP_ANSI -3 #define _MB_CP_LOCALE -4 -#define _TRUNCATE ((MSVCRT_size_t)-1) +#define MSVCRT__TRUNCATE ((MSVCRT_size_t)-1) void __cdecl MSVCRT_free(void*); void* __cdecl MSVCRT_malloc(MSVCRT_size_t); diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index b9ac8f7..90bc3b8 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -304,7 +304,7 @@ MSVCRT_size_t CDECL MSVCRT__wcstombs_s_l(MSVCRT_size_t *ret, char *mbstr, return MSVCRT_EINVAL; } - if(count==_TRUNCATE || size<count) + if(count==MSVCRT__TRUNCATE || size<count) conv = size; else conv = count; @@ -312,7 +312,7 @@ MSVCRT_size_t CDECL MSVCRT__wcstombs_s_l(MSVCRT_size_t *ret, char *mbstr, conv = MSVCRT__wcstombs_l(mbstr, wcstr, conv, locale); if(conv<size) mbstr[conv++] = '\0'; - else if(conv==size && (count==_TRUNCATE || mbstr[conv-1]=='\0')) + else if(conv==size && (count==MSVCRT__TRUNCATE || mbstr[conv-1]=='\0')) mbstr[conv-1] = '\0'; else { MSVCRT__invalid_parameter(NULL, NULL, NULL, 0, 0); @@ -1043,7 +1043,7 @@ int CDECL MSVCRT_vsnprintf_s_l( char *str, MSVCRT_size_t sizeOfBuffer, ret = vsnprintf_internal(str, len, format, locale, TRUE, valist); if(ret<0 || ret==len) { - if(count!=_TRUNCATE && count>sizeOfBuffer) { + if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer) { MSVCRT__invalid_parameter( NULL, NULL, NULL, 0, 0 ); *MSVCRT__errno() = MSVCRT_ERANGE; memset(str, 0, sizeOfBuffer); @@ -1154,7 +1154,7 @@ int CDECL MSVCRT_vsnwprintf_s_l( MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer ret = vsnwprintf_internal(str, len, format, locale, TRUE, valist); if(ret<0 || ret==len) { - if(count!=_TRUNCATE && count>sizeOfBuffer/sizeof(MSVCRT_wchar_t)) { + if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer/sizeof(MSVCRT_wchar_t)) { MSVCRT__invalid_parameter( NULL, NULL, NULL, 0, 0 ); *MSVCRT__errno() = MSVCRT_ERANGE; memset(str, 0, sizeOfBuffer);

1 0

Alexander Scott-Johns : msvcrt/tests: Properly skip if functions are not available.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: b205fd8108eca2fd29705875e53ed852f56a6b6d URL: http://source.winehq.org/git/wine.git/?a=commit;h=b205fd8108eca2fd29705875e… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Sun Jun 6 15:27:47 2010 +0100 msvcrt/tests: Properly skip if functions are not available. --- dlls/msvcrt/tests/printf.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c index cea4db3..eaf248b 100644 --- a/dlls/msvcrt/tests/printf.c +++ b/dlls/msvcrt/tests/printf.c @@ -864,6 +864,13 @@ START_TEST(printf) p__vscprintf = (void *)GetProcAddress(GetModuleHandle("msvcrt.dll"), "_vscprintf"); p__vscwprintf = (void *)GetProcAddress(GetModuleHandle("msvcrt.dll"), "_vscwprintf"); - if (p__vscprintf) test_vscprintf(); - if (p__vscwprintf) test_vscwprintf(); + if (p__vscprintf) + test_vscprintf(); + else + win_skip("_vscprintf not available\n"); + + if (p__vscwprintf) + test_vscwprintf(); + else + win_skip("_vscwprintf not available\n"); }

1 0

Alexander Scott-Johns : msvcrt: Fix comments.
by Alexandre Julliard 07 Jun '10

07 Jun '10

Module: wine Branch: master Commit: 19bff6bda561a14766cd95a6d632dccef4aaf781 URL: http://source.winehq.org/git/wine.git/?a=commit;h=19bff6bda561a14766cd95a6d… Author: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: Sun Jun 6 15:19:14 2010 +0100 msvcrt: Fix comments. --- dlls/msvcrt/wcs.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index c26809c..b9ac8f7 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -1103,7 +1103,7 @@ int CDECL MSVCRT__snprintf(char *str, unsigned int len, const char *format, ...) } /********************************************************************* - * vsnwsprintf_internal (INTERNAL) + * vsnwprintf_internal (INTERNAL) */ static inline int vsnwprintf_internal(MSVCRT_wchar_t *str, MSVCRT_size_t len, const MSVCRT_wchar_t *format, MSVCRT__locale_t locale, BOOL valid, @@ -1120,7 +1120,7 @@ static inline int vsnwprintf_internal(MSVCRT_wchar_t *str, MSVCRT_size_t len, } /********************************************************************* - * _vsnwsprintf (MSVCRT.@) + * _vsnwprintf (MSVCRT.@) */ int CDECL MSVCRT_vsnwprintf(MSVCRT_wchar_t *str, MSVCRT_size_t len, const MSVCRT_wchar_t *format, __ms_va_list valist) @@ -1129,7 +1129,7 @@ int CDECL MSVCRT_vsnwprintf(MSVCRT_wchar_t *str, MSVCRT_size_t len, } /********************************************************************* - * _vsnwsprintf_l (MSVCRT.@) + * _vsnwprintf_l (MSVCRT.@) */ int CDECL MSVCRT_vsnwprintf_l(MSVCRT_wchar_t *str, MSVCRT_size_t len, const MSVCRT_wchar_t *format, MSVCRT__locale_t locale, @@ -1139,7 +1139,7 @@ int CDECL MSVCRT_vsnwprintf_l(MSVCRT_wchar_t *str, MSVCRT_size_t len, } /********************************************************************* - * _vsnwsprintf_s_l (MSVCRT.@) + * _vsnwprintf_s_l (MSVCRT.@) */ int CDECL MSVCRT_vsnwprintf_s_l( MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer, MSVCRT_size_t count, const MSVCRT_wchar_t *format, @@ -1168,7 +1168,7 @@ int CDECL MSVCRT_vsnwprintf_s_l( MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer } /********************************************************************* - * _vsnwsprintf_s (MSVCRT.@) + * _vsnwprintf_s (MSVCRT.@) */ int CDECL MSVCRT_vsnwprintf_s(MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer, MSVCRT_size_t count, const MSVCRT_wchar_t *format, __ms_va_list valist) @@ -1520,7 +1520,7 @@ INT CDECL MSVCRT_wcscat_s(MSVCRT_wchar_t* dst, MSVCRT_size_t elem, const MSVCRT_ } /********************************************************************* - * _wctoi64_l (MSVCRT.@) + * _wcstoi64_l (MSVCRT.@) * * FIXME: locale parameter is ignored */

1 0

← Newer
1
...
51
52
53
54
55
56
57
...
67
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2010