wine-commits March 2022

wine-commits@winehq.org

2 participants
1138 discussions

Zebediah Figura : vkd3d-utils: Avoid leaking "messages" when vkd3d_blob_create() fails.
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: vkd3d Branch: master Commit: e9fd9a79a1c3e010a4d28cfba10b06fa4e48d0f2 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=e9fd9a79a1c3e010a4d28cf… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Mar 6 20:04:34 2022 -0600 vkd3d-utils: Avoid leaking "messages" when vkd3d_blob_create() fails. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-utils/vkd3d_utils_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libs/vkd3d-utils/vkd3d_utils_main.c b/libs/vkd3d-utils/vkd3d_utils_main.c index 5534453b..9607eddd 100644 --- a/libs/vkd3d-utils/vkd3d_utils_main.c +++ b/libs/vkd3d-utils/vkd3d_utils_main.c @@ -269,6 +269,7 @@ HRESULT WINAPI D3DCompile2(const void *data, SIZE_T data_size, const char *filen { if (FAILED(hr = vkd3d_blob_create(messages, strlen(messages), messages_blob))) { + vkd3d_shader_free_messages(messages); vkd3d_shader_free_shader_code(&byte_code); return hr; } @@ -356,6 +357,7 @@ HRESULT WINAPI D3DPreprocess(const void *data, SIZE_T size, const char *filename { if (FAILED(hr = vkd3d_blob_create(messages, strlen(messages), messages_blob))) { + vkd3d_shader_free_messages(messages); vkd3d_shader_free_shader_code(&preprocessed_code); return hr; }

1 0

Francois Gouget : testbot/cgi: Add a tooltip on the 'required field' asterisks.
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: 798cc33be70ad692adc5c9fe3e4580a5eb7d7149 URL: https://source.winehq.org/git/tools.git/?a=commit;h=798cc33be70ad692adc5c9f… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:52:21 2022 +0100 testbot/cgi: Add a tooltip on the 'required field' asterisks. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 067d11b..9ea7f0f 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -305,7 +305,7 @@ sub GenerateRequired($$) if ($PropertyDescriptor->GetIsRequired()) { $self->{HasRequired} = 1; - print " <span class='Required'>*</span>"; + print " <a class='Required' title='Required field'>*</a>"; } }

1 0

Francois Gouget : testbot/cgi: Fix getting the property descriptors in FormPage::SaveProperties().
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: 2340f4d2f23c02cf35c649412a69ceb0b0fa1294 URL: https://source.winehq.org/git/tools.git/?a=commit;h=2340f4d2f23c02cf35c6494… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:52:04 2022 +0100 testbot/cgi: Fix getting the property descriptors in FormPage::SaveProperties(). The base form page has no Collection field. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 21c8631..067d11b 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -368,7 +368,7 @@ sub SaveProperties($) } } - foreach my $PropertyDescriptor (@{$self->{Collection}->GetPropertyDescriptors}) + foreach my $PropertyDescriptor (@{$self->GetPropertyDescriptors()}) { if ($PropertyDescriptor->GetClass() eq "Basic" && $PropertyDescriptor->GetType() eq "B" &&

1 0

Francois Gouget : testbot/web: Don't assume that "/index.pl" is the TestBot landing page.
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: de0ddebb90c1ff365b6bf58f43653b0957d3ed14 URL: https://source.winehq.org/git/tools.git/?a=commit;h=de0ddebb90c1ff365b6bf58… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:48:05 2022 +0100 testbot/web: Don't assume that "/index.pl" is the TestBot landing page. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/CGI/PageBase.pm | 4 ++-- testbot/web/JobDetails.pl | 2 +- testbot/web/Login.pl | 2 +- testbot/web/Submit.pl | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm index 8b046c8..2681ece 100644 --- a/testbot/lib/WineTestBot/CGI/PageBase.pm +++ b/testbot/lib/WineTestBot/CGI/PageBase.pm @@ -244,7 +244,7 @@ ${ProjectName} Test Bot <div id="menu"> <ul> <li class='top'><p>Test Bot</p></li> - <li><p><a href='/index.pl'>Home</a></p></li> + <li><p><a href='/'>Home</a></p></li> EOF if (defined($PatchesMailingList)) { @@ -307,7 +307,7 @@ EOF </div> <div id='banner'> <div id='Logo'> - <a href='/index.pl'><img src='/${ProjectName}Logo.png' alt=''></a> + <a href='/'><img src='/${ProjectName}Logo.png' alt=''></a> </div> <div id='Project'> <img src='/${ProjectName}Project.png' alt=''> diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index eef7a17..919c7a5 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -52,7 +52,7 @@ sub _initialize($$$) $self->{Job} = CreateJobs()->GetItem($JobId); if (!defined $self->{Job}) { - $self->Redirect("/index.pl"); # does not return + $self->Redirect("/"); # does not return } $self->{JobId} = $JobId; diff --git a/testbot/web/Login.pl b/testbot/web/Login.pl index ef3f4cb..d9757ed 100644 --- a/testbot/web/Login.pl +++ b/testbot/web/Login.pl @@ -133,7 +133,7 @@ sub OnLogIn($) my $Target = $self->GetParam("Target"); if (! defined($Target) || $Target eq "" || substr($Target, 0, 1) ne "/") { - $Target = "/index.pl"; + $Target = "/"; } $self->Redirect(MakeSecureURL($Target)); # does not return exit; diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index 9a7ac0b..98d1338 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -1329,7 +1329,7 @@ sub OnOK($) } else { - $self->Redirect("/index.pl"); # does not return + $self->Redirect("/"); # does not return } }

1 0

Francois Gouget : testbot/web: Better separate GetParam() and SetParam().
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: 81cc4388e64e1d0af6a7a57d46fae182e222780e URL: https://source.winehq.org/git/tools.git/?a=commit;h=81cc4388e64e1d0af6a7a57… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:47:47 2022 +0100 testbot/web: Better separate GetParam() and SetParam(). Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/Page.pm | 39 ++++++++++++++++++++++++++++++++----- testbot/web/Feedback.pl | 6 +++--- testbot/web/Register.pl | 4 ++-- 3 files changed, 39 insertions(+), 10 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm index b910228..8abaaaa 100644 --- a/testbot/lib/ObjectModel/CGI/Page.pm +++ b/testbot/lib/ObjectModel/CGI/Page.pm @@ -77,18 +77,47 @@ sub GetParamNames($) =head1 C<GetParam()> -This thunks to CGI::param() and thus takes the same arguments list but forces -the result to scalar context to avoid security issues. +Returns the specified parameter. +Note that unlike CGI::param() this forces the result to scalar context to +avoid security issues. + To get the list of parameter names use GetParamNames(). =back =cut -sub GetParam($@) +sub GetParam($$) { - my $self = shift; + my ($self, $Name) = @_; + + return scalar($self->{CGIObj}->param($Name)); +} + +=pod +=over 12 + +=head1 C<SetParam()> - return scalar($self->{CGIObj}->param(@_)); +Sets the specified parameter or removes it from the parameters list if the +value is undefined. + +To get the list of parameter names use GetParamNames(). + +=back +=cut + +sub SetParam($$$) +{ + my ($self, $Name, $Value) = @_; + + if (defined $Value) + { + $self->{CGIObj}->param($Name, $Value); + } + else + { + $self->{CGIObj}->delete($Name); + } } sub CGI($) diff --git a/testbot/web/Feedback.pl b/testbot/web/Feedback.pl index 9eba086..ca1ee5e 100644 --- a/testbot/web/Feedback.pl +++ b/testbot/web/Feedback.pl @@ -41,7 +41,7 @@ sub _initialize($$$) ); if (!$Session and $RegistrationQ) { - $self->GetParam("FeedA", "") if (!defined $self->GetParam("FeedA")); + $self->SetParam("FeedA", "") if (!defined $self->GetParam("FeedA")); push @PropertyDescriptors, CreateBasicPropertyDescriptor("FeedA", "Please demonstrate you are not a bot by answering this question: $RegistrationQ", !1, 1, "A", 40); } @@ -51,8 +51,8 @@ sub _initialize($$$) { # Provide default values my $User = $Session->User; - $self->GetParam("Name", $User->RealName) if (!defined $self->GetParam("Name")); - $self->GetParam("EMail", $User->EMail) if (!defined $self->GetParam("EMail")); + $self->SetParam("Name", $User->RealName) if (!defined $self->GetParam("Name")); + $self->SetParam("EMail", $User->EMail) if (!defined $self->GetParam("EMail")); } } diff --git a/testbot/web/Register.pl b/testbot/web/Register.pl index 23f57a9..4cfef79 100644 --- a/testbot/web/Register.pl +++ b/testbot/web/Register.pl @@ -40,11 +40,11 @@ sub _initialize($$$) $self->{ExtraProperties} = []; if ($RegistrationQ) { - $self->GetParam("RegA", "") if (!defined $self->GetParam("RegA")); + $self->SetParam("RegA", "") if (!defined $self->GetParam("RegA")); push @{$self->{ExtraProperties}}, CreateBasicPropertyDescriptor("RegA", "Please demonstrate you are not a bot by answering this question: $RegistrationQ", !1, 1, "A", 40); } - $self->GetParam("Remarks", "") if (!defined $self->GetParam("Remarks")); + $self->SetParam("Remarks", "") if (!defined $self->GetParam("Remarks")); push @{$self->{ExtraProperties}}, CreateBasicPropertyDescriptor("Remarks", "Remarks", !1, !1, "textarea", 160); }

1 0

Francois Gouget : testbot/cgi: !1 is really an empty string in FormPage::SaveProperties().
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: aa8d29559c08cbab0b750278cd506f49c0330f34 URL: https://source.winehq.org/git/tools.git/?a=commit;h=aa8d29559c08cbab0b75027… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:46:21 2022 +0100 testbot/cgi: !1 is really an empty string in FormPage::SaveProperties(). So the point of that SaveProperty() call is that if an editable property value was not received as a form parameter it is considered to be an empty string. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 43b9b59..21c8631 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -375,7 +375,7 @@ sub SaveProperties($) $self->DisplayProperty($PropertyDescriptor) eq "rw" && ! defined($self->GetParam($PropertyDescriptor->GetName()))) { - if (! $self->SaveProperty($PropertyDescriptor, !1)) + if (! $self->SaveProperty($PropertyDescriptor, "")) { return !1; }

1 0

Francois Gouget : testbot/web: Remove end-of-line spaces in the css file.
by Alexandre Julliard 07 Mar '22

07 Mar '22

Module: tools Branch: master Commit: ff224083216bc58f78650a5450abadd331d51698 URL: https://source.winehq.org/git/tools.git/?a=commit;h=ff224083216bc58f78650a5… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 7 12:45:35 2022 +0100 testbot/web: Remove end-of-line spaces in the css file. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/WineTestBot.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/web/WineTestBot.css b/testbot/web/WineTestBot.css index 6d170b1..301ba71 100644 --- a/testbot/web/WineTestBot.css +++ b/testbot/web/WineTestBot.css @@ -123,7 +123,7 @@ A:hover position: relative; bottom: 0.5em; font-size: 0.8em; -} +} h1, h2 { @@ -145,7 +145,7 @@ h2 font-size: 14pt; } -.DetailsBody p +.DetailsBody p { text-align: center; } @@ -175,7 +175,7 @@ h2 margin-top: 2em } -.ItemBody p +.ItemBody p { text-align: center; }

1 0

Paul Gofman : ws2_32: Base inet_addr() implementation on musl.
by Alexandre Julliard 04 Mar '22

04 Mar '22

Module: wine Branch: master Commit: 18230d23c599f1f5f9dd419dccc11c49117cc3b8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=18230d23c599f1f5f9dd419d… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Mar 3 13:32:26 2022 +0300 ws2_32: Base inet_addr() implementation on musl. The imported algorithm is modified to match the tests. Fixes a regression introduced by commit 671cf16f773e5dafc7edbf7766aed9e52e4e7b56. Windows inet_addr() behaves basically the same as Unix inet_addr() which is different from inet_pton(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/protocol.c | 52 ++++++++++++++++++++-- dlls/ws2_32/tests/protocol.c | 103 ++++++++++++++++++++++++++++++++++++++----- 2 files changed, 141 insertions(+), 14 deletions(-) diff --git a/dlls/ws2_32/protocol.c b/dlls/ws2_32/protocol.c index 0f56b1604d8..6e7e8eee18a 100644 --- a/dlls/ws2_32/protocol.c +++ b/dlls/ws2_32/protocol.c @@ -1834,17 +1834,61 @@ int WINAPI WSAAddressToStringW( struct sockaddr *addr, DWORD addr_len, return 0; } - /*********************************************************************** * inet_addr (ws2_32.11) */ u_long WINAPI inet_addr( const char *str ) { + unsigned long a[4] = { 0 }; + const char *s = str; + unsigned char *d; + unsigned int i; u_long addr; + char *z; + + TRACE( "str %s.\n", debugstr_a(str) ); + + if (!s) + { + SetLastError( WSAEFAULT ); + return INADDR_NONE; + } + + d = (unsigned char *)&addr; + + if (s[0] == ' ' && !s[1]) return 0; - if (inet_pton( AF_INET, str, &addr ) == 1) - return addr; - return INADDR_NONE; + for (i = 0; i < 4; ++i) + { + a[i] = strtoul( s, &z, 0 ); + if (z == s || !isdigit( *s )) return INADDR_NONE; + if (!*z || isspace(*z)) break; + if (*z != '.') return INADDR_NONE; + s = z + 1; + } + + if (i == 4) return INADDR_NONE; + + switch (i) + { + case 0: + a[1] = a[0] & 0xffffff; + a[0] >>= 24; + /* fallthrough */ + case 1: + a[2] = a[1] & 0xffff; + a[1] >>= 16; + /* fallthrough */ + case 2: + a[3] = a[2] & 0xff; + a[2] >>= 8; + } + for (i = 0; i < 4; ++i) + { + if (a[i] > 255) return INADDR_NONE; + d[i] = a[i]; + } + return addr; } diff --git a/dlls/ws2_32/tests/protocol.c b/dlls/ws2_32/tests/protocol.c index 374fa01789d..9b3dec39dad 100644 --- a/dlls/ws2_32/tests/protocol.c +++ b/dlls/ws2_32/tests/protocol.c @@ -674,6 +674,98 @@ static void test_inet_ntoa(void) CloseHandle(thread); } +static void test_inet_addr(void) +{ + static const struct + { + const char *input; + u_long addr; + } + tests[] = + { + {"1.2.3.4", 0x04030201}, + {"1 2 3 4", 0x01000000}, + {"1.2.3. 4", 0xffffffff}, + {"1.2.3 .4", 0x03000201}, + {"1.2.3 \xfe\xff", 0x03000201}, + {"3.4.5.6.7", 0xffffffff}, + {"3.4.5.6. 7", 0xffffffff}, + {"3.4.5.6 7", 0x06050403}, + {" 3.4.5.6", 0xffffffff}, + {"\t3.4.5.6", 0xffffffff}, + {"3.4.5.6 ", 0x06050403}, + {"3.4.5.6 ", 0x06050403}, + {"3. 4.5.6", 0xffffffff}, + {"3 .4.5.6", 0x03000000}, + {"1.2.3", 0x03000201}, + {".1.2.3", 0xffffffff}, + {"0.0.0.0", 0x00000000}, + {"", 0xffffffff}, + {" 0", 0xffffffff}, + {"0xa1a2b3b4 ", 0xb4b3a2a1}, + {".", 0xffffffff}, + {" ", 0x00000000}, + {"\t", 0xffffffff}, + {" ", 0xffffffff}, + {"127.127.127.255", 0xff7f7f7f}, + {"127.127.127.255:123", 0xffffffff}, + {"127.127.127.256", 0xffffffff}, + {"a", 0xffffffff}, + {"1.2.3.0xaA", 0xaa030201}, + {"1.1.1.0x", 0xffffffff}, + {"1.2.3.010", 0x08030201}, + {"1.2.3.00", 0x00030201}, + {"1.2.3.0a", 0xffffffff}, + {"1.1.1.0o10", 0xffffffff}, + {"1.1.1.0b10", 0xffffffff}, + {"1.1.1.-2", 0xffffffff}, + {"1", 0x01000000}, + {"1.2", 0x02000001}, + {"1.2.3", 0x03000201}, + {"203569230", 0x4e38220c}, + {"[0.1.2.3]", 0xffffffff}, + {"0x00010203", 0x03020100}, + {"0x2134", 0x34210000}, + {"1234BEEF", 0xffffffff}, + {"017700000001", 0x0100007f}, + {"0777", 0xff010000}, + {"2607:f0d0:1002:51::4", 0xffffffff}, + {"::177.32.45.20", 0xffffffff}, + {"::1/128", 0xffffffff}, + {"::1", 0xffffffff}, + {":1", 0xffffffff}, + }; + u_long addr, expected; + unsigned int i; + char str[32]; + + WSASetLastError(0xdeadbeef); + addr = inet_addr(NULL); + ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError()); + ok(addr == 0xffffffff, "got addr %#08x\n", addr); + for (i = 0; i < ARRAY_SIZE(tests); ++i) + { + winetest_push_context( "Address %s, i %u", debugstr_a(tests[i].input), i ); + WSASetLastError(0xdeadbeef); + addr = inet_addr(tests[i].input); + ok(WSAGetLastError() == 0xdeadbeef, "got error %u\n", WSAGetLastError()); + ok(addr == tests[i].addr, "got addr %#08x\n", addr); + winetest_pop_context(); + } + + strcpy(str, "1.2.3"); + str[6] = 0; + for (i = 1; i < 256; ++i) + { + if (isdigit(i)) + continue; + str[5] = i; + expected = isspace(i) ? 0x03000201 : 0xffffffff; + addr = inet_addr(str); + ok(addr == expected, "got addr %#08x, expected %#08x, i %u\n", addr, expected, i); + } +} + static void test_inet_pton(void) { static const struct @@ -942,11 +1034,6 @@ static void test_inet_pton(void) ok(ret == -1, "got %d\n", ret); ok(WSAGetLastError() == WSAEAFNOSUPPORT, "got error %u\n", WSAGetLastError()); - WSASetLastError(0xdeadbeef); - ret = inet_addr(NULL); - ok(ret == INADDR_NONE, "got %#x\n", ret); - ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError()); - for (i = 0; i < ARRAY_SIZE(ipv4_tests); ++i) { WCHAR inputW[32]; @@ -969,11 +1056,6 @@ static void test_inet_pton(void) ok(WSAGetLastError() == (ret ? 0xdeadbeef : WSAEINVAL), "got error %u\n", WSAGetLastError()); ok(addr == ipv4_tests[i].addr, "got addr %#08x\n", addr); - WSASetLastError(0xdeadbeef); - addr = inet_addr(ipv4_tests[i].input); - ok(addr == ipv4_tests[i].ret ? ipv4_tests[i].addr : INADDR_NONE, "got addr %#08x\n", addr); - ok(WSAGetLastError() == 0xdeadbeef, "got error %u\n", WSAGetLastError()); - winetest_pop_context(); } @@ -2871,6 +2953,7 @@ START_TEST( protocol ) test_WSALookupService(); test_inet_ntoa(); + test_inet_addr(); test_inet_pton(); test_addr_to_print(); test_WSAAddressToString();

1 0

Rémi Bernon : windows.gaming.input: Instantiate the WineGameControllerProvider runtimeclass.
by Alexandre Julliard 04 Mar '22

04 Mar '22

Module: wine Branch: master Commit: e171b58aae3bc42295fd49092c9ebb1ecda4c6c7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e171b58aae3bc42295fd4909… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Mar 4 10:05:10 2022 +0100 windows.gaming.input: Instantiate the WineGameControllerProvider runtimeclass. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windows.gaming.input/Makefile.in | 2 +- dlls/windows.gaming.input/main.c | 2 +- dlls/windows.gaming.input/manager.c | 10 ++ dlls/windows.gaming.input/private.h | 4 + dlls/windows.gaming.input/provider.c | 222 +++++++++++++++++++++++++++++++++- 5 files changed, 236 insertions(+), 4 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e171b58aae3bc42295fd…

1 0

Rémi Bernon : dinput: Use a custom GUID to open a device from a device path.
by Alexandre Julliard 04 Mar '22

04 Mar '22

Module: wine Branch: master Commit: 8b288980b2c8605fce1cba5426fd6c8404e898ce URL: https://source.winehq.org/git/wine.git/?a=commit;h=8b288980b2c8605fce1cba54… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Mar 4 10:05:09 2022 +0100 dinput: Use a custom GUID to open a device from a device path. So that we can access all the controller devices conveniently through DInput without having to reimplement the whole HID client, or having to enumerate the devices every time a new device needs to be open, and being able to workaround the limitations of the device the XInput controllers are usually exposing. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/joystick_hid.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/dlls/dinput/joystick_hid.c b/dlls/dinput/joystick_hid.c index 4f1c8444e43..c97588d8a07 100644 --- a/dlls/dinput/joystick_hid.c +++ b/dlls/dinput/joystick_hid.c @@ -50,6 +50,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dinput); DEFINE_GUID( GUID_DEVINTERFACE_WINEXINPUT,0x6c53d5fd,0x6480,0x440f,0xb6,0x18,0x47,0x67,0x50,0xc5,0xe1,0xa6 ); DEFINE_GUID( hid_joystick_guid, 0x9e573edb, 0x7734, 0x11d2, 0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7 ); +DEFINE_GUID( device_path_guid, 0x00000000, 0x0000, 0x0000, 0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf8 ); DEFINE_DEVPROPKEY( DEVPROPKEY_HID_HANDLE, 0xbc62e415, 0xf4fe, 0x405c, 0x8e, 0xda, 0x63, 0x6f, 0xb5, 0x9f, 0x08, 0x98, 2 ); struct pid_control_report @@ -2041,7 +2042,12 @@ HRESULT hid_joystick_create_device( struct dinput *dinput, const GUID *guid, IDi else if (IsEqualGUID( &hid_joystick_guid, &instance.guidInstance )) instance.guidInstance = *guid; else - return DIERR_DEVICENOTREG; + { + instance.guidInstance.Data1 = device_path_guid.Data1; + instance.guidInstance.Data2 = device_path_guid.Data2; + instance.guidInstance.Data3 = device_path_guid.Data3; + if (!IsEqualGUID( &device_path_guid, &instance.guidInstance )) return DIERR_DEVICENOTREG; + } hr = dinput_device_alloc( sizeof(struct hid_joystick), &hid_joystick_vtbl, guid, dinput, (void **)&impl ); if (FAILED(hr)) return hr; @@ -2050,8 +2056,16 @@ HRESULT hid_joystick_create_device( struct dinput *dinput, const GUID *guid, IDi impl->base.read_event = CreateEventW( NULL, TRUE, FALSE, NULL ); impl->internal_ref = 1; - hr = hid_joystick_device_open( -1, &instance, impl->device_path, &impl->device, &impl->preparsed, - &attrs, &impl->caps, dinput->dwVersion ); + if (!IsEqualGUID( &device_path_guid, &instance.guidInstance )) + hr = hid_joystick_device_open( -1, &instance, impl->device_path, &impl->device, &impl->preparsed, + &attrs, &impl->caps, dinput->dwVersion ); + else + { + wcscpy( impl->device_path, *(const WCHAR **)guid ); + if (!hid_joystick_device_try_open( 0, impl->device_path, &impl->device, &impl->preparsed, &attrs, + &impl->caps, &instance, dinput->dwVersion )) + hr = DIERR_DEVICENOTREG; + } if (hr != DI_OK) goto failed; impl->base.instance = instance;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2022