wine-devel October 2014

wine-devel@winehq.org

52 participants
183 discussions

Re: [PATCH 4/4] d3d9/tests: Port test_window_style to d3d9ex.
by Marvin 14 Oct '14

14 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9534 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:1294: Test failed: Got unexpected hr 0. d3d9ex.c:1296: Test failed: Got unexpected hr 0. d3d9ex.c:1298: Test failed: Got unexpected hr 0. d3d9ex.c:1300: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH 3/3] kernel32/tests: Add tests for UTF-7 conversion. (try 3.1)
by Michael Stefaniuc 14 Oct '14

14 Oct '14

Hello Alex, On 10/13/2014 08:19 AM, Alex Henrie wrote: > The only difference from the previous version of this patch is the > correction of a typo in one of the comments. > > --- > dlls/kernel32/tests/codepage.c | 751 ++++++++++++++++++++++++++++++++++ > +++++++ 1 file changed, 751 insertions(+) while more tests are good that's a lot of lines to have for just one function. So splitting the WCHAR => UTF-7 from the UTF-7 => WCHAR tests should help make it more manageable. Also some of the strings are huge. Most of those seem to be for the WCHAR => UTF-7 and could be probably generated by just using the directly_encodable_table[] from patch 2. If the tests cannot be generated from the table then please split the strings into more manageable chunks, as is they are unreadable / unmaintainable. Also the due to the size of the patch it is hard to discern what the difference between the different test structs are. Especially as the names are basically equivalent in this context: - utf16_to_utf7_tests and wcstombs_tests - utf7_to_utf16_tests and mbstowcs_tests bye michael

1 0

Re: [PATCH 3/4] d3d9/tests: Port wndproc tests to d3d9ex.
by Marvin 14 Oct '14

14 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9533 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:1294: Test failed: Got unexpected hr 0. d3d9ex.c:1296: Test failed: Got unexpected hr 0. d3d9ex.c:1298: Test failed: Got unexpected hr 0. d3d9ex.c:1300: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH 1/1] ddraw: Return the primary legacy ddraw device last.
by Stefan Dösinger 14 Oct '14

14 Oct '14

There are a few things I am wondering about and where the test can be extended: The existing test > /* Test with valid callback parameter and count the number of primary devices */ > callbackCount = 0; > ret = pDirectDrawEnumerateExA(test_count_callbackExA, &callbackCount, 0); > ok(ret == DD_OK, "Expected DD_OK, got %d\n", ret); > ok(callbackCount == 1, "Expected 1 primary device, got %d\n", callbackCount); Combined with your change that suggests that without any flag only the NULL guid is enumerated. If so I think that's worth an explicit check. Is the NULL guid enumerated when DDENUM_DETACHEDSECONDARYDEVICES and/or DDENUM_NONDISPLAYDEVICES are set? Regarding the specific changes you make: > dlls/ddraw/tests/ddrawmodes.c | 35 +++++++++++++++++++++++++++++++++++ I'd prefer that this test be moved to ddraw1.c > + static char DriverDescription[] = "DirectDraw HAL"; > + static char DriverName[] = "display"; Please do not use CamelCase or lpFoo in d3d-related code. Somewhat related, but that can be a separate patch: d3d3_EnumDevices() mentions that some games modify the strings. In your code (and the current code), such modifications would persist for the runtime of the application. It would be interesting to add a test for this. > +static BOOL WINAPI test_last_callbackExA(GUID *lpGUID, char *lpDriverDescription, > + char *lpDriverName, void *lpContext, HMONITOR hm) You should be able to combine the callbacks. Just declare a structure and put a counter in it. > +{ > + GUID **context_guid = (GUID **)lpContext; > + static GUID last_guid; I guess this works, but it is somewhat ugly. If you use a struct you can put a GUID and a BOOL guid_was_null in it. Or a GUID and a GUID *. Please extend the test to DirectDrawEnumerateA. MSDN suggests it is equivalent to DirectDrawEnumerateExA(DDENUM_NONDISPLAYDEVICES), but I have my doubts here. Comparing the strings of the non-NULL device against "DirectDraw HAL" and "display" (in the Ex and non-Ex case) would also be a good idea. Am 13.10.2014 um 21:16 schrieb Erich E. Hoover <erich.e.hoover(a)gmail.com>: > Fixes bug #37307. There are a couple of other bugs that are > preventing Urban Assault from working, but this fixes the problem with > returning the interfaces in the wrong order. > <0001-ddraw-Return-the-primary-legacy-ddraw-device-last.patch>

2 2

Re: [PATCH 1/1] d3d8/tests: Allow a width and height to be passed to create_device().
by Marvin 14 Oct '14

14 Oct '14

1 0

Re: [PATCH] vbscript: Implemented Timer
by Marvin 14 Oct '14

14 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2

Re: advapi32/tests: Don't crash on Wine in WoW setups
by Marvin 13 Oct '14

13 Oct '14

1 0

Re: [PATCH 5/5] ntdll: Implement storing DOS attributes in NtCreateFile.
by Marvin 13 Oct '14

13 Oct '14

1 0

Re: [PATCH 4/5] ntdll: Implement storing DOS attributes in NtSetInformationFile.
by Marvin 13 Oct '14

13 Oct '14

1 0

RFC: Adding distribution field to Bugzilla
by Austin English 13 Oct '14

13 Oct '14

Howdy everyone, I'd like to add a distribution field to Bugzilla, to make it easier to identify when users may have additional patches installed by their distribution and/or other distribution specific issues (e.g., https://bugs.winehq.org/show_bug.cgi?id=35413). It would be a drop down selection, with the major distributions listed (i.e., ArchLinux, Debian, Fedora, Gentoo, Mint, RedHat, Slackware, Suse, Ubuntu, other). Comments/feedback welcome. -- -Austin

6 9

← Newer
1
...
8
9
10
11
12
13
14
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel October 2014