wine-devel February 2015

wine-devel@winehq.org

58 participants
166 discussions

Re: dwrite/tests: Place test font file in a temporary location, make sure it's deleted at the end
by Marvin 23 Feb '15

23 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11677 Your paranoid android. === wvistau64 (32 bit font) === font.c:99: Test failed: failed to delete file L"wine_test_font.ttf", error 2 === w2008s64 (32 bit font) === font.c:99: Test failed: failed to delete file L"wine_test_font.ttf", error 2 === wvistau64 (64 bit font) === font.c:99: Test failed: failed to delete file L"wine_test_font.ttf", error 2 === w2008s64 (64 bit font) === font.c:99: Test failed: failed to delete file L"wine_test_font.ttf", error 2 === wvistau64 (32 bit analyzer) === analyzer.c:474: Test failed: failed to delete file L"C:\\Users\\winetest\\AppData\\Local\\Temp\\wine_test_font.ttf", error 5 === w2008s64 (32 bit analyzer) === analyzer.c:474: Test failed: failed to delete file L"C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\wine_test_font.ttf", error 5 === wvistau64 (64 bit analyzer) === analyzer.c:474: Test failed: failed to delete file L"C:\\Users\\winetest\\AppData\\Local\\Temp\\wine_test_font.ttf", error 5 === w2008s64 (64 bit analyzer) === analyzer.c:474: Test failed: failed to delete file L"C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\wine_test_font.ttf", error 5

1 0

Abbreviation of "microsecond" in sane.ds
by Alex Henrie 23 Feb '15

23 Feb '15

http://source.winehq.org/git/wine.git/blob/c72f9a0082c3cc07454fb93bca88e294… Is there a compelling reason why "microsecond" is abbreviated as "us" instead of "μs"? This library doesn't correspond to any Windows library, so we should be free to use the more correct abbreviation. Or can sane.rc only accept ASCII characters? -Alex

3 3

Re: mshtml/tests: Remove an always true conditional subexpression (PVS-Studio)
by Marvin 23 Feb '15

23 Feb '15

2 1

Re: fltmgr.sys: add stub dll (try 2)
by Alistair Leslie-Hughes 23 Feb '15

23 Feb '15

On 11/02/15 08:15, Austin English wrote: > https://bugs.winehq.org/show_bug.cgi?id=23583 > > -- > -Austin > This file belongs in the "system32\drivers" directory. Best Regards Alistair Leslie-Hughes

2 1

Re: [2/2] version: Test for VerQueryValueA
by Stefan Dösinger 23 Feb '15

23 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-18 um 22:41 schrieb Mark Jansen: > + char preparedbuffer[] = { > + 0x04, 0x01, 0x34, 0x00, 0x00, 0x00, 0x56, 0x00, 0x53, 0x00, 0x5f, 0x00, 0x56, 0x00, 0x45, 0x00, > + 0x52, 0x00, 0x53, 0x00, 0x49, 0x00, 0x4f, 0x00, 0x4e, 0x00, 0x5f, 0x00, 0x49, 0x00, 0x4e, 0x00, > + 0x46, 0x00, 0x4f, 0x00, 0x00, 0x00, 0x00, 0x00, 0xbd, 0x04, 0xef, 0xfe, 0x00, 0x00, 0x01, 0x00, > + 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, > ... Is it possible to put the test data into dlls/version/test/version.rc in plain text instead of using an unreadable blob? If not, please add a comment to explain what is in the blob. > + ret = VerQueryValueA(preparedbuffer, "StringFileInfo", (LPVOID*)&p, &len); > + ok(ret, "VerQueryValue error %u\n", GetLastError()); > + ok(len == 0, "VerQueryValue returned %u, expected 0\n", len); > + ok(p != (char *)0xdeadbeef, "not expected 0xdeadbeef\n"); Does p point to a 0 byte now? (i.e., ok(!*p, "Expected a terminated string\n"); or something like this.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU6ukyAAoJEN0/YqbEcdMwivkQAIz6mLYCOP2607ACoDIuX58M 5oaF83RA4wjqTAtOQYbIGFqTtM0kT5rANLgh5cMkgNETSttl8ZgJlyECUmz8ArHA VQv0kr0VsgdurFmhoxA37Cw9kou4b2hgsyimfr0dvjahJAroZJgIzXSbtUVgMVQ3 SUoluqPMSuXod/xW78lVwLI5HLm79/cJdizo+PiWLmLrlNiga6k295eKAfd5Tcco qHo+bCf56s0FRlaD4eZ+5AWl5nDP0eP7aGpddBtk4a0Y5E/3npD+9KE2L/hIlTdy kbSSW+NUfWAIUKzVFgVr9m/ejGjTMCb6ieHfuK/7S9oU6jCJyM/mwg++vsgdUJbI ts03c3UXV/JXGuDSEkxqMNLdhVM0Jv9RLCz4GlwdH7LlSiO9UOGjUpMF2steuULm FwirfHXCV1FyZBWIZyHfUw9wykoY4613S49Iq3EGZKKPQmzSi0p+Aygm2Mz6+LhM ApI/rVpGs7rqTxYZWZEgcaadpCGlwczOrgbQYEEoxdaYMm8GbEWRyDXjsHiC9NF4 RbWV+n69+wzC7bOIYqHQSkXEWNEuFlLjn4MElHCqBkGlwTsw9HIPofN6wDbORONt xKP5s14VduDyJdT21jYLJJUvIxO3R7OSNxoWIoKBOofFlQeT0c6WHvnqSqW9e7ED sX3108dzC77WwIVODqFm =gsJF -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/3] ntdll/tests: Add tests for RtlIpv6StringToAddress (try 3)
by Stefan Dösinger 23 Feb '15

23 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks again for your work and patience! This goes in the right direction in my eyes. The full set of address tests are run against both versions, and it documents the differences between non-ex and ex better. Can you do the same with the ipv4 tests in patch 1? Am 2015-02-19 um 23:38 schrieb Mark Jansen: > +/* ipv6 addresses from https://github.com/beaugunderson/javascript-ipv6/tree/master/test/data */ > +static const struct > +{ > + PCSTR address; > + NTSTATUS res; > + int terminator_offset; > + int ip[8]; > + int broken; What is the meaning of broken here? Different behavior among different Windows versions? Or deviation from your source above? > + int ex_fails; /* 1 means ex should fail, 2 means skip for ex */ Style hint: You can use an enum in this case. I guess you need the skip value because the last test fails on non-ex and succeeds on ex and your expected address does not match. Similarly, the behavior that the function writes to the output address even in case of a failure isn't exactly helpful. - From patch 3: > + if (ipv6_tests[i].ex_fails == 2) /* testing vs ex doesnt >make sense. */ > + continue; Please document why, it took me a while to come up with the guess above. (And I'm not even sure it's the real reason). You're also not checking the output IP for the IP tests from the non-ex tests here. Is there a reason for that? Are there any cases where -Ex returns a different IP than non-ex? > + if (ipv6_tests[i].ip[0] == -1) > + { > + for (j = 0; j < 8; ++j) > + expected_ip.s6_words[j] = 0xabab; > + } I guess you want to avoid writing 0xabab 8 times in the table. I don't have any objection, but I can't predict if Alexandre likes it - technically this is redundant code. I'd say keep it for now, if he doesn't like it he will tell you. > + for (j = 0; j < 8; ++j) > + expected_ip.s6_words[j] = ipv6_tests[i].ip[j]; Would this do the right thing on big endian machines? About some individual tests: > + { "1111:2222:3333:4444:5555:6666:7777::", STATUS_SUCCESS, 34, { 0x1111, 0x2222, 0x3333, 0x4444, 0x5555, 0x6666, 0x7777, 0 }, 1 }, Now that's an interesting corner case. Out of curiosity, what does "1111:2222:3333:4444:5555:6666:7777:" do in non-ex and ex (one : removed)? > + { "::0:0:0:0:0:0:0", STATUS_SUCCESS, 13, { 0, 0, 0, 0, 0, 0, 0, 0 }, 0, 1 }, > + { "::0:a:b:c:d:e:f", STATUS_SUCCESS, 13, { 0, 0, 0, 0xa00, 0xb00, 0xc00, 0xd00, 0xe00 }, 0, 1 }, Here it would be interesting to know what IP -Ex writes before it fails. I don't see why -Ex would fail if -Ex calls non-ex, given that the terminator points way beyond the problematic "::" at the start. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU5xDbAAoJEN0/YqbEcdMwmEIP/0ti3aPWMeI8yetig2eTIuAG 2QhNad7bgFgioJBremjKPDuDJViYhkv4XoIwie6bRFSF9VnEECmiv2wObhRz2e0E MgK1bGkZc0BXs4TiVoa/+JVxWgo3ddWn1Wpj+hyVRAvyEfj4NNfRWvcGaQ+cZmwu Sd0tx7BqCQLSPnNwyrl53nqVWjkkmARdSF2pLDMgXkwtGXlR2b2irYslYg+Sqgvb +ORAryKZvVLt8vL6wBclb8ruFWpro7/Rio6eZb8EfoRNH+8YdYWUrdfcoCE4Ui0i W2xsOnahZuPvuQR9id8zp4etIa+YrlGlVsIfHZrzDzCvbyuBlq+niSeWZxgNwMs+ IUpHoHj0TYNUZ9A7PB16UPHowsPVE5GYvsdjFr4Rj8rHxQqvftpTwFxRqWuV4qkQ Qx+achRcfA/qXWWYHksENuQJxF29vIbgiLbpvW256A6zmsAvB/+LlqndeF+BuW4I 3rQ2H7ADBAMx8IscePSDNLAKd2vsYWj8gFlw7y10HnIE7/zedqtWPIaGocFnS0u5 QR/ETfUW5uvOr4rqMcyMCxg3yhc/QvYV67LFMrLusJ1IlCBhcfAC4r2B91sECHXr fJvdfGwL6HBt3tAJ5zxXZjTEwiFc77TGxswbt4lQplhFqTHfi/ZovGUiS/W3nQl6 vX0zFtoYLTRAK0KtCNiP =JRkZ -----END PGP SIGNATURE-----

2 3

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 7)
by Stefan Dösinger 23 Feb '15

23 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks again for your work! Am 2015-02-23 um 08:41 schrieb Alistair Leslie-Hughes: > +{ > + if (!This->comp_count) > + This->components = heap_alloc( sizeof(struct component *) * This->comp_count+1 ); > + else > + This->components = heap_realloc(This->components, sizeof(struct component *) * This->comp_count+1 ); > + > + This->components[This->comp_count] = item; > + This->comp_count++; > +} This still has no error checks. > @@ -369,9 +397,48 @@ static HRESULT WINAPI IDirectPlay8AddressImpl_GetComponentByIndex(IDirectPlay8Ad > const DWORD dwComponentID, WCHAR *pwszName, DWORD *pdwNameLen, void *pvBuffer, > DWORD *pdwBufferSize, DWORD *pdwDataType) > { > ... > + if (!pdwNameLen || !pdwBufferSize) > + return E_POINTER; In GetComponentByName you have additional checks for !pvBuffer. What is pwszName name used for? Are you supposed to write the name of the retrieved component (with proper length checks)? > case DPNA_DATATYPE_STRING: > + if(dwDataSize != ((strlenW((WCHAR*)lpvData)+1) * sizeof(WCHAR))) > + return DPNERR_INVALIDPARAM; I expect this also applies to DPNA_DATATYPE_STRING_ANSI. Please move it to a separate patch (preferably before the GetComponentByIndex changes), together with the tests for the length check. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU6uQ9AAoJEN0/YqbEcdMwW4wP/0wYOQ+Sw3FZw/TAQ682yMmb FJBuRuymWoQthCAnc7kS7wsDwz+erbNPqjFE/MUrbuTHeIRtRJegtMTcLsq/ycSx pzV9uaZoG9MkGMPky/TTgWAyOvWu6w1fVBgUunnQlX8okMk+HMve+qiayeuHSgj9 CyznrrG/gLsVamZfJidnpMlwJ3a2Az5GOYG3yoCKGEiBzthS8niRvf4PLrNa/T5s /YUcfoorChwNnTEu1F+BEJt/CJTFy+qnrGOplDo5cCG6XJ9cK10JEsXybShSA1LT byol2yxMHNR1MdKw/ZsDJiS8RDnCPKTZiaY45FB7BZkyle5J/jJ9wfkBX/L+ID3M mMM1qo5nKjjbiICMkYIRHO4LW9lyCT4FKBLkXwGWTo7Npxpb7iB5Jo2X5sl8o3K4 d1TL7kjdmIj3nz+TbPyVrZZHV4GkBJ3Wgmv1b+uNdPQ6SSotzy6I6FzG1YkivQvF mo8cFFJTs0OO/fUBN5wggkiU4YAheHn258wz7EcepyPMH431GsFp9QVcZbNEQVNi hEasoqLeql/GzI0ZRmOLTLdueVsajZGhoHLGgN10SSql60dfsPZhfpQMrhsX8HQf Ub5SXqAWAc3vZmvv1I1POyUATNxTV8WWZfSmd7QBv+4qsJX2hsXE3Y4/I8cmIv0I OonvF4surL4lU+vFIkJC =eOzT -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 7)
by Marvin 23 Feb '15

23 Feb '15

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 6)
by Marvin 23 Feb '15

23 Feb '15

1 0

Want to work in your project in Google summer of code 2015
by Shanti Swarup Tunga 22 Feb '15

22 Feb '15

Sir I Shanti Swarup Tunga , having good knowledge in C programming want to work in your project . So kindly suggest me some prerequisite knowledge to apply for your project.

2 1

← Newer
1
2
3
4
5
6
7
8
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2015